clone: detect and fail on excess parameters

"git clone [options] $src $dst excess-garbage" simply ignored
excess-garbage without giving any diagnostic message.  Fix it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/git-clone.sh b/git-clone.sh
index 2636159aaa7a6278d9b8fc64b853b319ac8da123..9e433c08086f3a80c91cc9dae1e48c88723b82f8 100755 (executable)
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -219,6 +219,7 @@ fi
 if test -n "$2"
 then
        dir="$2"
 if test -n "$2"
 then
        dir="$2"

+       test $# == 2 || die "excess parameter to git-clone"

 else
        # Derive one from the repository name
        # Try using "humanish" part of source repo if user didn't specify one
 else
        # Derive one from the repository name
        # Try using "humanish" part of source repo if user didn't specify one

diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
new file mode 100755 (executable)
index 0000000..dc9d63d
--- /dev/null
+++ b/t/t5601-clone.sh
@@ -0,0 +1,26 @@
+#!/bin/sh
+
+test_description=clone
+
+. ./test-lib.sh
+
+test_expect_success setup '
+
+       rm -fr .git &&
+       test_create_repo src &&
+       (
+               cd src
+               >file
+               git add file
+               git commit -m initial
+       )
+
+'
+
+test_expect_success 'clone with excess parameters' '
+
+       test_must_fail git clone -n "file://$(pwd)/src" dst junk
+
+'
+
+test_done