Don't dereference a strdup-returned NULL

There are only a dozen or so uses of strdup in all of git.
Of those, most seem ok, but this one isn't:

Signed-off-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/remote.c b/remote.c
index 33c8e5055b8139fd248cd7b9250fa6e53f829ffa..ed62a62fa0d5eab7d154233f94e4dad1fc9fbe2f 100644 (file)
--- a/remote.c
+++ b/remote.c
@@ -542,7 +542,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail,
                        strcpy(dst_name, pat->dst);
                        strcat(dst_name, src->name + strlen(pat->src));
                } else
                        strcpy(dst_name, pat->dst);
                        strcat(dst_name, src->name + strlen(pat->src));
                } else

-                       dst_name = strdup(src->name);
+                       dst_name = xstrdup(src->name);

                dst_peer = find_ref_by_name(dst, dst_name);
                if (dst_peer && dst_peer->peer_ref)
                        /* We're already sending something to this ref. */
                dst_peer = find_ref_by_name(dst, dst_name);
                if (dst_peer && dst_peer->peer_ref)
                        /* We're already sending something to this ref. */