refs.c: make write_ref_sha1 static

No external users call write_ref_sha1 any more so let's declare it static.

Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/refs.c b/refs.c
index 9d9bbebfb9b410614ac9e7565a89ae273534421d..6b4236a67f1eec5635ae89c70e81cd92d692f9db 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -2706,6 +2706,9 @@ static int rename_ref_available(const char *oldname, const char *newname)
        return ret;
 }
 
        return ret;
 }
 

+static int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1,
+                         const char *logmsg);
+

 int rename_ref(const char *oldrefname, const char *newrefname, const char *logmsg)
 {
        unsigned char sha1[20], orig_sha1[20];
 int rename_ref(const char *oldrefname, const char *newrefname, const char *logmsg)
 {
        unsigned char sha1[20], orig_sha1[20];


@@ -2950,8 +2953,11 @@ int is_branch(const char *refname)
        return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
 }
 
        return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/");
 }
 

-/* This function must return a meaningful errno */
-int write_ref_sha1(struct ref_lock *lock,
+/*
+ * Write sha1 into the ref specified by the lock. Make sure that errno
+ * is sane on error.
+ */
+static int write_ref_sha1(struct ref_lock *lock,

        const unsigned char *sha1, const char *logmsg)
 {
        static char term = '\n';
        const unsigned char *sha1, const char *logmsg)
 {
        static char term = '\n';

diff --git a/refs.h b/refs.h
index 50b115acc13a31e3d26886366cdf64aabfa17ceb..eea104478fce285943dc7c4b7f43b9db18e71cee 100644 (file)
--- a/refs.h
+++ b/refs.h
@@ -197,9 +197,6 @@ extern int commit_ref(struct ref_lock *lock);
 /** Release any lock taken but not written. **/
 extern void unlock_ref(struct ref_lock *lock);
 
 /** Release any lock taken but not written. **/
 extern void unlock_ref(struct ref_lock *lock);
 

-/** Writes sha1 into the ref specified by the lock. **/
-extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *msg);
-

 /*
  * Setup reflog before using. Set errno to something meaningful on failure.
  */
 /*
  * Setup reflog before using. Set errno to something meaningful on failure.
  */