t4018: reduce test files for pattern compilation tests

All test cases that need a file with specific text patterns have been
converted to utilize texts in the t4018/ directory. The remaining tests
in the test script deal only with the validity of the regular
expressions. These tests do not depend on the contents of files that
'git diff' is invoked on. Remove the largish here-document and use only
tiny files.

While we are touching these tests, convert grep to test_i18ngrep as the
texts checked for may undergo translation in the future.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh
index 5ac744f3973ea6c73326ce4d260530f46c552665..34591c23da82230f2412b46620f0d3a12188656f 100755 (executable)
--- a/t/t4018-diff-funcname.sh
+++ b/t/t4018-diff-funcname.sh
@@ -7,29 +7,6 @@ test_description='Test custom diff function name patterns'
 
 . ./test-lib.sh
 
 
 . ./test-lib.sh
 

-LF='
-'
-cat >Beer.java <<\EOF
-public class Beer
-{
-       int special;
-       public static void main(String args[])
-       {
-               String s=" ";
-               for(int x = 99; x > 0; x--)
-               {
-                       System.out.print(x + " bottles of beer on the wall "
-                               + x + " bottles of beer\n"
-                               + "Take one down, pass it around, " + (x - 1)
-                               + " bottles of beer on the wall.\n");
-               }
-               System.out.print("Go to the store, buy some more,\n"
-                       + "99 bottles of beer on the wall.\n");
-       }
-}
-EOF
-sed 's/beer\\/beer,\\/' <Beer.java >Beer-correct.java
-

 test_expect_success 'setup' '
        # a non-trivial custom pattern
        git config diff.custom1.funcname "!static
 test_expect_success 'setup' '
        # a non-trivial custom pattern
        git config diff.custom1.funcname "!static


@@ -41,7 +18,11 @@ test_expect_success 'setup' '
 
        # alternation in pattern
        git config diff.custom3.funcname "Beer$" &&
 
        # alternation in pattern
        git config diff.custom3.funcname "Beer$" &&

-       git config diff.custom3.xfuncname "^[   ]*((public|static).*)$"
+       git config diff.custom3.xfuncname "^[   ]*((public|static).*)$" &&
+
+       # for regexp compilation tests
+       echo A >A.java &&
+       echo B >B.java

 '
 
 diffpatterns="
 '
 
 diffpatterns="


@@ -70,29 +51,24 @@ do
        test_expect_success "builtin $p pattern compiles" '
                echo "*.java diff=$p" >.gitattributes &&
                test_expect_code 1 git diff --no-index \
        test_expect_success "builtin $p pattern compiles" '
                echo "*.java diff=$p" >.gitattributes &&
                test_expect_code 1 git diff --no-index \

-                       Beer.java Beer-correct.java 2>msg &&
-               ! grep fatal msg &&
-               ! grep error msg
+                       A.java B.java 2>msg &&
+               ! test_i18ngrep fatal msg &&
+               ! test_i18ngrep error msg

        '
        test_expect_success "builtin $p wordRegex pattern compiles" '
                echo "*.java diff=$p" >.gitattributes &&
                test_expect_code 1 git diff --no-index --word-diff \
        '
        test_expect_success "builtin $p wordRegex pattern compiles" '
                echo "*.java diff=$p" >.gitattributes &&
                test_expect_code 1 git diff --no-index --word-diff \

-                       Beer.java Beer-correct.java 2>msg &&
-               ! grep fatal msg &&
-               ! grep error msg
+                       A.java B.java 2>msg &&
+               ! test_i18ngrep fatal msg &&
+               ! test_i18ngrep error msg

        '
 done
 
        '
 done
 

-test_expect_success 'set up .gitattributes declaring drivers to test' '
-       cat >.gitattributes <<-\EOF
-       *.java diff=java
-       EOF
-'
-

 test_expect_success 'last regexp must not be negated' '
 test_expect_success 'last regexp must not be negated' '

+       echo "*.java diff=java" >.gitattributes &&

        test_config diff.java.funcname "!static" &&
        test_config diff.java.funcname "!static" &&

-       test_expect_code 128 git diff --no-index Beer.java Beer-correct.java 2>msg &&
-       grep ": Last expression must not be negated:" msg
+       test_expect_code 128 git diff --no-index A.java B.java 2>msg &&
+       test_i18ngrep ": Last expression must not be negated:" msg

 '
 
 test_expect_success 'setup hunk header tests' '
 '
 
 test_expect_success 'setup hunk header tests' '