Merge branch 'jc/calloc-pathspec' into maint
authorJunio C Hamano <gitster@pobox.com>
Fri, 4 Sep 2015 02:18:00 +0000 (19:18 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 4 Sep 2015 02:18:00 +0000 (19:18 -0700)
Minor code cleanup.

* jc/calloc-pathspec:
ps_matched: xcalloc() takes nmemb and then element size

1  2 
builtin/checkout.c
diff --combined builtin/checkout.c
index f71844a23a9d4bda0664bec709648911bc0f2609,4f826e3b034eebcc2980f935ac4096be466d5fb1..3b6e4999299484d30a41e0d787086a367ee70e5c
@@@ -19,6 -19,7 +19,6 @@@
  #include "ll-merge.h"
  #include "resolve-undo.h"
  #include "submodule.h"
 -#include "argv-array.h"
  
  static const char * const checkout_usage[] = {
        N_("git checkout [<options>] <branch>"),
@@@ -35,7 -36,6 +35,7 @@@ struct checkout_opts 
        int writeout_stage;
        int overwrite_ignore;
        int ignore_skipworktree;
 +      int ignore_other_worktrees;
  
        const char *new_branch;
        const char *new_branch_force;
@@@ -48,8 -48,6 +48,8 @@@
        const char *prefix;
        struct pathspec pathspec;
        struct tree *source_tree;
 +
 +      int new_worktree_mode;
  };
  
  static int post_checkout_hook(struct commit *old, struct commit *new,
@@@ -282,7 -280,7 +282,7 @@@ static int checkout_paths(const struct 
        if (opts->source_tree)
                read_tree_some(opts->source_tree, &opts->pathspec);
  
-       ps_matched = xcalloc(1, opts->pathspec.nr);
+       ps_matched = xcalloc(opts->pathspec.nr, 1);
  
        /*
         * Make sure all pathspecs participated in locating the paths
@@@ -443,11 -441,6 +443,11 @@@ struct branch_info 
        const char *name; /* The short name used */
        const char *path; /* The full name of a real branch */
        struct commit *commit; /* The named commit */
 +      /*
 +       * if not null the branch is detached because it's already
 +       * checked out in this checkout
 +       */
 +      char *checkout;
  };
  
  static void setup_branch_path(struct branch_info *branch)
@@@ -509,7 -502,7 +509,7 @@@ static int merge_working_tree(const str
                        topts.dir->flags |= DIR_SHOW_IGNORED;
                        setup_standard_excludes(topts.dir);
                }
 -              tree = parse_tree_indirect(old->commit ?
 +              tree = parse_tree_indirect(old->commit && !opts->new_worktree_mode ?
                                           old->commit->object.sha1 :
                                           EMPTY_TREE_SHA1_BIN);
                init_tree_desc(&trees[0], tree->buffer, tree->size);
@@@ -613,21 -606,18 +613,21 @@@ static void update_refs_for_switch(cons
                if (opts->new_orphan_branch) {
                        if (opts->new_branch_log && !log_all_ref_updates) {
                                int temp;
 -                              char log_file[PATH_MAX];
 -                              char *ref_name = mkpath("refs/heads/%s", opts->new_orphan_branch);
 +                              struct strbuf log_file = STRBUF_INIT;
 +                              int ret;
 +                              const char *ref_name;
  
 +                              ref_name = mkpath("refs/heads/%s", opts->new_orphan_branch);
                                temp = log_all_ref_updates;
                                log_all_ref_updates = 1;
 -                              if (log_ref_setup(ref_name, log_file, sizeof(log_file))) {
 +                              ret = log_ref_setup(ref_name, &log_file);
 +                              log_all_ref_updates = temp;
 +                              strbuf_release(&log_file);
 +                              if (ret) {
                                        fprintf(stderr, _("Can not do reflog for '%s'\n"),
                                            opts->new_orphan_branch);
 -                                      log_all_ref_updates = temp;
                                        return;
                                }
 -                              log_all_ref_updates = temp;
                        }
                }
                else
  }
  
  static int add_pending_uninteresting_ref(const char *refname,
 -                                       const unsigned char *sha1,
 +                                       const struct object_id *oid,
                                         int flags, void *cb_data)
  {
 -      add_pending_sha1(cb_data, refname, sha1, UNINTERESTING);
 +      add_pending_sha1(cb_data, refname, oid->hash, UNINTERESTING);
        return 0;
  }
  
@@@ -753,17 -743,10 +753,17 @@@ static void suggest_reattach(struct com
  
        if (advice_detached_head)
                fprintf(stderr,
 -                      _(
 +                      Q_(
 +                      /* The singular version */
 +                      "If you want to keep it by creating a new branch, "
 +                      "this may be a good time\nto do so with:\n\n"
 +                      " git branch <new-branch-name> %s\n\n",
 +                      /* The plural version */
                        "If you want to keep them by creating a new branch, "
                        "this may be a good time\nto do so with:\n\n"
 -                      " git branch <new-branch-name> %s\n\n"),
 +                      " git branch <new-branch-name> %s\n\n",
 +                      /* Give ngettext() the count */
 +                      lost),
                        find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV));
  }
  
@@@ -832,8 -815,7 +832,8 @@@ static int switch_branches(const struc
                return ret;
        }
  
 -      if (!opts->quiet && !old.path && old.commit && new->commit != old.commit)
 +      if (!opts->quiet && !old.path && old.commit &&
 +          new->commit != old.commit && !opts->new_worktree_mode)
                orphaned_commit_warning(old.commit, new->commit);
  
        update_refs_for_switch(opts, &old, new);
@@@ -898,79 -880,13 +898,79 @@@ static const char *unique_tracking_name
        return NULL;
  }
  
 +static void check_linked_checkout(struct branch_info *new, const char *id)
 +{
 +      struct strbuf sb = STRBUF_INIT;
 +      struct strbuf path = STRBUF_INIT;
 +      struct strbuf gitdir = STRBUF_INIT;
 +      const char *start, *end;
 +
 +      if (id)
 +              strbuf_addf(&path, "%s/worktrees/%s/HEAD", get_git_common_dir(), id);
 +      else
 +              strbuf_addf(&path, "%s/HEAD", get_git_common_dir());
 +
 +      if (strbuf_read_file(&sb, path.buf, 0) < 0 ||
 +          !skip_prefix(sb.buf, "ref:", &start))
 +              goto done;
 +      while (isspace(*start))
 +              start++;
 +      end = start;
 +      while (*end && !isspace(*end))
 +              end++;
 +      if (strncmp(start, new->path, end - start) || new->path[end - start] != '\0')
 +              goto done;
 +      if (id) {
 +              strbuf_reset(&path);
 +              strbuf_addf(&path, "%s/worktrees/%s/gitdir", get_git_common_dir(), id);
 +              if (strbuf_read_file(&gitdir, path.buf, 0) <= 0)
 +                      goto done;
 +              strbuf_rtrim(&gitdir);
 +      } else
 +              strbuf_addstr(&gitdir, get_git_common_dir());
 +      die(_("'%s' is already checked out at '%s'"), new->name, gitdir.buf);
 +done:
 +      strbuf_release(&path);
 +      strbuf_release(&sb);
 +      strbuf_release(&gitdir);
 +}
 +
 +static void check_linked_checkouts(struct branch_info *new)
 +{
 +      struct strbuf path = STRBUF_INIT;
 +      DIR *dir;
 +      struct dirent *d;
 +
 +      strbuf_addf(&path, "%s/worktrees", get_git_common_dir());
 +      if ((dir = opendir(path.buf)) == NULL) {
 +              strbuf_release(&path);
 +              return;
 +      }
 +
 +      /*
 +       * $GIT_COMMON_DIR/HEAD is practically outside
 +       * $GIT_DIR so resolve_ref_unsafe() won't work (it
 +       * uses git_path). Parse the ref ourselves.
 +       */
 +      check_linked_checkout(new, NULL);
 +
 +      while ((d = readdir(dir)) != NULL) {
 +              if (!strcmp(d->d_name, ".") || !strcmp(d->d_name, ".."))
 +                      continue;
 +              check_linked_checkout(new, d->d_name);
 +      }
 +      strbuf_release(&path);
 +      closedir(dir);
 +}
 +
  static int parse_branchname_arg(int argc, const char **argv,
                                int dwim_new_local_branch_ok,
                                struct branch_info *new,
 -                              struct tree **source_tree,
 -                              unsigned char rev[20],
 -                              const char **new_branch)
 +                              struct checkout_opts *opts,
 +                              unsigned char rev[20])
  {
 +      struct tree **source_tree = &opts->source_tree;
 +      const char **new_branch = &opts->new_branch;
        int argcount = 0;
        unsigned char branch_rev[20];
        const char *arg;
@@@ -1170,17 -1086,6 +1170,17 @@@ static int checkout_branch(struct check
                die(_("Cannot switch branch to a non-commit '%s'"),
                    new->name);
  
 +      if (new->path && !opts->force_detach && !opts->new_branch) {
 +              unsigned char sha1[20];
 +              int flag;
 +              char *head_ref = resolve_refdup("HEAD", 0, sha1, &flag);
 +              if (head_ref &&
 +                  (!(flag & REF_ISSYMREF) || strcmp(head_ref, new->path)) &&
 +                  !opts->ignore_other_worktrees)
 +                      check_linked_checkouts(new);
 +              free(head_ref);
 +      }
 +
        if (!new->commit && opts->new_branch) {
                unsigned char rev[20];
                int flag;
@@@ -1223,8 -1128,6 +1223,8 @@@ int cmd_checkout(int argc, const char *
                         N_("do not limit pathspecs to sparse entries only")),
                OPT_HIDDEN_BOOL(0, "guess", &dwim_new_local_branch,
                                N_("second guess 'git checkout <no-such-branch>'")),
 +              OPT_BOOL(0, "ignore-other-worktrees", &opts.ignore_other_worktrees,
 +                       N_("do not check if another worktree is holding the given ref")),
                OPT_END(),
        };
  
        argc = parse_options(argc, argv, prefix, options, checkout_usage,
                             PARSE_OPT_KEEP_DASHDASH);
  
 +      opts.new_worktree_mode = getenv("GIT_CHECKOUT_NEW_WORKTREE") != NULL;
 +
        if (conflict_style) {
                opts.merge = 1; /* implied */
                git_xmerge_config("merge.conflictstyle", conflict_style, NULL);
                        opts.track == BRANCH_TRACK_UNSPECIFIED &&
                        !opts.new_branch;
                int n = parse_branchname_arg(argc, argv, dwim_ok,
 -                                           &new, &opts.source_tree,
 -                                           rev, &opts.new_branch);
 +                                           &new, &opts, rev);
                argv += n;
                argc -= n;
        }