Merge branch 'ab/pcre-v2'
authorJunio C Hamano <gitster@pobox.com>
Mon, 19 Jun 2017 19:38:43 +0000 (12:38 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 19 Jun 2017 19:38:43 +0000 (12:38 -0700)
Update "perl-compatible regular expression" support to enable JIT
and also allow linking with the newer PCRE v2 library.

* ab/pcre-v2:
grep: add support for PCRE v2
grep: un-break building with PCRE >= 8.32 without --enable-jit
grep: un-break building with PCRE < 8.20
grep: un-break building with PCRE < 8.32
grep: add support for the PCRE v1 JIT API
log: add -P as a synonym for --perl-regexp
grep: skip pthreads overhead when using one thread
grep: don't redundantly compile throwaway patterns under threading

1  2 
Makefile
builtin/grep.c
config.mak.uname
revision.c
t/t4202-log.sh
t/test-lib.sh
diff --combined Makefile
index 7c621f7f76181eb3d255e8d6eaf28e6e63dbb92f,96ebbed87efa3a18be22247c2e188af72a406a72..f4848016380058ffdfc01966bc587ca7306415d9
+++ b/Makefile
@@@ -29,8 -29,23 +29,23 @@@ all:
  # Perl-compatible regular expressions instead of standard or extended
  # POSIX regular expressions.
  #
- # Define LIBPCREDIR=/foo/bar if your libpcre header and library files are in
- # /foo/bar/include and /foo/bar/lib directories.
+ # Currently USE_LIBPCRE is a synonym for USE_LIBPCRE1, define
+ # USE_LIBPCRE2 instead if you'd like to use version 2 of the PCRE
+ # library. The USE_LIBPCRE flag will likely be changed to mean v2 by
+ # default in future releases.
+ #
+ # When using USE_LIBPCRE1, define NO_LIBPCRE1_JIT if the PCRE v1
+ # library is compiled without --enable-jit. We will auto-detect
+ # whether the version of the PCRE v1 library in use has JIT support at
+ # all, but we unfortunately can't auto-detect whether JIT support
+ # hasn't been compiled in in an otherwise JIT-supporting version. If
+ # you have link-time errors about a missing `pcre_jit_exec` define
+ # this, or recompile PCRE v1 with --enable-jit.
+ #
+ # Define LIBPCREDIR=/foo/bar if your PCRE header and library files are
+ # in /foo/bar/include and /foo/bar/lib directories. Which version of
+ # PCRE this points to determined by the USE_LIBPCRE1 and USE_LIBPCRE2
+ # variables.
  #
  # Define HAVE_ALLOCA_H if you have working alloca(3) defined in that header.
  #
@@@ -720,7 -735,6 +735,7 @@@ LIB_OBJS += argv-array.
  LIB_OBJS += attr.o
  LIB_OBJS += base85.o
  LIB_OBJS += bisect.o
 +LIB_OBJS += blame.o
  LIB_OBJS += blob.o
  LIB_OBJS += branch.o
  LIB_OBJS += bulk-checkin.o
@@@ -845,7 -859,6 +860,7 @@@ LIB_OBJS += streaming.
  LIB_OBJS += string-list.o
  LIB_OBJS += submodule.o
  LIB_OBJS += submodule-config.o
 +LIB_OBJS += sub-process.o
  LIB_OBJS += symlinks.o
  LIB_OBJS += tag.o
  LIB_OBJS += tempfile.o
@@@ -1089,13 -1102,29 +1104,29 @@@ ifdef NO_LIBGEN_
        COMPAT_OBJS += compat/basename.o
  endif
  
- ifdef USE_LIBPCRE
-       BASIC_CFLAGS += -DUSE_LIBPCRE1
-       ifdef LIBPCREDIR
-               BASIC_CFLAGS += -I$(LIBPCREDIR)/include
              EXTLIBS += -L$(LIBPCREDIR)/$(lib) $(CC_LD_DYNPATH)$(LIBPCREDIR)/$(lib)
+ USE_LIBPCRE1 ?= $(USE_LIBPCRE)
+ ifneq (,$(USE_LIBPCRE1))
+       ifdef USE_LIBPCRE2
$(error Only set USE_LIBPCRE1 (or its alias USE_LIBPCRE) or USE_LIBPCRE2, not both!)
        endif
+       BASIC_CFLAGS += -DUSE_LIBPCRE1
        EXTLIBS += -lpcre
+ ifdef NO_LIBPCRE1_JIT
+       BASIC_CFLAGS += -DNO_LIBPCRE1_JIT
+ endif
+ endif
+ ifdef USE_LIBPCRE2
+       BASIC_CFLAGS += -DUSE_LIBPCRE2
+       EXTLIBS += -lpcre2-8
+ endif
+ ifdef LIBPCREDIR
+       BASIC_CFLAGS += -I$(LIBPCREDIR)/include
+       EXTLIBS += -L$(LIBPCREDIR)/$(lib) $(CC_LD_DYNPATH)$(LIBPCREDIR)/$(lib)
  endif
  
  ifdef HAVE_ALLOCA_H
        DC_SHA1 := YesPlease
        LIB_OBJS += sha1dc/sha1.o
        LIB_OBJS += sha1dc/ubc_check.o
 -      BASIC_CFLAGS += -DSHA1_DC
 +      BASIC_CFLAGS += \
 +              -DSHA1_DC \
 +              -DSHA1DC_NO_STANDARD_INCLUDES \
 +              -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 \
 +              -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" \
 +              -DSHA1DC_CUSTOM_TRAILING_INCLUDE_SHA1_C="\"sha1dc_git.c\"" \
 +              -DSHA1DC_CUSTOM_TRAILING_INCLUDE_SHA1_H="\"sha1dc_git.h\"" \
 +              -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\""
  endif
  endif
  endif
@@@ -2249,7 -2271,9 +2280,9 @@@ GIT-BUILD-OPTIONS: FORC
        @echo TAR=\''$(subst ','\'',$(subst ','\'',$(TAR)))'\' >>$@+
        @echo NO_CURL=\''$(subst ','\'',$(subst ','\'',$(NO_CURL)))'\' >>$@+
        @echo NO_EXPAT=\''$(subst ','\'',$(subst ','\'',$(NO_EXPAT)))'\' >>$@+
-       @echo USE_LIBPCRE1=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE)))'\' >>$@+
+       @echo USE_LIBPCRE1=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE1)))'\' >>$@+
+       @echo USE_LIBPCRE2=\''$(subst ','\'',$(subst ','\'',$(USE_LIBPCRE2)))'\' >>$@+
+       @echo NO_LIBPCRE1_JIT=\''$(subst ','\'',$(subst ','\'',$(NO_LIBPCRE1_JIT)))'\' >>$@+
        @echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@+
        @echo NO_PTHREADS=\''$(subst ','\'',$(subst ','\'',$(NO_PTHREADS)))'\' >>$@+
        @echo NO_PYTHON=\''$(subst ','\'',$(subst ','\'',$(NO_PYTHON)))'\' >>$@+
diff --combined builtin/grep.c
index d188871556d814b1532f7118f1d76741850a370d,bd008cb100641f44925279000c030dc70ba3f340..26d43b4e4cdf56d621e9618a60c6b72dfe868b09
@@@ -224,7 -224,8 +224,8 @@@ static void start_threads(struct grep_o
                int err;
                struct grep_opt *o = grep_opt_dup(opt);
                o->output = strbuf_out;
-               o->debug = 0;
+               if (i)
+                       o->debug = 0;
                compile_grep_patterns(o);
                err = pthread_create(&threads[i], NULL, run, o);
  
@@@ -302,9 -303,6 +303,9 @@@ static int grep_cmd_config(const char *
  #endif
        }
  
 +      if (!strcmp(var, "submodule.recurse"))
 +              recurse_submodules = git_config_bool(var, value);
 +
        return st;
  }
  
@@@ -882,7 -880,7 +883,7 @@@ static int grep_directory(struct grep_o
        if (exc_std)
                setup_standard_excludes(&dir);
  
 -      fill_directory(&dir, pathspec);
 +      fill_directory(&dir, &the_index, pathspec);
        for (i = 0; i < dir.nr; i++) {
                if (!dir_path_match(dir.entries[i], pathspec, 0, NULL))
                        continue;
@@@ -1170,8 -1168,6 +1171,6 @@@ int cmd_grep(int argc, const char **arg
        if (!opt.fixed && opt.ignore_case)
                opt.regflags |= REG_ICASE;
  
-       compile_grep_patterns(&opt);
        /*
         * We have to find "--" in a separate pass, because its presence
         * influences how we will parse arguments that come before it.
                        break;
                }
  
 -              if (get_sha1_with_context(arg, 0, oid.hash, &oc)) {
 +              if (get_sha1_with_context(arg, GET_SHA1_RECORD_PATH,
 +                                        oid.hash, &oc)) {
                        if (seen_dashdash)
                                die(_("unable to resolve revision: %s"), arg);
                        break;
                }
  
 -              object = parse_object_or_die(oid.hash, arg);
 +              object = parse_object_or_die(&oid, arg);
                if (!seen_dashdash)
                        verify_non_filename(prefix, arg);
                add_object_array_with_path(object, arg, &list, oc.mode, oc.path);
 +              free(oc.path);
        }
  
        /*
                num_threads = GREP_NUM_THREADS_DEFAULT;
        else if (num_threads < 0)
                die(_("invalid number of threads specified (%d)"), num_threads);
+       if (num_threads == 1)
+               num_threads = 0;
  #else
        if (num_threads)
                warning(_("no threads support, ignoring --threads"));
        num_threads = 0;
  #endif
  
+       if (!num_threads)
+               /*
+                * The compiled patterns on the main path are only
+                * used when not using threading. Otherwise
+                * start_threads() below calls compile_grep_patterns()
+                * for each thread.
+                */
+               compile_grep_patterns(&opt);
  #ifndef NO_PTHREADS
        if (num_threads) {
                if (!(opt.name_only || opt.unmatch_name_only || opt.count)
diff --combined config.mak.uname
index d2cabe7fb485c04557c8327efbca5f365c631e99,2a577794ba55f2c2a585f82ae241db9b97ff668c..adfb90b6018a87a6fb3455635590aec374fd170b
@@@ -36,7 -36,6 +36,7 @@@ ifeq ($(uname_S),Linux
        NEEDS_LIBRT = YesPlease
        HAVE_GETDELIM = YesPlease
        SANE_TEXT_GREP=-a
 +      FREAD_READS_DIRECTORIES = UnfortunatelyYes
  endif
  ifeq ($(uname_S),GNU/kFreeBSD)
        HAVE_ALLOCA_H = YesPlease
@@@ -44,7 -43,6 +44,7 @@@
        HAVE_PATHS_H = YesPlease
        DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
        LIBC_CONTAINS_LIBINTL = YesPlease
 +      FREAD_READS_DIRECTORIES = UnfortunatelyYes
  endif
  ifeq ($(uname_S),UnixWare)
        CC = cc
@@@ -110,7 -108,6 +110,7 @@@ ifeq ($(uname_S),Darwin
        BASIC_CFLAGS += -DPRECOMPOSE_UNICODE
        BASIC_CFLAGS += -DPROTECT_HFS_DEFAULT=1
        HAVE_BSD_SYSCTL = YesPlease
 +      FREAD_READS_DIRECTORIES = UnfortunatelyYes
  endif
  ifeq ($(uname_S),SunOS)
        NEEDS_SOCKET = YesPlease
@@@ -204,7 -201,6 +204,7 @@@ ifeq ($(uname_S),FreeBSD
        GMTIME_UNRELIABLE_ERRORS = UnfortunatelyYes
        HAVE_BSD_SYSCTL = YesPlease
        PAGER_ENV = LESS=FRX LV=-c MORE=FRX
 +      FREAD_READS_DIRECTORIES = UnfortunatelyYes
  endif
  ifeq ($(uname_S),OpenBSD)
        NO_STRCASESTR = YesPlease
@@@ -241,7 -237,6 +241,7 @@@ ifeq ($(uname_S),AIX
        NO_MKDTEMP = YesPlease
        NO_STRLCPY = YesPlease
        NO_NSEC = YesPlease
 +      NO_REGEX = NeedsStartEnd
        FREAD_READS_DIRECTORIES = UnfortunatelyYes
        INTERNAL_QSORT = UnfortunatelyYes
        NEEDS_LIBICONV = YesPlease
@@@ -555,6 -550,7 +555,7 @@@ els
                NO_GETTEXT =
                USE_GETTEXT_SCHEME = fallthrough
                USE_LIBPCRE= YesPlease
+               NO_LIBPCRE1_JIT = UnfortunatelyYes
                NO_CURL =
                USE_NED_ALLOCATOR = YesPlease
        else
diff --combined revision.c
index f88c14bab3188c65631593640289b26d00a6a3fc,dea4d841b5024a10f2a485de065f3621bdb3185b..3b09cd6ee9fcc56883ab2991fd584f4fc763df27
@@@ -59,10 -59,10 +59,10 @@@ static void mark_tree_contents_unintere
        while (tree_entry(&desc, &entry)) {
                switch (object_type(entry.mode)) {
                case OBJ_TREE:
 -                      mark_tree_uninteresting(lookup_tree(entry.oid->hash));
 +                      mark_tree_uninteresting(lookup_tree(entry.oid));
                        break;
                case OBJ_BLOB:
 -                      mark_blob_uninteresting(lookup_blob(entry.oid->hash));
 +                      mark_blob_uninteresting(lookup_blob(entry.oid));
                        break;
                default:
                        /* Subproject commit - not in this repository */
@@@ -177,23 -177,23 +177,23 @@@ void add_pending_object(struct rev_inf
  
  void add_head_to_pending(struct rev_info *revs)
  {
 -      unsigned char sha1[20];
 +      struct object_id oid;
        struct object *obj;
 -      if (get_sha1("HEAD", sha1))
 +      if (get_oid("HEAD", &oid))
                return;
 -      obj = parse_object(sha1);
 +      obj = parse_object(&oid);
        if (!obj)
                return;
        add_pending_object(revs, obj, "HEAD");
  }
  
  static struct object *get_reference(struct rev_info *revs, const char *name,
 -                                  const unsigned char *sha1,
 +                                  const struct object_id *oid,
                                    unsigned int flags)
  {
        struct object *object;
  
 -      object = parse_object(sha1);
 +      object = parse_object(oid);
        if (!object) {
                if (revs->ignore_missing)
                        return object;
        return object;
  }
  
 -void add_pending_sha1(struct rev_info *revs, const char *name,
 -                    const unsigned char *sha1, unsigned int flags)
 +void add_pending_oid(struct rev_info *revs, const char *name,
 +                    const struct object_id *oid, unsigned int flags)
  {
 -      struct object *object = get_reference(revs, name, sha1, flags);
 +      struct object *object = get_reference(revs, name, oid, flags);
        add_pending_object(revs, object, name);
  }
  
@@@ -228,9 -228,9 +228,9 @@@ static struct commit *handle_commit(str
                        add_pending_object(revs, object, tag->tag);
                if (!tag->tagged)
                        die("bad tag");
 -              object = parse_object(tag->tagged->oid.hash);
 +              object = parse_object(&tag->tagged->oid);
                if (!object) {
 -                      if (flags & UNINTERESTING)
 +                      if (revs->ignore_missing_links || (flags & UNINTERESTING))
                                return NULL;
                        die("bad object %s", oid_to_hex(&tag->tagged->oid));
                }
@@@ -884,7 -884,7 +884,7 @@@ static void cherry_pick_list(struct com
  /* How many extra uninteresting commits we want to see.. */
  #define SLOP 5
  
 -static int still_interesting(struct commit_list *src, unsigned long date, int slop,
 +static int still_interesting(struct commit_list *src, timestamp_t date, int slop,
                             struct commit **interesting_cache)
  {
        /*
@@@ -1018,7 -1018,7 +1018,7 @@@ static void limit_left_right(struct com
  static int limit_list(struct rev_info *revs)
  {
        int slop = SLOP;
 -      unsigned long date = ~0ul;
 +      timestamp_t date = TIME_MAX;
        struct commit_list *list = revs->commits;
        struct commit_list *newlist = NULL;
        struct commit_list **p = &newlist;
@@@ -1157,9 -1157,9 +1157,9 @@@ static int handle_one_ref(const char *p
        if (ref_excluded(cb->all_revs->ref_excludes, path))
            return 0;
  
 -      object = get_reference(cb->all_revs, path, oid->hash, cb->all_flags);
 +      object = get_reference(cb->all_revs, path, oid, cb->all_flags);
        add_rev_cmdline(cb->all_revs, object, path, REV_CMD_REF, cb->all_flags);
 -      add_pending_sha1(cb->all_revs, path, oid->hash, cb->all_flags);
 +      add_pending_oid(cb->all_revs, path, oid, cb->all_flags);
        return 0;
  }
  
@@@ -1200,7 -1200,7 +1200,7 @@@ static void handle_one_reflog_commit(st
  {
        struct all_refs_cb *cb = cb_data;
        if (!is_null_oid(oid)) {
 -              struct object *o = parse_object(oid->hash);
 +              struct object *o = parse_object(oid);
                if (o) {
                        o->flags |= cb->all_flags;
                        /* ??? CMDLINEFLAGS ??? */
  }
  
  static int handle_one_reflog_ent(struct object_id *ooid, struct object_id *noid,
 -              const char *email, unsigned long timestamp, int tz,
 +              const char *email, timestamp_t timestamp, int tz,
                const char *message, void *cb_data)
  {
        handle_one_reflog_commit(ooid, cb_data);
@@@ -1249,7 -1249,7 +1249,7 @@@ static void add_cache_tree(struct cache
        int i;
  
        if (it->entry_count >= 0) {
 -              struct tree *tree = lookup_tree(it->sha1);
 +              struct tree *tree = lookup_tree(&it->oid);
                add_pending_object_with_path(revs, &tree->object, "",
                                             040000, path->buf);
        }
@@@ -1275,7 -1275,7 +1275,7 @@@ void add_index_objects_to_pending(struc
                if (S_ISGITLINK(ce->ce_mode))
                        continue;
  
 -              blob = lookup_blob(ce->oid.hash);
 +              blob = lookup_blob(&ce->oid);
                if (!blob)
                        die("unable to add index blob to traversal");
                add_pending_object_with_path(revs, &blob->object, "",
  static int add_parents_only(struct rev_info *revs, const char *arg_, int flags,
                            int exclude_parent)
  {
 -      unsigned char sha1[20];
 +      struct object_id oid;
        struct object *it;
        struct commit *commit;
        struct commit_list *parents;
                flags ^= UNINTERESTING | BOTTOM;
                arg++;
        }
 -      if (get_sha1_committish(arg, sha1))
 +      if (get_sha1_committish(arg, oid.hash))
                return 0;
        while (1) {
 -              it = get_reference(revs, arg, sha1, 0);
 +              it = get_reference(revs, arg, &oid, 0);
                if (!it && revs->ignore_missing)
                        return 0;
                if (it->type != OBJ_TAG)
                        break;
                if (!((struct tag*)it)->tagged)
                        return 0;
 -              hashcpy(sha1, ((struct tag*)it)->tagged->oid.hash);
 +              oidcpy(&oid, &((struct tag*)it)->tagged->oid);
        }
        if (it->type != OBJ_COMMIT)
                return 0;
@@@ -1389,16 -1389,16 +1389,16 @@@ static void prepare_show_merge(struct r
  {
        struct commit_list *bases;
        struct commit *head, *other;
 -      unsigned char sha1[20];
 +      struct object_id oid;
        const char **prune = NULL;
        int i, prune_num = 1; /* counting terminating NULL */
  
 -      if (get_sha1("HEAD", sha1))
 +      if (get_oid("HEAD", &oid))
                die("--merge without HEAD?");
 -      head = lookup_commit_or_die(sha1, "HEAD");
 -      if (get_sha1("MERGE_HEAD", sha1))
 +      head = lookup_commit_or_die(&oid, "HEAD");
 +      if (get_oid("MERGE_HEAD", &oid))
                die("--merge without MERGE_HEAD?");
 -      other = lookup_commit_or_die(sha1, "MERGE_HEAD");
 +      other = lookup_commit_or_die(&oid, "MERGE_HEAD");
        add_pending_object(revs, &head->object, "HEAD");
        add_pending_object(revs, &other->object, "MERGE_HEAD");
        bases = get_merge_bases(head, other);
        revs->limited = 1;
  }
  
 +static int dotdot_missing(const char *arg, char *dotdot,
 +                        struct rev_info *revs, int symmetric)
 +{
 +      if (revs->ignore_missing)
 +              return 0;
 +      /* de-munge so we report the full argument */
 +      *dotdot = '.';
 +      die(symmetric
 +          ? "Invalid symmetric difference expression %s"
 +          : "Invalid revision range %s", arg);
 +}
 +
 +static int handle_dotdot_1(const char *arg, char *dotdot,
 +                         struct rev_info *revs, int flags,
 +                         int cant_be_filename,
 +                         struct object_context *a_oc,
 +                         struct object_context *b_oc)
 +{
 +      const char *a_name, *b_name;
 +      struct object_id a_oid, b_oid;
 +      struct object *a_obj, *b_obj;
 +      unsigned int a_flags, b_flags;
 +      int symmetric = 0;
 +      unsigned int flags_exclude = flags ^ (UNINTERESTING | BOTTOM);
 +      unsigned int oc_flags = GET_SHA1_COMMITTISH | GET_SHA1_RECORD_PATH;
 +
 +      a_name = arg;
 +      if (!*a_name)
 +              a_name = "HEAD";
 +
 +      b_name = dotdot + 2;
 +      if (*b_name == '.') {
 +              symmetric = 1;
 +              b_name++;
 +      }
 +      if (!*b_name)
 +              b_name = "HEAD";
 +
 +      if (get_sha1_with_context(a_name, oc_flags, a_oid.hash, a_oc) ||
 +          get_sha1_with_context(b_name, oc_flags, b_oid.hash, b_oc))
 +              return -1;
 +
 +      if (!cant_be_filename) {
 +              *dotdot = '.';
 +              verify_non_filename(revs->prefix, arg);
 +              *dotdot = '\0';
 +      }
 +
 +      a_obj = parse_object(&a_oid);
 +      b_obj = parse_object(&b_oid);
 +      if (!a_obj || !b_obj)
 +              return dotdot_missing(arg, dotdot, revs, symmetric);
 +
 +      if (!symmetric) {
 +              /* just A..B */
 +              b_flags = flags;
 +              a_flags = flags_exclude;
 +      } else {
 +              /* A...B -- find merge bases between the two */
 +              struct commit *a, *b;
 +              struct commit_list *exclude;
 +
 +              a = lookup_commit_reference(&a_obj->oid);
 +              b = lookup_commit_reference(&b_obj->oid);
 +              if (!a || !b)
 +                      return dotdot_missing(arg, dotdot, revs, symmetric);
 +
 +              exclude = get_merge_bases(a, b);
 +              add_rev_cmdline_list(revs, exclude, REV_CMD_MERGE_BASE,
 +                                   flags_exclude);
 +              add_pending_commit_list(revs, exclude, flags_exclude);
 +              free_commit_list(exclude);
 +
 +              b_flags = flags;
 +              a_flags = flags | SYMMETRIC_LEFT;
 +      }
 +
 +      a_obj->flags |= a_flags;
 +      b_obj->flags |= b_flags;
 +      add_rev_cmdline(revs, a_obj, a_name, REV_CMD_LEFT, a_flags);
 +      add_rev_cmdline(revs, b_obj, b_name, REV_CMD_RIGHT, b_flags);
 +      add_pending_object_with_path(revs, a_obj, a_name, a_oc->mode, a_oc->path);
 +      add_pending_object_with_path(revs, b_obj, b_name, b_oc->mode, b_oc->path);
 +      return 0;
 +}
 +
 +static int handle_dotdot(const char *arg,
 +                       struct rev_info *revs, int flags,
 +                       int cant_be_filename)
 +{
 +      struct object_context a_oc, b_oc;
 +      char *dotdot = strstr(arg, "..");
 +      int ret;
 +
 +      if (!dotdot)
 +              return -1;
 +
 +      memset(&a_oc, 0, sizeof(a_oc));
 +      memset(&b_oc, 0, sizeof(b_oc));
 +
 +      *dotdot = '\0';
 +      ret = handle_dotdot_1(arg, dotdot, revs, flags, cant_be_filename,
 +                            &a_oc, &b_oc);
 +      *dotdot = '.';
 +
 +      free(a_oc.path);
 +      free(b_oc.path);
 +
 +      return ret;
 +}
 +
  int handle_revision_arg(const char *arg_, struct rev_info *revs, int flags, unsigned revarg_opt)
  {
        struct object_context oc;
 -      char *dotdot;
 +      char *mark;
        struct object *object;
 -      unsigned char sha1[20];
 +      struct object_id oid;
        int local_flags;
        const char *arg = arg_;
        int cant_be_filename = revarg_opt & REVARG_CANNOT_BE_FILENAME;
 -      unsigned get_sha1_flags = 0;
 +      unsigned get_sha1_flags = GET_SHA1_RECORD_PATH;
  
        flags = flags & UNINTERESTING ? flags | BOTTOM : flags & ~BOTTOM;
  
 -      dotdot = strstr(arg, "..");
 -      if (dotdot) {
 -              unsigned char from_sha1[20];
 -              const char *next = dotdot + 2;
 -              const char *this = arg;
 -              int symmetric = *next == '.';
 -              unsigned int flags_exclude = flags ^ (UNINTERESTING | BOTTOM);
 -              static const char head_by_default[] = "HEAD";
 -              unsigned int a_flags;
 -
 -              *dotdot = 0;
 -              next += symmetric;
 -
 -              if (!*next)
 -                      next = head_by_default;
 -              if (dotdot == arg)
 -                      this = head_by_default;
 -              if (this == head_by_default && next == head_by_default &&
 -                  !symmetric) {
 -                      /*
 -                       * Just ".."?  That is not a range but the
 -                       * pathspec for the parent directory.
 -                       */
 -                      if (!cant_be_filename) {
 -                              *dotdot = '.';
 -                              return -1;
 -                      }
 -              }
 -              if (!get_sha1_committish(this, from_sha1) &&
 -                  !get_sha1_committish(next, sha1)) {
 -                      struct object *a_obj, *b_obj;
 -
 -                      if (!cant_be_filename) {
 -                              *dotdot = '.';
 -                              verify_non_filename(revs->prefix, arg);
 -                      }
 -
 -                      a_obj = parse_object(from_sha1);
 -                      b_obj = parse_object(sha1);
 -                      if (!a_obj || !b_obj) {
 -                      missing:
 -                              if (revs->ignore_missing)
 -                                      return 0;
 -                              die(symmetric
 -                                  ? "Invalid symmetric difference expression %s"
 -                                  : "Invalid revision range %s", arg);
 -                      }
 -
 -                      if (!symmetric) {
 -                              /* just A..B */
 -                              a_flags = flags_exclude;
 -                      } else {
 -                              /* A...B -- find merge bases between the two */
 -                              struct commit *a, *b;
 -                              struct commit_list *exclude;
 -
 -                              a = (a_obj->type == OBJ_COMMIT
 -                                   ? (struct commit *)a_obj
 -                                   : lookup_commit_reference(a_obj->oid.hash));
 -                              b = (b_obj->type == OBJ_COMMIT
 -                                   ? (struct commit *)b_obj
 -                                   : lookup_commit_reference(b_obj->oid.hash));
 -                              if (!a || !b)
 -                                      goto missing;
 -                              exclude = get_merge_bases(a, b);
 -                              add_rev_cmdline_list(revs, exclude,
 -                                                   REV_CMD_MERGE_BASE,
 -                                                   flags_exclude);
 -                              add_pending_commit_list(revs, exclude,
 -                                                      flags_exclude);
 -                              free_commit_list(exclude);
 -
 -                              a_flags = flags | SYMMETRIC_LEFT;
 -                      }
 -
 -                      a_obj->flags |= a_flags;
 -                      b_obj->flags |= flags;
 -                      add_rev_cmdline(revs, a_obj, this,
 -                                      REV_CMD_LEFT, a_flags);
 -                      add_rev_cmdline(revs, b_obj, next,
 -                                      REV_CMD_RIGHT, flags);
 -                      add_pending_object(revs, a_obj, this);
 -                      add_pending_object(revs, b_obj, next);
 -                      return 0;
 -              }
 -              *dotdot = '.';
 +      if (!cant_be_filename && !strcmp(arg, "..")) {
 +              /*
 +               * Just ".."?  That is not a range but the
 +               * pathspec for the parent directory.
 +               */
 +              return -1;
        }
  
 -      dotdot = strstr(arg, "^@");
 -      if (dotdot && !dotdot[2]) {
 -              *dotdot = 0;
 +      if (!handle_dotdot(arg, revs, flags, revarg_opt))
 +              return 0;
 +
 +      mark = strstr(arg, "^@");
 +      if (mark && !mark[2]) {
 +              *mark = 0;
                if (add_parents_only(revs, arg, flags, 0))
                        return 0;
 -              *dotdot = '^';
 +              *mark = '^';
        }
 -      dotdot = strstr(arg, "^!");
 -      if (dotdot && !dotdot[2]) {
 -              *dotdot = 0;
 +      mark = strstr(arg, "^!");
 +      if (mark && !mark[2]) {
 +              *mark = 0;
                if (!add_parents_only(revs, arg, flags ^ (UNINTERESTING | BOTTOM), 0))
 -                      *dotdot = '^';
 +                      *mark = '^';
        }
 -      dotdot = strstr(arg, "^-");
 -      if (dotdot) {
 +      mark = strstr(arg, "^-");
 +      if (mark) {
                int exclude_parent = 1;
  
 -              if (dotdot[2]) {
 +              if (mark[2]) {
                        char *end;
 -                      exclude_parent = strtoul(dotdot + 2, &end, 10);
 +                      exclude_parent = strtoul(mark + 2, &end, 10);
                        if (*end != '\0' || !exclude_parent)
                                return -1;
                }
  
 -              *dotdot = 0;
 +              *mark = 0;
                if (!add_parents_only(revs, arg, flags ^ (UNINTERESTING | BOTTOM), exclude_parent))
 -                      *dotdot = '^';
 +                      *mark = '^';
        }
  
        local_flags = 0;
        }
  
        if (revarg_opt & REVARG_COMMITTISH)
 -              get_sha1_flags = GET_SHA1_COMMITTISH;
 +              get_sha1_flags |= GET_SHA1_COMMITTISH;
  
 -      if (get_sha1_with_context(arg, get_sha1_flags, sha1, &oc))
 +      if (get_sha1_with_context(arg, get_sha1_flags, oid.hash, &oc))
                return revs->ignore_missing ? 0 : -1;
        if (!cant_be_filename)
                verify_non_filename(revs->prefix, arg);
 -      object = get_reference(revs, arg, sha1, flags ^ local_flags);
 +      object = get_reference(revs, arg, &oid, flags ^ local_flags);
        add_rev_cmdline(revs, object, arg_, REV_CMD_REV, flags ^ local_flags);
 -      add_pending_object_with_mode(revs, object, arg, oc.mode);
 +      add_pending_object_with_path(revs, object, arg, oc.mode, oc.path);
 +      free(oc.path);
        return 0;
  }
  
@@@ -2031,7 -1996,7 +2031,7 @@@ static int handle_revision_opt(struct r
                DIFF_OPT_SET(&revs->diffopt, PICKAXE_IGNORE_CASE);
        } else if (!strcmp(arg, "--fixed-strings") || !strcmp(arg, "-F")) {
                revs->grep_filter.pattern_type_option = GREP_PATTERN_TYPE_FIXED;
-       } else if (!strcmp(arg, "--perl-regexp")) {
+       } else if (!strcmp(arg, "--perl-regexp") || !strcmp(arg, "-P")) {
                revs->grep_filter.pattern_type_option = GREP_PATTERN_TYPE_PCRE;
        } else if (!strcmp(arg, "--all-match")) {
                revs->grep_filter.all_match = 1;
@@@ -2323,12 -2288,12 +2323,12 @@@ int setup_revisions(int argc, const cha
        if (revs->show_merge)
                prepare_show_merge(revs);
        if (revs->def && !revs->pending.nr && !got_rev_arg) {
 -              unsigned char sha1[20];
 +              struct object_id oid;
                struct object *object;
                struct object_context oc;
 -              if (get_sha1_with_context(revs->def, 0, sha1, &oc))
 +              if (get_sha1_with_context(revs->def, 0, oid.hash, &oc))
                        diagnose_missing_default(revs->def);
 -              object = get_reference(revs, revs->def, sha1, 0);
 +              object = get_reference(revs, revs->def, &oid, 0);
                add_pending_object_with_mode(revs, object, revs->def, oc.mode);
        }
  
diff --combined t/t4202-log.sh
index 66606e7508559e343d1b6959397dec77ddf5c6ac,2b07d1c0c224d5ce62ee9fa8960d7ac23c544425..3f3531f0a49be39e29b20a36a55f0d27f04b4fc8
@@@ -404,8 -404,20 +404,20 @@@ test_expect_success 'log with various g
                        --grep="(1|2)" >actual.fixed.short-arg &&
                git log --pretty=tformat:%s -E \
                        --grep="\|2" >actual.extended.short-arg &&
+               if test_have_prereq PCRE
+               then
+                       git log --pretty=tformat:%s -P \
+                               --grep="[\d]\|" >actual.perl.short-arg
+               else
+                       test_must_fail git log -P \
+                               --grep="[\d]\|"
+               fi &&
                test_cmp expect.fixed actual.fixed.short-arg &&
                test_cmp expect.extended actual.extended.short-arg &&
+               if test_have_prereq PCRE
+               then
+                       test_cmp expect.perl actual.perl.short-arg
+               fi &&
  
                git log --pretty=tformat:%s --fixed-strings \
                        --grep="(1|2)" >actual.fixed.long-arg &&
@@@ -547,7 -559,7 +559,7 @@@ cat > expect <<\EO
  | |
  | |     Merge branch 'side'
  | |
 -| * commit side
 +| * commit tags/side-2
  | | Author: A U Thor <author@example.com>
  | |
  | |     side-2
@@@ -725,18 -737,6 +737,18 @@@ test_expect_success 'log.decorate confi
  
  '
  
 +test_expect_success 'log.decorate config parsing' '
 +      git log --oneline --decorate=full >expect.full &&
 +      git log --oneline --decorate=short >expect.short &&
 +
 +      test_config log.decorate full &&
 +      test_config log.mailmap true &&
 +      git log --oneline >actual &&
 +      test_cmp expect.full actual &&
 +      git log --oneline --decorate=short >actual &&
 +      test_cmp expect.short actual
 +'
 +
  test_expect_success TTY 'log output on a TTY' '
        git log --oneline --decorate >expect.short &&
  
@@@ -1540,13 -1540,4 +1552,13 @@@ test_expect_success 'log --source paint
        test_cmp expect actual
  '
  
 +test_expect_success 'log --source paints symmetric ranges' '
 +      cat >expect <<-\EOF &&
 +      09e12a9 source-b three
 +      8e393e1 source-a two
 +      EOF
 +      git log --oneline --source source-a...source-b >actual &&
 +      test_cmp expect actual
 +'
 +
  test_done
diff --combined t/test-lib.sh
index 4936725c675f9dd3290e40722d8e40d63f3c874c,44d4679384c952361222c8f625804229f0266ce1..2306574dc9bacbfbb69469d95563b429a4cbb893
@@@ -745,36 -745,26 +745,36 @@@ test_done () 
        fi
        case "$test_failure" in
        0)
 -              # Maybe print SKIP message
 -              if test -n "$skip_all" && test $test_count -gt 0
 -              then
 -                      error "Can't use skip_all after running some tests"
 -              fi
 -              test -z "$skip_all" || skip_all=" # SKIP $skip_all"
 -
                if test $test_external_has_tap -eq 0
                then
                        if test $test_remaining -gt 0
                        then
                                say_color pass "# passed all $msg"
                        fi
 -                      say "1..$test_count$skip_all"
 +
 +                      # Maybe print SKIP message
 +                      test -z "$skip_all" || skip_all="# SKIP $skip_all"
 +                      case "$test_count" in
 +                      0)
 +                              say "1..$test_count${skip_all:+ $skip_all}"
 +                              ;;
 +                      *)
 +                              test -z "$skip_all" ||
 +                              say_color warn "$skip_all"
 +                              say "1..$test_count"
 +                              ;;
 +                      esac
                fi
  
 -              test -d "$remove_trash" &&
 -              cd "$(dirname "$remove_trash")" &&
 -              rm -rf "$(basename "$remove_trash")"
 +              if test -z "$debug"
 +              then
 +                      test -d "$TRASH_DIRECTORY" ||
 +                      error "Tests passed but trash directory already removed before test cleanup; aborting"
  
 +                      cd "$TRASH_DIRECTORY/.." &&
 +                      rm -fr "$TRASH_DIRECTORY" ||
 +                      error "Tests passed but test cleanup failed; aborting"
 +              fi
                test_at_end_hook_
  
                exit 0 ;;
@@@ -929,6 -919,7 +929,6 @@@ case "$TRASH_DIRECTORY" i
  /*) ;; # absolute path is good
   *) TRASH_DIRECTORY="$TEST_OUTPUT_DIRECTORY/$TRASH_DIRECTORY" ;;
  esac
 -test ! -z "$debug" || remove_trash=$TRASH_DIRECTORY
  rm -fr "$TRASH_DIRECTORY" || {
        GIT_EXIT_OK=t
        echo >&5 "FATAL: Cannot prepare test area"
@@@ -1020,7 -1011,7 +1020,7 @@@ esa
  test -z "$NO_PERL" && test_set_prereq PERL
  test -z "$NO_PTHREADS" && test_set_prereq PTHREADS
  test -z "$NO_PYTHON" && test_set_prereq PYTHON
- test -n "$USE_LIBPCRE1" && test_set_prereq PCRE
+ test -n "$USE_LIBPCRE1$USE_LIBPCRE2" && test_set_prereq PCRE
  test -z "$NO_GETTEXT" && test_set_prereq GETTEXT
  
  # Can we rely on git's output in the C locale?
@@@ -1174,6 -1165,3 +1174,6 @@@ build_option () 
  test_lazy_prereq LONG_IS_64BIT '
        test 8 -le "$(build_option sizeof-long)"
  '
 +
 +test_lazy_prereq TIME_IS_64BIT 'test-date is64bit'
 +test_lazy_prereq TIME_T_IS_64BIT 'test-date time_t-is64bit'