Sync with v1.8.2.3

* maint:
Git 1.8.2.3
t5004: avoid using tar for checking emptiness of archive
t5004: ignore pax global header file
mergetools/kdiff3: do not use --auto when diffing
transport-helper: trivial style cleanup

diff --git a/Documentation/RelNotes/1.8.2.3.txt b/Documentation/RelNotes/1.8.2.3.txt
new file mode 100644 (file)
index 0000000..6139482
--- /dev/null
+++ b/Documentation/RelNotes/1.8.2.3.txt
@@ -0,0 +1,19 @@
+Git v1.8.2.3 Release Notes
+==========================
+
+Fixes since v1.8.2.2
+--------------------
+
+ * "rev-list --stdin" and friends kept bogus pointers into the input
+   buffer around as human readable object names.  This was not a
+   huge problem but was exposed by a new change that uses these
+   names in error output.
+
+ * When "git difftool" drove "kdiff3", it mistakenly passed --auto
+   option that was meant while resolving merge conflicts.
+
+ * "git remote add" command did not diagnose extra command line
+   arguments as an error and silently ignored them.
+
+Also contains a handful of trivial code clean-ups, documentation
+updates, updates to the test suite, etc.

diff --git a/Documentation/git.txt b/Documentation/git.txt
index 8438c076c3385246e5d381ce8323d50b6d72211a..9e302b0a60552c4297cb94018dad49169505bd35 100644 (file)
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -43,9 +43,10 @@ unreleased) version of Git, that is available from 'master'
 branch of the `git.git` repository.
 Documentation for older releases are available here:
 
-* link:v1.8.2.2/git.html[documentation for release 1.8.2.2]
+* link:v1.8.2.3/git.html[documentation for release 1.8.2.3]
 
 * release notes for
+  link:RelNotes/1.8.2.3.txt[1.8.2.3].
   link:RelNotes/1.8.2.2.txt[1.8.2.2].
   link:RelNotes/1.8.2.1.txt[1.8.2.1].
   link:RelNotes/1.8.2.txt[1.8.2].

diff --git a/mergetools/kdiff3 b/mergetools/kdiff3
index 28fead428b333448566f480a434967fb7325c744..a30034f116fda6f90448aeb4ddd42063ea60aad1 100644 (file)
--- a/mergetools/kdiff3
+++ b/mergetools/kdiff3
@@ -1,5 +1,5 @@
 diff_cmd () {
-       "$merge_tool_path" --auto \
+       "$merge_tool_path" \
                --L1 "$MERGED (A)" --L2 "$MERGED (B)" \
                "$LOCAL" "$REMOTE" >/dev/null 2>&1
 }

diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh
index bfdb56a0694db0c6ed07aaa568c648909ac62660..8d1bbd356ac9a22021db0cdbd14544fbcf3c9246 100755 (executable)
--- a/t/t5004-archive-corner-cases.sh
+++ b/t/t5004-archive-corner-cases.sh
@@ -23,15 +23,14 @@ check_dir() {
                        echo "$dir/$i"
                done
        } | sort >expect &&
-       find "$dir" -print | sort >actual &&
+       find "$dir" ! -name pax_global_header -print | sort >actual &&
        test_cmp expect actual
 }
 
 test_expect_success 'tar archive of empty tree is empty' '
        git archive --format=tar HEAD: >empty.tar &&
-       make_dir extract &&
-       "$TAR" xf empty.tar -C extract &&
-       check_dir extract
+       perl -e "print \"\\0\" x 10240" >10knuls.tar &&
+       test_cmp 10knuls.tar empty.tar
 '
 
 test_expect_success 'tar archive of empty tree with prefix' '

diff --git a/transport-helper.c b/transport-helper.c
index 835815f61d7cfe12b32b13d92241830af858f8f4..522d79178e2cc4909a5df21fe483946fc3d1ad0e 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -214,9 +214,8 @@ static struct child_process *get_helper(struct transport *transport)
                int i;
                data->refspec_nr = refspec_nr;
                data->refspecs = parse_fetch_refspec(refspec_nr, refspecs);
-               for (i = 0; i < refspec_nr; i++) {
+               for (i = 0; i < refspec_nr; i++)
                        free((char *)refspecs[i]);
-               }
                free(refspecs);
        }
        strbuf_release(&buf);