Merge branch 'rs/archive-tree-in-tip-simplify'
authorJunio C Hamano <gitster@pobox.com>
Wed, 23 May 2012 20:35:22 +0000 (13:35 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 23 May 2012 20:35:22 +0000 (13:35 -0700)
By René Scharfe
* rs/archive-tree-in-tip-simplify:
archive-tar: keep const in checksum calculation
archive: simplify refname handling

1  2 
archive-tar.c
archive.c
diff --combined archive-tar.c
index 93387ea336b107340d789240b287bf0a12409f24,55cccecadf41558aa780434eb23262a537df9232..dc91c6b50d56ad8fd9921d0e47f5b45cafdcfc4d
@@@ -4,7 -4,6 +4,7 @@@
  #include "cache.h"
  #include "tar.h"
  #include "archive.h"
 +#include "streaming.h"
  #include "run-command.h"
  
  #define RECORDSIZE    (512)
@@@ -31,9 -30,10 +31,9 @@@ static void write_if_needed(void
   * queues up writes, so that all our write(2) calls write exactly one
   * full block; pads writes to RECORDSIZE
   */
 -static void write_blocked(const void *data, unsigned long size)
 +static void do_write_blocked(const void *data, unsigned long size)
  {
        const char *buf = data;
 -      unsigned long tail;
  
        if (offset) {
                unsigned long chunk = BLOCKSIZE - offset;
                memcpy(block + offset, buf, size);
                offset += size;
        }
 +}
 +
 +static void finish_record(void)
 +{
 +      unsigned long tail;
        tail = offset % RECORDSIZE;
        if (tail)  {
                memset(block + offset, 0, RECORDSIZE - tail);
        write_if_needed();
  }
  
 +static void write_blocked(const void *data, unsigned long size)
 +{
 +      do_write_blocked(data, size);
 +      finish_record();
 +}
 +
  /*
   * The end of tar archives is marked by 2*512 nul bytes and after that
   * follows the rest of the block (if any).
@@@ -88,33 -77,6 +88,33 @@@ static void write_trailer(void
        }
  }
  
 +/*
 + * queues up writes, so that all our write(2) calls write exactly one
 + * full block; pads writes to RECORDSIZE
 + */
 +static int stream_blocked(const unsigned char *sha1)
 +{
 +      struct git_istream *st;
 +      enum object_type type;
 +      unsigned long sz;
 +      char buf[BLOCKSIZE];
 +      ssize_t readlen;
 +
 +      st = open_istream(sha1, &type, &sz, NULL);
 +      if (!st)
 +              return error("cannot stream blob %s", sha1_to_hex(sha1));
 +      for (;;) {
 +              readlen = read_istream(st, buf, sizeof(buf));
 +              if (readlen <= 0)
 +                      break;
 +              do_write_blocked(buf, readlen);
 +      }
 +      close_istream(st);
 +      if (!readlen)
 +              finish_record();
 +      return readlen;
 +}
 +
  /*
   * pax extended header records have the format "%u %s=%s\n".  %u contains
   * the size of the whole string (including the %u), the first %s is the
@@@ -139,13 -101,13 +139,13 @@@ static void strbuf_append_ext_header(st
  
  static unsigned int ustar_header_chksum(const struct ustar_header *header)
  {
-       char *p = (char *)header;
+       const char *p = (const char *)header;
        unsigned int chksum = 0;
        while (p < header->chksum)
                chksum += *p++;
        chksum += sizeof(header->chksum) * ' ';
        p += sizeof(header->chksum);
-       while (p < (char *)header + sizeof(struct ustar_header))
+       while (p < (const char *)header + sizeof(struct ustar_header))
                chksum += *p++;
        return chksum;
  }
@@@ -161,101 -123,56 +161,101 @@@ static size_t get_path_prefix(const cha
        return i;
  }
  
 +static void prepare_header(struct archiver_args *args,
 +                         struct ustar_header *header,
 +                         unsigned int mode, unsigned long size)
 +{
 +      sprintf(header->mode, "%07o", mode & 07777);
 +      sprintf(header->size, "%011lo", S_ISREG(mode) ? size : 0);
 +      sprintf(header->mtime, "%011lo", (unsigned long) args->time);
 +
 +      sprintf(header->uid, "%07o", 0);
 +      sprintf(header->gid, "%07o", 0);
 +      strlcpy(header->uname, "root", sizeof(header->uname));
 +      strlcpy(header->gname, "root", sizeof(header->gname));
 +      sprintf(header->devmajor, "%07o", 0);
 +      sprintf(header->devminor, "%07o", 0);
 +
 +      memcpy(header->magic, "ustar", 6);
 +      memcpy(header->version, "00", 2);
 +
 +      sprintf(header->chksum, "%07o", ustar_header_chksum(header));
 +}
 +
 +static int write_extended_header(struct archiver_args *args,
 +                               const unsigned char *sha1,
 +                               const void *buffer, unsigned long size)
 +{
 +      struct ustar_header header;
 +      unsigned int mode;
 +      memset(&header, 0, sizeof(header));
 +      *header.typeflag = TYPEFLAG_EXT_HEADER;
 +      mode = 0100666;
 +      sprintf(header.name, "%s.paxheader", sha1_to_hex(sha1));
 +      prepare_header(args, &header, mode, size);
 +      write_blocked(&header, sizeof(header));
 +      write_blocked(buffer, size);
 +      return 0;
 +}
 +
  static int write_tar_entry(struct archiver_args *args,
 -              const unsigned char *sha1, const char *path, size_t pathlen,
 -              unsigned int mode, void *buffer, unsigned long size)
 +                         const unsigned char *sha1,
 +                         const char *path, size_t pathlen,
 +                         unsigned int mode)
  {
        struct ustar_header header;
        struct strbuf ext_header = STRBUF_INIT;
 +      unsigned int old_mode = mode;
 +      unsigned long size;
 +      void *buffer;
        int err = 0;
  
        memset(&header, 0, sizeof(header));
  
 -      if (!sha1) {
 -              *header.typeflag = TYPEFLAG_GLOBAL_HEADER;
 -              mode = 0100666;
 -              strcpy(header.name, "pax_global_header");
 -      } else if (!path) {
 -              *header.typeflag = TYPEFLAG_EXT_HEADER;
 -              mode = 0100666;
 -              sprintf(header.name, "%s.paxheader", sha1_to_hex(sha1));
 +      if (S_ISDIR(mode) || S_ISGITLINK(mode)) {
 +              *header.typeflag = TYPEFLAG_DIR;
 +              mode = (mode | 0777) & ~tar_umask;
 +      } else if (S_ISLNK(mode)) {
 +              *header.typeflag = TYPEFLAG_LNK;
 +              mode |= 0777;
 +      } else if (S_ISREG(mode)) {
 +              *header.typeflag = TYPEFLAG_REG;
 +              mode = (mode | ((mode & 0100) ? 0777 : 0666)) & ~tar_umask;
        } else {
 -              if (S_ISDIR(mode) || S_ISGITLINK(mode)) {
 -                      *header.typeflag = TYPEFLAG_DIR;
 -                      mode = (mode | 0777) & ~tar_umask;
 -              } else if (S_ISLNK(mode)) {
 -                      *header.typeflag = TYPEFLAG_LNK;
 -                      mode |= 0777;
 -              } else if (S_ISREG(mode)) {
 -                      *header.typeflag = TYPEFLAG_REG;
 -                      mode = (mode | ((mode & 0100) ? 0777 : 0666)) & ~tar_umask;
 +              return error("unsupported file mode: 0%o (SHA1: %s)",
 +                           mode, sha1_to_hex(sha1));
 +      }
 +      if (pathlen > sizeof(header.name)) {
 +              size_t plen = get_path_prefix(path, pathlen,
 +                                            sizeof(header.prefix));
 +              size_t rest = pathlen - plen - 1;
 +              if (plen > 0 && rest <= sizeof(header.name)) {
 +                      memcpy(header.prefix, path, plen);
 +                              memcpy(header.name, path + plen + 1, rest);
                } else {
 -                      return error("unsupported file mode: 0%o (SHA1: %s)",
 -                                      mode, sha1_to_hex(sha1));
 +                      sprintf(header.name, "%s.data",
 +                              sha1_to_hex(sha1));
 +                      strbuf_append_ext_header(&ext_header, "path",
 +                                               path, pathlen);
                }
 -              if (pathlen > sizeof(header.name)) {
 -                      size_t plen = get_path_prefix(path, pathlen,
 -                                      sizeof(header.prefix));
 -                      size_t rest = pathlen - plen - 1;
 -                      if (plen > 0 && rest <= sizeof(header.name)) {
 -                              memcpy(header.prefix, path, plen);
 -                              memcpy(header.name, path + plen + 1, rest);
 -                      } else {
 -                              sprintf(header.name, "%s.data",
 -                                      sha1_to_hex(sha1));
 -                              strbuf_append_ext_header(&ext_header, "path",
 -                                              path, pathlen);
 -                      }
 -              } else
 -                      memcpy(header.name, path, pathlen);
 +      } else
 +              memcpy(header.name, path, pathlen);
 +
 +      if (S_ISREG(mode) && !args->convert &&
 +          sha1_object_info(sha1, &size) == OBJ_BLOB &&
 +          size > big_file_threshold)
 +              buffer = NULL;
 +      else if (S_ISLNK(mode) || S_ISREG(mode)) {
 +              enum object_type type;
 +              buffer = sha1_file_to_archive(args, path, sha1, old_mode, &type, &size);
 +              if (!buffer)
 +                      return error("cannot read %s", sha1_to_hex(sha1));
 +      } else {
 +              buffer = NULL;
 +              size = 0;
        }
  
 -      if (S_ISLNK(mode) && buffer) {
 +      if (S_ISLNK(mode)) {
                if (size > sizeof(header.linkname)) {
                        sprintf(header.linkname, "see %s.paxheader",
                                sha1_to_hex(sha1));
                        memcpy(header.linkname, buffer, size);
        }
  
 -      sprintf(header.mode, "%07o", mode & 07777);
 -      sprintf(header.size, "%011lo", S_ISREG(mode) ? size : 0);
 -      sprintf(header.mtime, "%011lo", (unsigned long) args->time);
 -
 -      sprintf(header.uid, "%07o", 0);
 -      sprintf(header.gid, "%07o", 0);
 -      strlcpy(header.uname, "root", sizeof(header.uname));
 -      strlcpy(header.gname, "root", sizeof(header.gname));
 -      sprintf(header.devmajor, "%07o", 0);
 -      sprintf(header.devminor, "%07o", 0);
 -
 -      memcpy(header.magic, "ustar", 6);
 -      memcpy(header.version, "00", 2);
 -
 -      sprintf(header.chksum, "%07o", ustar_header_chksum(&header));
 +      prepare_header(args, &header, mode, size);
  
        if (ext_header.len > 0) {
 -              err = write_tar_entry(args, sha1, NULL, 0, 0, ext_header.buf,
 -                              ext_header.len);
 -              if (err)
 +              err = write_extended_header(args, sha1, ext_header.buf,
 +                                          ext_header.len);
 +              if (err) {
 +                      free(buffer);
                        return err;
 +              }
        }
        strbuf_release(&ext_header);
        write_blocked(&header, sizeof(header));
 -      if (S_ISREG(mode) && buffer && size > 0)
 -              write_blocked(buffer, size);
 +      if (S_ISREG(mode) && size > 0) {
 +              if (buffer)
 +                      write_blocked(buffer, size);
 +              else
 +                      err = stream_blocked(sha1);
 +      }
 +      free(buffer);
        return err;
  }
  
@@@ -291,18 -215,11 +291,18 @@@ static int write_global_extended_header
  {
        const unsigned char *sha1 = args->commit_sha1;
        struct strbuf ext_header = STRBUF_INIT;
 -      int err;
 +      struct ustar_header header;
 +      unsigned int mode;
 +      int err = 0;
  
        strbuf_append_ext_header(&ext_header, "comment", sha1_to_hex(sha1), 40);
 -      err = write_tar_entry(args, NULL, NULL, 0, 0, ext_header.buf,
 -                      ext_header.len);
 +      memset(&header, 0, sizeof(header));
 +      *header.typeflag = TYPEFLAG_GLOBAL_HEADER;
 +      mode = 0100666;
 +      strcpy(header.name, "pax_global_header");
 +      prepare_header(args, &header, mode, ext_header.len);
 +      write_blocked(&header, sizeof(header));
 +      write_blocked(ext_header.buf, ext_header.len);
        strbuf_release(&ext_header);
        return err;
  }
diff --combined archive.c
index cd083eaf9aa2f1ae4cfc57d90fb11b8f808fbfe7,1e7156d580256db9f5033f858ea7d408ec182f44..a4844330fb4da325aa364640dc80f052dc7b7ad7
+++ b/archive.c
@@@ -59,15 -59,12 +59,15 @@@ static void format_subst(const struct c
        free(to_free);
  }
  
 -static void *sha1_file_to_archive(const char *path, const unsigned char *sha1,
 -              unsigned int mode, enum object_type *type,
 -              unsigned long *sizep, const struct commit *commit)
 +void *sha1_file_to_archive(const struct archiver_args *args,
 +                         const char *path, const unsigned char *sha1,
 +                         unsigned int mode, enum object_type *type,
 +                         unsigned long *sizep)
  {
        void *buffer;
 +      const struct commit *commit = args->convert ? args->commit : NULL;
  
 +      path += args->baselen;
        buffer = read_sha1_file(sha1, type, sizep);
        if (buffer && S_ISREG(mode)) {
                struct strbuf buf = STRBUF_INIT;
@@@ -112,9 -109,12 +112,9 @@@ static int write_archive_entry(const un
        write_archive_entry_fn_t write_entry = c->write_entry;
        struct git_attr_check check[2];
        const char *path_without_prefix;
 -      int convert = 0;
        int err;
 -      enum object_type type;
 -      unsigned long size;
 -      void *buffer;
  
 +      args->convert = 0;
        strbuf_reset(&path);
        strbuf_grow(&path, PATH_MAX);
        strbuf_add(&path, args->base, args->baselen);
        if (!git_check_attr(path_without_prefix, ARRAY_SIZE(check), check)) {
                if (ATTR_TRUE(check[0].value))
                        return 0;
 -              convert = ATTR_TRUE(check[1].value);
 +              args->convert = ATTR_TRUE(check[1].value);
        }
  
        if (S_ISDIR(mode) || S_ISGITLINK(mode)) {
                strbuf_addch(&path, '/');
                if (args->verbose)
                        fprintf(stderr, "%.*s\n", (int)path.len, path.buf);
 -              err = write_entry(args, sha1, path.buf, path.len, mode, NULL, 0);
 +              err = write_entry(args, sha1, path.buf, path.len, mode);
                if (err)
                        return err;
                return (S_ISDIR(mode) ? READ_TREE_RECURSIVE : 0);
        }
  
 -      buffer = sha1_file_to_archive(path_without_prefix, sha1, mode,
 -                      &type, &size, convert ? args->commit : NULL);
 -      if (!buffer)
 -              return error("cannot read %s", sha1_to_hex(sha1));
        if (args->verbose)
                fprintf(stderr, "%.*s\n", (int)path.len, path.buf);
 -      err = write_entry(args, sha1, path.buf, path.len, mode, buffer, size);
 -      free(buffer);
 -      return err;
 +      return write_entry(args, sha1, path.buf, path.len, mode);
  }
  
  int write_archive_entries(struct archiver_args *args,
                if (args->verbose)
                        fprintf(stderr, "%.*s\n", (int)len, args->base);
                err = write_entry(args, args->tree->object.sha1, args->base,
 -                              len, 040777, NULL, 0);
 +                                len, 040777);
                if (err)
                        return err;
        }
@@@ -254,18 -260,11 +254,11 @@@ static void parse_treeish_arg(const cha
        /* Remotes are only allowed to fetch actual refs */
        if (remote) {
                char *ref = NULL;
-               const char *refname, *colon = NULL;
-               colon = strchr(name, ':');
-               if (colon)
-                       refname = xstrndup(name, colon - name);
-               else
-                       refname = name;
-               if (!dwim_ref(refname, strlen(refname), sha1, &ref))
-                       die("no such ref: %s", refname);
-               if (refname != name)
-                       free((void *)refname);
+               const char *colon = strchr(name, ':');
+               int refnamelen = colon ? colon - name : strlen(name);
+               if (!dwim_ref(name, refnamelen, sha1, &ref))
+                       die("no such ref: %.*s", refnamelen, name);
                free(ref);
        }