Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
test-path-utils: Fix off by one, found by valgrind
author
Johannes Schindelin
<johannes.schindelin@gmx.de>
Tue, 27 Jan 2009 23:07:36 +0000
(
00:07
+0100)
committer
Junio C Hamano
<gitster@pobox.com>
Tue, 27 Jan 2009 23:16:41 +0000
(15:16 -0800)
When normalizing an absolute path, we might have to add a slash _and_ a
NUL to the buffer, so the buffer was one too small.
Let's just future proof the code and alloc PATH_MAX + 1 bytes.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
test-path-utils.c
patch
|
blob
|
history
raw
|
patch
| inline |
side by side
(parent:
f265458
)
diff --git
a/test-path-utils.c
b/test-path-utils.c
index a0bcb0e210523124fa977c8bf46667cf25d0335f..2c0f5a37e8b9051b1db80aa04e9ea763fb8d772b 100644
(file)
--- a/
test-path-utils.c
+++ b/
test-path-utils.c
@@
-3,7
+3,7
@@
int main(int argc, char **argv)
{
if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) {
- char *buf = xmalloc(
strlen(argv[2])+
1);
+ char *buf = xmalloc(
PATH_MAX +
1);
int rv = normalize_absolute_path(buf, argv[2]);
assert(strlen(buf) == rv);
puts(buf);