Git.pm: Don't require a repository instance for config

git config itself doesn't require to be called in a repository,
so don't add arbitrary restrictions.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/perl/Git.pm b/perl/Git.pm
index a2812ea612b997c1a76d89075dd1263a3af4fd37..67b3749f0e80e2ea74b71acba43fa69b92a9cc40 100644 (file)
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -487,22 +487,20 @@ sub wc_chdir {
 (exception is thrown otherwise), in array context returns allows the
 variable to be set multiple times and returns all the values.
 
 (exception is thrown otherwise), in array context returns allows the
 variable to be set multiple times and returns all the values.
 

-Must be called on a repository instance.
-

 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config {
 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config {

-       my ($self, $var) = @_;
-       $self->repo_path()
-               or throw Error::Simple("not a repository");
+       my ($self, $var) = _maybe_self(@_);

 
        try {
 
        try {

+               my @cmd = ('config');
+               unshift @cmd, $self if $self;

                if (wantarray) {
                if (wantarray) {

-                       return $self->command('config', '--get-all', $var);
+                       return command(@cmd, '--get-all', $var);

                } else {
                } else {

-                       return $self->command_oneline('config', '--get', $var);
+                       return command_oneline(@cmd, '--get', $var);

                }
        } catch Git::Error::Command with {
                my $E = shift;
                }
        } catch Git::Error::Command with {
                my $E = shift;


@@ -522,20 +520,17 @@ sub config {
 is usable as a boolean in perl (and C<undef> if it's not defined,
 of course).
 
 is usable as a boolean in perl (and C<undef> if it's not defined,
 of course).
 

-Must be called on a repository instance.
-

 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config_bool {
 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config_bool {

-       my ($self, $var) = @_;
-       $self->repo_path()
-               or throw Error::Simple("not a repository");
+       my ($self, $var) = _maybe_self(@_);

 
        try {
 
        try {

-               my $val = $self->command_oneline('config', '--bool', '--get',
-                                             $var);
+               my @cmd = ('config', '--bool', '--get', $var);
+               unshift @cmd, $self if $self;
+               my $val = command_oneline(@cmd);

                return undef unless defined $val;
                return $val eq 'true';
        } catch Git::Error::Command with {
                return undef unless defined $val;
                return $val eq 'true';
        } catch Git::Error::Command with {


@@ -557,19 +552,17 @@ sub config_bool {
 by 1024, 1048576 (1024^2), or 1073741824 (1024^3) prior to output.
 It would return C<undef> if configuration variable is not defined,
 
 by 1024, 1048576 (1024^2), or 1073741824 (1024^3) prior to output.
 It would return C<undef> if configuration variable is not defined,
 

-Must be called on a repository instance.
-

 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config_int {
 This currently wraps command('config') so it is not so fast.
 
 =cut
 
 sub config_int {

-       my ($self, $var) = @_;
-       $self->repo_path()
-               or throw Error::Simple("not a repository");
+       my ($self, $var) = _maybe_self(@_);

 
        try {
 
        try {

-               return $self->command_oneline('config', '--int', '--get', $var);
+               my @cmd = ('config', '--int', '--get', $var);
+               unshift @cmd, $self if $self;
+               return command_oneline(@cmd);

        } catch Git::Error::Command with {
                my $E = shift;
                if ($E->value() == 1) {
        } catch Git::Error::Command with {
                my $E = shift;
                if ($E->value() == 1) {