gitweb: make static files accessible with PATH_INFO
authorGiuseppe Bilotta <giuseppe.bilotta@gmail.com>
Sat, 31 Jan 2009 01:31:50 +0000 (02:31 +0100)
committerJunio C Hamano <gitster@pobox.com>
Sat, 31 Jan 2009 05:08:24 +0000 (21:08 -0800)
Gitweb links to a number of static files such as CSS stylesheets,
favicon or the git logo. When, such as with the default Makefile, the
paths to these files are relative (i.e. doesn't start with a "/"), the
files become inaccessible in any view other tha project list and summary
page if gitweb is invoked with a non-empty PATH_INFO.

Fix this by adding a <base> element pointing to the script's own URL,
which ensure that all relative paths will be resolved correctly.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl
index f4defb01d9bd4c27b486838fdb5189064fc601c3..87948fc422ff9445ae7bb9a951fcc655fc054462 100755 (executable)
@@ -2901,6 +2901,11 @@ sub git_header_html {
 <meta name="robots" content="index, nofollow"/>
 <title>$title</title>
 EOF
+# the stylesheet, favicon etc urls won't work correctly with path_info unless we
+# set the appropriate base URL
+       if ($ENV{'PATH_INFO'}) {
+               print '<base href="'.esc_url($my_url).'" />\n';
+       }
 # print out each stylesheet that exist
        if (defined $stylesheet) {
 #provides backwards capability for those people who define style sheet in a config file