Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
gitweb: Move git_get_last_activity subroutine earlier
author
Jakub Narebski
<jnareb@gmail.com>
Sat, 28 Oct 2006 17:43:40 +0000
(19:43 +0200)
committer
Junio C Hamano
<junkio@cox.net>
Sat, 28 Oct 2006 21:26:00 +0000
(14:26 -0700)
This is purely cosmetic. Having git_get_* between two parse_* subroutines
violated a good convention to group related things together.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.perl
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
1dc5e55
)
diff --git
a/gitweb/gitweb.perl
b/gitweb/gitweb.perl
index 7b2499af1ecaf11fa4bd775d2bfcc2abc5f477c0..6714e418750d2835b9d80418daf2d90ab6ab058c 100755
(executable)
--- a/
gitweb/gitweb.perl
+++ b/
gitweb/gitweb.perl
@@
-976,6
+976,24
@@
sub git_get_project_owner {
return $owner;
}
return $owner;
}
+sub git_get_last_activity {
+ my ($path) = @_;
+ my $fd;
+
+ $git_dir = "$projectroot/$path";
+ open($fd, "-|", git_cmd(), 'for-each-ref',
+ '--format=%(refname) %(committer)',
+ '--sort=-committerdate',
+ 'refs/heads') or return;
+ my $most_recent = <$fd>;
+ close $fd or return;
+ if ($most_recent =~ / (\d+) [-+][01]\d\d\d$/) {
+ my $timestamp = $1;
+ my $age = time - $timestamp;
+ return ($age, age_string($age));
+ }
+}
+
sub git_get_references {
my $type = shift || "";
my %refs;
sub git_get_references {
my $type = shift || "";
my %refs;
@@
-1082,24
+1100,6
@@
sub parse_tag {
return %tag
}
return %tag
}
-sub git_get_last_activity {
- my ($path) = @_;
- my $fd;
-
- $git_dir = "$projectroot/$path";
- open($fd, "-|", git_cmd(), 'for-each-ref',
- '--format=%(refname) %(committer)',
- '--sort=-committerdate',
- 'refs/heads') or return;
- my $most_recent = <$fd>;
- close $fd or return;
- if ($most_recent =~ / (\d+) [-+][01]\d\d\d$/) {
- my $timestamp = $1;
- my $age = time - $timestamp;
- return ($age, age_string($age));
- }
-}
-
sub parse_commit {
my $commit_id = shift;
my $commit_text = shift;
sub parse_commit {
my $commit_id = shift;
my $commit_text = shift;