Merge branch 'ab/bsd-fixes'
authorJunio C Hamano <gitster@pobox.com>
Sat, 23 Feb 2019 05:20:19 +0000 (21:20 -0800)
committerJunio C Hamano <gitster@pobox.com>
Sat, 23 Feb 2019 05:20:19 +0000 (21:20 -0800)
Test portability fix.

* ab/bsd-fixes:
commit-graph tests: fix unportable "dd" invocation
tests: fix unportable "\?" and "\+" regex syntax

t/t5318-commit-graph.sh
t/t6120-describe.sh
index d4bd1522fe2e6e94578b2d6f709005c7a271b4b0..561796f2809c38d3b5229abd4359f5b72141839e 100755 (executable)
@@ -382,7 +382,7 @@ corrupt_graph_and_verify() {
        test_when_finished mv commit-graph-backup $objdir/info/commit-graph &&
        cp $objdir/info/commit-graph commit-graph-backup &&
        printf "$data" | dd of="$objdir/info/commit-graph" bs=1 seek="$pos" conv=notrunc &&
-       dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=0 &&
+       dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" if=/dev/null &&
        generate_zero_bytes $(($orig_size - $zero_pos)) >>"$objdir/info/commit-graph" &&
        test_must_fail git commit-graph verify 2>test_err &&
        grep -v "^+" test_err >err &&
index ee5b03ee18ada34a7b8012d219cbb63c4bb7f256..2b883d8174036b7d2246fcd89f239d7ecde049d4 100755 (executable)
@@ -146,7 +146,7 @@ check_describe A-* HEAD
 test_expect_success 'describe works from outside repo using --git-dir' '
        git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" &&
        git --git-dir "$TRASH_DIRECTORY/bare" describe >out &&
-       grep "^A-[1-9][0-9]\?-g[0-9a-f]\+$" out
+       grep -E "^A-[1-9][0-9]?-g[0-9a-f]+$" out
 '
 
 check_describe "A-*[0-9a-f]" --dirty
@@ -156,7 +156,7 @@ test_expect_success 'describe --dirty with --work-tree' '
                cd "$TEST_DIRECTORY" &&
                git --git-dir "$TRASH_DIRECTORY/.git" --work-tree "$TRASH_DIRECTORY" describe --dirty >"$TRASH_DIRECTORY/out"
        ) &&
-       grep "^A-[1-9][0-9]\?-g[0-9a-f]\+$" out
+       grep -E "^A-[1-9][0-9]?-g[0-9a-f]+$" out
 '
 
 test_expect_success 'set-up dirty work tree' '
@@ -170,7 +170,7 @@ test_expect_success 'describe --dirty with --work-tree (dirty)' '
                cd "$TEST_DIRECTORY" &&
                git --git-dir "$TRASH_DIRECTORY/.git" --work-tree "$TRASH_DIRECTORY" describe --dirty >"$TRASH_DIRECTORY/out"
        ) &&
-       grep "^A-[1-9][0-9]\?-g[0-9a-f]\+-dirty$" out
+       grep -E "^A-[1-9][0-9]?-g[0-9a-f]+-dirty$" out
 '
 
 check_describe "A-*[0-9a-f].mod" --dirty=.mod
@@ -180,7 +180,7 @@ test_expect_success 'describe --dirty=.mod with --work-tree (dirty)' '
                cd "$TEST_DIRECTORY" &&
                git --git-dir "$TRASH_DIRECTORY/.git" --work-tree "$TRASH_DIRECTORY" describe --dirty=.mod >"$TRASH_DIRECTORY/out"
        ) &&
-       grep "^A-[1-9][0-9]\?-g[0-9a-f]\+.mod$" out
+       grep -E "^A-[1-9][0-9]?-g[0-9a-f]+.mod$" out
 '
 
 test_expect_success 'describe --dirty HEAD' '