Merge branch 'ds/lazy-load-trees'
authorJunio C Hamano <gitster@pobox.com>
Wed, 23 May 2018 05:38:13 +0000 (14:38 +0900)
committerJunio C Hamano <gitster@pobox.com>
Wed, 23 May 2018 05:38:13 +0000 (14:38 +0900)
The code has been taught to use the duplicated information stored
in the commit-graph file to learn the tree object name for a commit
to avoid opening and parsing the commit object when it makes sense
to do so.

* ds/lazy-load-trees:
coccinelle: avoid wrong transformation suggestions from commit.cocci
commit-graph: lazy-load trees for commits
treewide: replace maybe_tree with accessor methods
commit: create get_commit_tree() method
treewide: rename tree to maybe_tree

21 files changed:
1  2 
blame.c
builtin/checkout.c
builtin/fast-export.c
builtin/log.c
builtin/reflog.c
commit-graph.c
commit.c
fsck.c
http-push.c
line-log.c
log-tree.c
merge-recursive.c
notes-merge.c
packfile.c
pretty.c
ref-filter.c
revision.c
sequencer.c
sha1-name.c
tree.c
walker.c
diff --combined blame.c
index 78c9808bd1a04a4c641b0f5f853540ea7618a522,7f5700b3248bb59354195f5eadd8d57b9df08ba7..f858525082d4bd8445d3c79b488bec693ea7760a
+++ b/blame.c
@@@ -80,8 -80,8 +80,8 @@@ static void verify_working_tree_path(st
                struct object_id blob_oid;
                unsigned mode;
  
 -              if (!get_tree_entry(commit_oid->hash, path, blob_oid.hash, &mode) &&
 -                  sha1_object_info(blob_oid.hash, NULL) == OBJ_BLOB)
 +              if (!get_tree_entry(commit_oid, path, &blob_oid, &mode) &&
 +                  oid_object_info(&blob_oid, NULL) == OBJ_BLOB)
                        return;
        }
  
@@@ -297,8 -297,8 +297,8 @@@ static void fill_origin_blob(struct dif
                    textconv_object(o->path, o->mode, &o->blob_oid, 1, &file->ptr, &file_size))
                        ;
                else
 -                      file->ptr = read_sha1_file(o->blob_oid.hash, &type,
 -                                                 &file_size);
 +                      file->ptr = read_object_file(&o->blob_oid, &type,
 +                                                   &file_size);
                file->size = file_size;
  
                if (!file->ptr)
@@@ -502,9 -502,11 +502,9 @@@ static int fill_blob_sha1_and_mode(stru
  {
        if (!is_null_oid(&origin->blob_oid))
                return 0;
 -      if (get_tree_entry(origin->commit->object.oid.hash,
 -                         origin->path,
 -                         origin->blob_oid.hash, &origin->mode))
 +      if (get_tree_entry(&origin->commit->object.oid, origin->path, &origin->blob_oid, &origin->mode))
                goto error_out;
 -      if (sha1_object_info(origin->blob_oid.hash, NULL) != OBJ_BLOB)
 +      if (oid_object_info(&origin->blob_oid, NULL) != OBJ_BLOB)
                goto error_out;
        return 0;
   error_out:
@@@ -551,10 -553,10 +551,10 @@@ static struct blame_origin *find_origin
        diff_setup_done(&diff_opts);
  
        if (is_null_oid(&origin->commit->object.oid))
-               do_diff_cache(&parent->tree->object.oid, &diff_opts);
+               do_diff_cache(get_commit_tree_oid(parent), &diff_opts);
        else
-               diff_tree_oid(&parent->tree->object.oid,
-                             &origin->commit->tree->object.oid,
+               diff_tree_oid(get_commit_tree_oid(parent),
+                             get_commit_tree_oid(origin->commit),
                              "", &diff_opts);
        diffcore_std(&diff_opts);
  
@@@ -620,10 -622,10 +620,10 @@@ static struct blame_origin *find_rename
        diff_setup_done(&diff_opts);
  
        if (is_null_oid(&origin->commit->object.oid))
-               do_diff_cache(&parent->tree->object.oid, &diff_opts);
+               do_diff_cache(get_commit_tree_oid(parent), &diff_opts);
        else
-               diff_tree_oid(&parent->tree->object.oid,
-                             &origin->commit->tree->object.oid,
+               diff_tree_oid(get_commit_tree_oid(parent),
+                             get_commit_tree_oid(origin->commit),
                              "", &diff_opts);
        diffcore_std(&diff_opts);
  
@@@ -1255,10 -1257,10 +1255,10 @@@ static void find_copy_in_parent(struct 
                diff_opts.flags.find_copies_harder = 1;
  
        if (is_null_oid(&target->commit->object.oid))
-               do_diff_cache(&parent->tree->object.oid, &diff_opts);
+               do_diff_cache(get_commit_tree_oid(parent), &diff_opts);
        else
-               diff_tree_oid(&parent->tree->object.oid,
-                             &target->commit->tree->object.oid,
+               diff_tree_oid(get_commit_tree_oid(parent),
+                             get_commit_tree_oid(target->commit),
                              "", &diff_opts);
  
        if (!diff_opts.flags.find_copies_harder)
@@@ -1829,8 -1831,8 +1829,8 @@@ void setup_scoreboard(struct blame_scor
                                    &sb->final_buf_size))
                        ;
                else
 -                      sb->final_buf = read_sha1_file(o->blob_oid.hash, &type,
 -                                                     &sb->final_buf_size);
 +                      sb->final_buf = read_object_file(&o->blob_oid, &type,
 +                                                       &sb->final_buf_size);
  
                if (!sb->final_buf)
                        die(_("cannot read blob %s for path %s"),
diff --combined builtin/checkout.c
index b49b5820718335ba6a70b70ef339ece7157281cc,4e803ae0921d78137ae69a04f910e420238fd420..2b3b768effd75e5d12d2c1828eb080f15c91895f
@@@ -66,7 -66,7 +66,7 @@@ static int post_checkout_hook(struct co
  
  }
  
 -static int update_some(const unsigned char *sha1, struct strbuf *base,
 +static int update_some(const struct object_id *oid, struct strbuf *base,
                const char *pathname, unsigned mode, int stage, void *context)
  {
        int len;
@@@ -78,7 -78,7 +78,7 @@@
  
        len = base->len + strlen(pathname);
        ce = xcalloc(1, cache_entry_size(len));
 -      hashcpy(ce->oid.hash, sha1);
 +      oidcpy(&ce->oid, oid);
        memcpy(ce->name, base->buf, base->len);
        memcpy(ce->name + base->len, pathname, len - base->len);
        ce->ce_flags = create_ce_flags(0) | CE_UPDATE;
@@@ -405,10 -405,10 +405,10 @@@ static void describe_detached_head(cons
                pp_commit_easy(CMIT_FMT_ONELINE, commit, &sb);
        if (print_sha1_ellipsis()) {
                fprintf(stderr, "%s %s... %s\n", msg,
 -                      find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV), sb.buf);
 +                      find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV), sb.buf);
        } else {
                fprintf(stderr, "%s %s %s\n", msg,
 -                      find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV), sb.buf);
 +                      find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV), sb.buf);
        }
        strbuf_release(&sb);
  }
@@@ -484,7 -484,8 +484,8 @@@ static int merge_working_tree(const str
  
        resolve_undo_clear();
        if (opts->force) {
-               ret = reset_tree(new_branch_info->commit->tree, opts, 1, writeout_error);
+               ret = reset_tree(get_commit_tree(new_branch_info->commit),
+                                opts, 1, writeout_error);
                if (ret)
                        return ret;
        } else {
                        o.verbosity = 0;
                        work = write_tree_from_memory(&o);
  
-                       ret = reset_tree(new_branch_info->commit->tree, opts, 1,
+                       ret = reset_tree(get_commit_tree(new_branch_info->commit),
+                                        opts, 1,
                                         writeout_error);
                        if (ret)
                                return ret;
                        o.ancestor = old_branch_info->name;
                        o.branch1 = new_branch_info->name;
                        o.branch2 = "local";
-                       ret = merge_trees(&o, new_branch_info->commit->tree, work,
-                               old_branch_info->commit->tree, &result);
+                       ret = merge_trees(&o,
+                                         get_commit_tree(new_branch_info->commit),
+                                         work,
+                                         get_commit_tree(old_branch_info->commit),
+                                         &result);
                        if (ret < 0)
                                exit(128);
-                       ret = reset_tree(new_branch_info->commit->tree, opts, 0,
+                       ret = reset_tree(get_commit_tree(new_branch_info->commit),
+                                        opts, 0,
                                         writeout_error);
                        strbuf_release(&o.obuf);
                        if (ret)
@@@ -609,7 -615,7 +615,7 @@@ static void report_tracking(struct bran
        struct strbuf sb = STRBUF_INIT;
        struct branch *branch = branch_get(new_branch_info->name);
  
 -      if (!format_tracking_info(branch, &sb))
 +      if (!format_tracking_info(branch, &sb, AHEAD_BEHIND_FULL))
                return;
        fputs(sb.buf, stdout);
        strbuf_release(&sb);
@@@ -720,7 -726,7 +726,7 @@@ static int add_pending_uninteresting_re
  static void describe_one_orphan(struct strbuf *sb, struct commit *commit)
  {
        strbuf_addstr(sb, "  ");
 -      strbuf_add_unique_abbrev(sb, commit->object.oid.hash, DEFAULT_ABBREV);
 +      strbuf_add_unique_abbrev(sb, &commit->object.oid, DEFAULT_ABBREV);
        strbuf_addch(sb, ' ');
        if (!parse_commit(commit))
                pp_commit_easy(CMIT_FMT_ONELINE, commit, sb);
@@@ -778,7 -784,7 +784,7 @@@ static void suggest_reattach(struct com
                        " git branch <new-branch-name> %s\n\n",
                        /* Give ngettext() the count */
                        lost),
 -                      find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV));
 +                      find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV));
  }
  
  /*
@@@ -1002,7 -1008,7 +1008,7 @@@ static int parse_branchname_arg(int arg
                *source_tree = parse_tree_indirect(rev);
        } else {
                parse_commit_or_die(new_branch_info->commit);
-               *source_tree = new_branch_info->commit->tree;
+               *source_tree = get_commit_tree(new_branch_info->commit);
        }
  
        if (!*source_tree)                   /* case (1): want a tree */
@@@ -1117,12 -1123,9 +1123,12 @@@ int cmd_checkout(int argc, const char *
                            2),
                OPT_SET_INT('3', "theirs", &opts.writeout_stage, N_("checkout their version for unmerged files"),
                            3),
 -              OPT__FORCE(&opts.force, N_("force checkout (throw away local modifications)")),
 +              OPT__FORCE(&opts.force, N_("force checkout (throw away local modifications)"),
 +                         PARSE_OPT_NOCOMPLETE),
                OPT_BOOL('m', "merge", &opts.merge, N_("perform a 3-way merge with the new branch")),
 -              OPT_BOOL(0, "overwrite-ignore", &opts.overwrite_ignore, N_("update ignored files (default)")),
 +              OPT_BOOL_F(0, "overwrite-ignore", &opts.overwrite_ignore,
 +                         N_("update ignored files (default)"),
 +                         PARSE_OPT_NOCOMPLETE),
                OPT_STRING(0, "conflict", &conflict_style, N_("style"),
                           N_("conflict style (merge or diff3)")),
                OPT_BOOL('p', "patch", &opts.patch_mode, N_("select hunks interactively")),
diff --combined builtin/fast-export.c
index 530df12f05be0e3331347d0a76306d0caa394744,c1304234cd6feb07960cea1b8ad6b60fc7d2bf04..ea776e602a9ec72648e48a749e45bed339e482ab
@@@ -237,10 -237,10 +237,10 @@@ static void export_blob(const struct ob
                object = (struct object *)lookup_blob(oid);
                eaten = 0;
        } else {
 -              buf = read_sha1_file(oid->hash, &type, &size);
 +              buf = read_object_file(oid, &type, &size);
                if (!buf)
                        die ("Could not read blob %s", oid_to_hex(oid));
 -              if (check_sha1_signature(oid->hash, buf, size, type_name(type)) < 0)
 +              if (check_object_signature(oid, buf, size, type_name(type)) < 0)
                        die("sha1 mismatch in blob %s", oid_to_hex(oid));
                object = parse_object_buffer(oid, type, size, buf, &eaten);
        }
@@@ -578,11 -578,11 +578,11 @@@ static void handle_commit(struct commi
            get_object_mark(&commit->parents->item->object) != 0 &&
            !full_tree) {
                parse_commit_or_die(commit->parents->item);
-               diff_tree_oid(&commit->parents->item->tree->object.oid,
-                             &commit->tree->object.oid, "", &rev->diffopt);
+               diff_tree_oid(get_commit_tree_oid(commit->parents->item),
+                             get_commit_tree_oid(commit), "", &rev->diffopt);
        }
        else
-               diff_root_tree_oid(&commit->tree->object.oid,
+               diff_root_tree_oid(get_commit_tree_oid(commit),
                                   "", &rev->diffopt);
  
        /* Export the referenced blobs, and remember the marks. */
@@@ -651,11 -651,8 +651,11 @@@ static void handle_tail(struct object_a
        struct commit *commit;
        while (commits->nr) {
                commit = (struct commit *)object_array_pop(commits);
 -              if (has_unshown_parent(commit))
 +              if (has_unshown_parent(commit)) {
 +                      /* Queue again, to be handled later */
 +                      add_object_array(&commit->object, NULL, commits);
                        return;
 +              }
                handle_commit(commit, revs, paths_of_changed_objects);
        }
  }
@@@ -685,7 -682,7 +685,7 @@@ static void handle_tag(const char *name
                return;
        }
  
 -      buf = read_sha1_file(tag->object.oid.hash, &type, &size);
 +      buf = read_object_file(&tag->object.oid, &type, &size);
        if (!buf)
                die ("Could not read tag %s", oid_to_hex(&tag->object.oid));
        message = memmem(buf, size, "\n\n", 2);
@@@ -950,7 -947,7 +950,7 @@@ static void import_marks(char *input_fi
                if (last_idnum < mark)
                        last_idnum = mark;
  
 -              type = sha1_object_info(oid.hash, NULL);
 +              type = oid_object_info(&oid, NULL);
                if (type < 0)
                        die("object not found: %s", oid_to_hex(&oid));
  
diff --combined builtin/log.c
index 71f68a3e4f59d987c653fb8f32a4d8770e9c6654,f4d30d2f3da84f9f18de4fbf16ada6f96c9cb836..75f7ff044178f58b9302d3e9f767986195307d94
@@@ -29,8 -29,6 +29,8 @@@
  #include "gpg-interface.h"
  #include "progress.h"
  
 +#define MAIL_DEFAULT_WRAP 72
 +
  /* Set a default date-time format for git log ("log.date" config variable) */
  static const char *default_date_mode = NULL;
  
@@@ -518,7 -516,7 +518,7 @@@ static int show_tag_object(const struc
  {
        unsigned long size;
        enum object_type type;
 -      char *buf = read_sha1_file(oid->hash, &type, &size);
 +      char *buf = read_object_file(oid, &type, &size);
        int offset = 0;
  
        if (!buf)
        return 0;
  }
  
 -static int show_tree_object(const unsigned char *sha1,
 +static int show_tree_object(const struct object_id *oid,
                struct strbuf *base,
                const char *pathname, unsigned mode, int stage, void *context)
  {
@@@ -1046,7 -1044,7 +1046,7 @@@ static void make_cover_letter(struct re
  
        shortlog_init(&log);
        log.wrap_lines = 1;
 -      log.wrap = 72;
 +      log.wrap = MAIL_DEFAULT_WRAP;
        log.in1 = 2;
        log.in2 = 4;
        log.file = rev->diffopt.file;
  
        memcpy(&opts, &rev->diffopt, sizeof(opts));
        opts.output_format = DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;
 +      opts.stat_width = MAIL_DEFAULT_WRAP;
  
        diff_setup_done(&opts);
  
-       diff_tree_oid(&origin->tree->object.oid,
-                     &head->tree->object.oid,
+       diff_tree_oid(get_commit_tree_oid(origin),
+                     get_commit_tree_oid(head),
                      "", &opts);
        diffcore_std(&opts);
        diff_flush(&opts);
@@@ -1617,8 -1614,6 +1617,8 @@@ int cmd_format_patch(int argc, const ch
                (!rev.diffopt.output_format ||
                 rev.diffopt.output_format == DIFF_FORMAT_PATCH))
                rev.diffopt.output_format = DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_SUMMARY;
 +      if (!rev.diffopt.stat_width)
 +              rev.diffopt.stat_width = MAIL_DEFAULT_WRAP;
  
        /* Always generate a patch */
        rev.diffopt.output_format |= DIFF_FORMAT_PATCH;
@@@ -1873,12 -1868,12 +1873,12 @@@ static void print_commit(char sign, str
  {
        if (!verbose) {
                fprintf(file, "%c %s\n", sign,
 -                     find_unique_abbrev(commit->object.oid.hash, abbrev));
 +                     find_unique_abbrev(&commit->object.oid, abbrev));
        } else {
                struct strbuf buf = STRBUF_INIT;
                pp_commit_easy(CMIT_FMT_ONELINE, commit, &buf);
                fprintf(file, "%c %s %s\n", sign,
 -                     find_unique_abbrev(commit->object.oid.hash, abbrev),
 +                     find_unique_abbrev(&commit->object.oid, abbrev),
                       buf.buf);
                strbuf_release(&buf);
        }
diff --combined builtin/reflog.c
index a89bd1dd25252ddfe5ad6b32ee89950d3a4b258f,1ce4276d313febc7e7dbdd58b4e51572b1e75174..a48984d37e4f5f9e1f07a840582f82e202bd09f0
@@@ -52,7 -52,6 +52,7 @@@ struct collect_reflog_cb 
        int nr;
  };
  
 +/* Remember to update object flag allocation in object.h */
  #define INCOMPLETE    (1u<<10)
  #define STUDYING      (1u<<11)
  #define REACHABLE     (1u<<12)
@@@ -75,7 -74,7 +75,7 @@@ static int tree_is_complete(const struc
        if (!tree->buffer) {
                enum object_type type;
                unsigned long size;
 -              void *data = read_sha1_file(oid->hash, &type, &size);
 +              void *data = read_object_file(oid, &type, &size);
                if (!data) {
                        tree->object.flags |= INCOMPLETE;
                        return 0;
@@@ -154,7 -153,7 +154,7 @@@ static int commit_is_complete(struct co
                for (i = 0; i < found.nr; i++) {
                        struct commit *c =
                                (struct commit *)found.objects[i].item;
-                       if (!tree_is_complete(&c->tree->object.oid)) {
+                       if (!tree_is_complete(get_commit_tree_oid(c))) {
                                is_incomplete = 1;
                                c->object.flags |= INCOMPLETE;
                        }
diff --combined commit-graph.c
index 3fc1e0da2768d3f209da08b6b4c71df133a3ec88,70fa1b25fd3d07a935cc0e7ba4cf70bc24ca3d21..3a183abd1ff4dee77bc342c706812f015fa5f437
@@@ -9,7 -9,6 +9,7 @@@
  #include "revision.h"
  #include "sha1-lookup.h"
  #include "commit-graph.h"
 +#include "object-store.h"
  
  #define GRAPH_SIGNATURE 0x43475048 /* "CGPH" */
  #define GRAPH_CHUNKID_OIDFANOUT 0x4f494446 /* "OIDF" */
@@@ -207,10 -206,8 +207,10 @@@ static void prepare_commit_graph(void
  
        obj_dir = get_object_directory();
        prepare_commit_graph_one(obj_dir);
 -      prepare_alt_odb();
 -      for (alt = alt_odb_list; !commit_graph && alt; alt = alt->next)
 +      prepare_alt_odb(the_repository);
 +      for (alt = the_repository->objects->alt_odb_list;
 +           !commit_graph && alt;
 +           alt = alt->next)
                prepare_commit_graph_one(alt->path);
  }
  
@@@ -250,7 -247,6 +250,6 @@@ static struct commit_list **insert_pare
  
  static int fill_commit_in_graph(struct commit *item, struct commit_graph *g, uint32_t pos)
  {
-       struct object_id oid;
        uint32_t edge_value;
        uint32_t *parent_data_ptr;
        uint64_t date_low, date_high;
        item->object.parsed = 1;
        item->graph_pos = pos;
  
-       hashcpy(oid.hash, commit_data);
-       item->tree = lookup_tree(&oid);
+       item->maybe_tree = NULL;
  
        date_high = get_be32(commit_data + g->hash_len + 8) & 0x3;
        date_low = get_be32(commit_data + g->hash_len + 12);
@@@ -320,6 -315,28 +318,28 @@@ int parse_commit_in_graph(struct commi
        return 0;
  }
  
+ static struct tree *load_tree_for_commit(struct commit_graph *g, struct commit *c)
+ {
+       struct object_id oid;
+       const unsigned char *commit_data = g->chunk_commit_data +
+                                          GRAPH_DATA_WIDTH * (c->graph_pos);
+       hashcpy(oid.hash, commit_data);
+       c->maybe_tree = lookup_tree(&oid);
+       return c->maybe_tree;
+ }
+ struct tree *get_commit_tree_in_graph(const struct commit *c)
+ {
+       if (c->maybe_tree)
+               return c->maybe_tree;
+       if (c->graph_pos == COMMIT_NOT_FROM_GRAPH)
+               BUG("get_commit_tree_in_graph called from non-commit-graph commit");
+       return load_tree_for_commit(commit_graph, (struct commit *)c);
+ }
  static void write_graph_chunk_fanout(struct hashfile *f,
                                     struct commit **commits,
                                     int nr_commits)
@@@ -372,7 -389,7 +392,7 @@@ static void write_graph_chunk_data(stru
                uint32_t packedDate[2];
  
                parse_commit(*list);
-               hashwrite(f, (*list)->tree->object.oid.hash, hash_len);
+               hashwrite(f, get_commit_tree_oid(*list)->hash, hash_len);
  
                parent = (*list)->parents;
  
diff --combined commit.c
index 57049118a5321ddeff53d7be94017ed17c5f336e,711f674c18d00c8d62b117764e67c5d9c6731616..1d7622b2ccaea0e30edada1f271f7ca3a694db2d
+++ b/commit.c
@@@ -267,7 -267,7 +267,7 @@@ const void *get_commit_buffer(const str
        if (!ret) {
                enum object_type type;
                unsigned long size;
 -              ret = read_sha1_file(commit->object.oid.hash, &type, &size);
 +              ret = read_object_file(&commit->object.oid, &type, &size);
                if (!ret)
                        die("cannot read commit object %s",
                            oid_to_hex(&commit->object.oid));
@@@ -296,6 -296,22 +296,22 @@@ void free_commit_buffer(struct commit *
        }
  }
  
+ struct tree *get_commit_tree(const struct commit *commit)
+ {
+       if (commit->maybe_tree || !commit->object.parsed)
+               return commit->maybe_tree;
+       if (commit->graph_pos == COMMIT_NOT_FROM_GRAPH)
+               BUG("commit has NULL tree, but was not loaded from commit-graph");
+       return get_commit_tree_in_graph(commit);
+ }
+ struct object_id *get_commit_tree_oid(const struct commit *commit)
+ {
+       return &get_commit_tree(commit)->object.oid;
+ }
  const void *detach_commit_buffer(struct commit *commit, unsigned long *sizep)
  {
        struct commit_buffer *v = buffer_slab_peek(&buffer_slab, commit);
@@@ -335,7 -351,7 +351,7 @@@ int parse_commit_buffer(struct commit *
        if (get_sha1_hex(bufptr + 5, parent.hash) < 0)
                return error("bad tree pointer in commit %s",
                             oid_to_hex(&item->object.oid));
-       item->tree = lookup_tree(&parent);
+       item->maybe_tree = lookup_tree(&parent);
        bufptr += tree_entry_len + 1; /* "tree " + "hex sha1" + "\n" */
        pptr = &item->parents;
  
@@@ -386,7 -402,7 +402,7 @@@ int parse_commit_gently(struct commit *
                return 0;
        if (parse_commit_in_graph(item))
                return 0;
 -      buffer = read_sha1_file(item->object.oid.hash, &type, &size);
 +      buffer = read_object_file(&item->object.oid, &type, &size);
        if (!buffer)
                return quiet_on_missing ? -1 :
                        error("Could not read %s",
@@@ -1209,7 -1225,7 +1225,7 @@@ static void handle_signed_tag(struct co
        desc = merge_remote_util(parent);
        if (!desc || !desc->obj)
                return;
 -      buf = read_sha1_file(desc->obj->oid.hash, &type, &size);
 +      buf = read_object_file(&desc->obj->oid, &type, &size);
        if (!buf || type != OBJ_TAG)
                goto free_return;
        len = parse_signature(buf, size);
@@@ -1520,7 -1536,7 +1536,7 @@@ int commit_tree_extended(const char *ms
        int encoding_is_utf8;
        struct strbuf buffer;
  
 -      assert_sha1_type(tree->hash, OBJ_TREE);
 +      assert_oid_type(tree, OBJ_TREE);
  
        if (memchr(msg, '\0', msg_len))
                return error("a NUL byte in commit log message not allowed.");
diff --combined fsck.c
index 9218c2a643b83e68b9f59479bcc1be833ae8be96,695fd71b1377191f0b5340f9831d6e738f35f712..640422a6c6b8b8f7439670e27c4eb110ef574525
--- 1/fsck.c
--- 2/fsck.c
+++ b/fsck.c
@@@ -396,9 -396,11 +396,11 @@@ static int fsck_walk_commit(struct comm
  
        name = get_object_name(options, &commit->object);
        if (name)
-               put_object_name(options, &commit->tree->object, "%s:", name);
+               put_object_name(options, &get_commit_tree(commit)->object,
+                               "%s:", name);
  
-       result = options->walk((struct object *)commit->tree, OBJ_TREE, data, options);
+       result = options->walk((struct object *)get_commit_tree(commit),
+                              OBJ_TREE, data, options);
        if (result < 0)
                return result;
        res = result;
@@@ -772,7 -774,7 +774,7 @@@ static int fsck_commit_buffer(struct co
        err = fsck_ident(&buffer, &commit->object, options);
        if (err)
                return err;
-       if (!commit->tree) {
+       if (!get_commit_tree(commit)) {
                err = report(options, &commit->object, FSCK_MSG_BAD_TREE, "could not load commit's tree %s", sha1_to_hex(tree_sha1));
                if (err)
                        return err;
@@@ -811,7 -813,7 +813,7 @@@ static int fsck_tag_buffer(struct tag *
                enum object_type type;
  
                buffer = to_free =
 -                      read_sha1_file(tag->object.oid.hash, &type, &size);
 +                      read_object_file(&tag->object.oid, &type, &size);
                if (!buffer)
                        return report(options, &tag->object,
                                FSCK_MSG_MISSING_TAG_OBJECT,
diff --combined http-push.c
index f308ce0195a5f0991996a3daad9b13809e8f7895,53a217291e5d66a1a6c4ef5c37f43d563604f6da..2669f4bfa1e2e47226f6e58084f35f4a64b21226
@@@ -6,13 -6,12 +6,13 @@@
  #include "refs.h"
  #include "diff.h"
  #include "revision.h"
 -#include "exec_cmd.h"
 +#include "exec-cmd.h"
  #include "remote.h"
  #include "list-objects.h"
  #include "sigchain.h"
  #include "argv-array.h"
  #include "packfile.h"
 +#include "object-store.h"
  
  #ifdef EXPAT_NEEDS_XMLPARSE_H
  #include <xmlparse.h>
@@@ -362,7 -361,7 +362,7 @@@ static void start_put(struct transfer_r
        ssize_t size;
        git_zstream stream;
  
 -      unpacked = read_sha1_file(request->obj->oid.hash, &type, &len);
 +      unpacked = read_object_file(&request->obj->oid, &type, &len);
        hdrlen = xsnprintf(hdr, sizeof(hdr), "%s %lu", type_name(type), len) + 1;
  
        /* Set it up */
@@@ -1331,7 -1330,7 +1331,7 @@@ static int get_delta(struct rev_info *r
        int count = 0;
  
        while ((commit = get_revision(revs)) != NULL) {
-               p = process_tree(commit->tree, p);
+               p = process_tree(get_commit_tree(commit), p);
                commit->object.flags |= LOCAL;
                if (!(commit->object.flags & UNINTERESTING))
                        count += add_send_request(&commit->object, lock);
diff --combined line-log.c
index ecdce08c4be24cc14109796d9a7c165c53753a88,437d44c00ae0b9f912e42c927fef7dadd240af34..fa9cfd5bdbb5dfe4a1ca5c7f7711435caf091805
@@@ -501,7 -501,8 +501,7 @@@ static void fill_blob_sha1(struct commi
        unsigned mode;
        struct object_id oid;
  
 -      if (get_tree_entry(commit->object.oid.hash, spec->path,
 -                         oid.hash, &mode))
 +      if (get_tree_entry(&commit->object.oid, spec->path, &oid, &mode))
                die("There is no path %s in the commit", spec->path);
        fill_filespec(spec, &oid, 1, mode);
  
@@@ -816,8 -817,8 +816,8 @@@ static void queue_diffs(struct line_log
        assert(commit);
  
        DIFF_QUEUE_CLEAR(&diff_queued_diff);
-       diff_tree_oid(parent ? &parent->tree->object.oid : NULL,
-                     &commit->tree->object.oid, "", opt);
+       diff_tree_oid(parent ? get_commit_tree_oid(parent) : NULL,
+                     get_commit_tree_oid(commit), "", opt);
        if (opt->detect_rename) {
                filter_diffs_for_paths(range, 1);
                if (diff_might_be_rename())
diff --combined log-tree.c
index d1c0bedf244fce0c8894175bf800384c0474b312,c106bd70df60e5bbdf5eb6da2186cdd897a5341f..2e6b486140f8e8591bd0c7564bcb4d4d507c330f
@@@ -177,7 -177,7 +177,7 @@@ static void show_parents(struct commit 
        struct commit_list *p;
        for (p = commit->parents; p ; p = p->next) {
                struct commit *parent = p->item;
 -              fprintf(file, " %s", find_unique_abbrev(parent->object.oid.hash, abbrev));
 +              fprintf(file, " %s", find_unique_abbrev(&parent->object.oid, abbrev));
        }
  }
  
@@@ -185,7 -185,7 +185,7 @@@ static void show_children(struct rev_in
  {
        struct commit_list *p = lookup_decoration(&opt->children, &commit->object);
        for ( ; p; p = p->next) {
 -              fprintf(opt->diffopt.file, " %s", find_unique_abbrev(p->item->object.oid.hash, abbrev));
 +              fprintf(opt->diffopt.file, " %s", find_unique_abbrev(&p->item->object.oid, abbrev));
        }
  }
  
@@@ -558,7 -558,7 +558,7 @@@ void show_log(struct rev_info *opt
  
                if (!opt->graph)
                        put_revision_mark(opt, commit);
 -              fputs(find_unique_abbrev(commit->object.oid.hash, abbrev_commit), opt->diffopt.file);
 +              fputs(find_unique_abbrev(&commit->object.oid, abbrev_commit), opt->diffopt.file);
                if (opt->print_parents)
                        show_parents(commit, abbrev_commit, opt->diffopt.file);
                if (opt->children.name)
  
                if (!opt->graph)
                        put_revision_mark(opt, commit);
 -              fputs(find_unique_abbrev(commit->object.oid.hash, abbrev_commit),
 +              fputs(find_unique_abbrev(&commit->object.oid,
 +                                       abbrev_commit),
                      opt->diffopt.file);
                if (opt->print_parents)
                        show_parents(commit, abbrev_commit, opt->diffopt.file);
                        show_children(opt, commit, abbrev_commit);
                if (parent)
                        fprintf(opt->diffopt.file, " (from %s)",
 -                             find_unique_abbrev(parent->object.oid.hash,
 -                                                abbrev_commit));
 +                             find_unique_abbrev(&parent->object.oid, abbrev_commit));
                fputs(diff_get_color_opt(&opt->diffopt, DIFF_RESET), opt->diffopt.file);
                show_decorations(opt, commit);
                if (opt->commit_format == CMIT_FMT_ONELINE) {
@@@ -806,7 -806,7 +806,7 @@@ static int log_tree_diff(struct rev_inf
                return 0;
  
        parse_commit_or_die(commit);
-       oid = &commit->tree->object.oid;
+       oid = get_commit_tree_oid(commit);
  
        /* Root commit? */
        parents = get_saved_parents(opt, commit);
                         * we merged _in_.
                         */
                        parse_commit_or_die(parents->item);
-                       diff_tree_oid(&parents->item->tree->object.oid,
+                       diff_tree_oid(get_commit_tree_oid(parents->item),
                                      oid, "", &opt->diffopt);
                        log_tree_diff_flush(opt);
                        return !opt->loginfo;
                struct commit *parent = parents->item;
  
                parse_commit_or_die(parent);
-               diff_tree_oid(&parent->tree->object.oid,
+               diff_tree_oid(get_commit_tree_oid(parent),
                              oid, "", &opt->diffopt);
                log_tree_diff_flush(opt);
  
diff --combined merge-recursive.c
index 0c0d48624da1d6162f0804e4a105841d965bb2c2,8de6e3652733860e3b63eaca9e4c1512fa3a19a3..0b690d4dcc42d2224f0c2fe775effdf4873b5363
@@@ -101,7 -101,7 +101,7 @@@ static struct commit *make_virtual_comm
        struct commit *commit = alloc_commit_node();
  
        set_merge_remote_desc(commit, comment, (struct object *)commit);
-       commit->tree = tree;
+       commit->maybe_tree = tree;
        commit->object.parsed = 1;
        return commit;
  }
@@@ -228,7 -228,7 +228,7 @@@ static void output_commit_title(struct 
                strbuf_addf(&o->obuf, "virtual %s\n",
                        merge_remote_util(commit)->name);
        else {
 -              strbuf_add_unique_abbrev(&o->obuf, commit->object.oid.hash,
 +              strbuf_add_unique_abbrev(&o->obuf, &commit->object.oid,
                                         DEFAULT_ABBREV);
                strbuf_addch(&o->obuf, ' ');
                if (parse_commit(commit) != 0)
@@@ -335,7 -335,7 +335,7 @@@ struct tree *write_tree_from_memory(str
        return result;
  }
  
 -static int save_files_dirs(const unsigned char *sha1,
 +static int save_files_dirs(const struct object_id *oid,
                struct strbuf *base, const char *path,
                unsigned int mode, int stage, void *context)
  {
@@@ -370,12 -370,12 +370,12 @@@ static struct stage_data *insert_stage_
  {
        struct string_list_item *item;
        struct stage_data *e = xcalloc(1, sizeof(struct stage_data));
 -      get_tree_entry(o->object.oid.hash, path,
 -                      e->stages[1].oid.hash, &e->stages[1].mode);
 -      get_tree_entry(a->object.oid.hash, path,
 -                      e->stages[2].oid.hash, &e->stages[2].mode);
 -      get_tree_entry(b->object.oid.hash, path,
 -                      e->stages[3].oid.hash, &e->stages[3].mode);
 +      get_tree_entry(&o->object.oid, path,
 +                      &e->stages[1].oid, &e->stages[1].mode);
 +      get_tree_entry(&a->object.oid, path,
 +                      &e->stages[2].oid, &e->stages[2].mode);
 +      get_tree_entry(&b->object.oid, path,
 +                      &e->stages[3].oid, &e->stages[3].mode);
        item = string_list_insert(entries, path);
        item->util = e;
        return e;
@@@ -842,7 -842,7 +842,7 @@@ static int update_file_flags(struct mer
                        goto update_index;
                }
  
 -              buf = read_sha1_file(oid->hash, &type, &size);
 +              buf = read_object_file(oid, &type, &size);
                if (!buf)
                        return err(o, _("cannot read object %s '%s'"), oid_to_hex(oid), path);
                if (type != OBJ_BLOB) {
@@@ -1656,7 -1656,7 +1656,7 @@@ static int read_oid_strbuf(struct merge
        void *buf;
        enum object_type type;
        unsigned long size;
 -      buf = read_sha1_file(oid->hash, &type, &size);
 +      buf = read_object_file(oid, &type, &size);
        if (!buf)
                return err(o, _("cannot read object %s"), oid_to_hex(oid));
        if (type != OBJ_BLOB) {
@@@ -2090,7 -2090,7 +2090,7 @@@ int merge_recursive(struct merge_option
  {
        struct commit_list *iter;
        struct commit *merged_common_ancestors;
 -      struct tree *mrtree = mrtree;
 +      struct tree *mrtree;
        int clean;
  
        if (show(o, 4)) {
                read_cache();
  
        o->ancestor = "merged common ancestors";
-       clean = merge_trees(o, h1->tree, h2->tree, merged_common_ancestors->tree,
+       clean = merge_trees(o, get_commit_tree(h1), get_commit_tree(h2),
+                           get_commit_tree(merged_common_ancestors),
                            &mrtree);
        if (clean < 0) {
                flush_output(o);
@@@ -2218,13 -2219,11 +2219,13 @@@ int merge_recursive_generic(struct merg
        hold_locked_index(&lock, LOCK_DIE_ON_ERROR);
        clean = merge_recursive(o, head_commit, next_commit, ca,
                        result);
 -      if (clean < 0)
 +      if (clean < 0) {
 +              rollback_lock_file(&lock);
                return clean;
 +      }
  
 -      if (active_cache_changed &&
 -          write_locked_index(&the_index, &lock, COMMIT_LOCK))
 +      if (write_locked_index(&the_index, &lock,
 +                             COMMIT_LOCK | SKIP_IF_UNCHANGED))
                return err(o, _("Unable to write index."));
  
        return clean ? 0 : 1;
diff --combined notes-merge.c
index 8e0726a9418e3b24bc8e665057f607e18e7d4206,4a73a2169be49d08ddab2f2821d12c14824f4803..e06d71ea47c00b9faf2d427752c6d3584df8c453
@@@ -322,7 -322,7 +322,7 @@@ static void write_note_to_worktree(cons
  {
        enum object_type type;
        unsigned long size;
 -      void *buf = read_sha1_file(note->hash, &type, &size);
 +      void *buf = read_object_file(note, &type, &size);
  
        if (!buf)
                die("cannot read note %s for object %s",
@@@ -600,14 -600,14 +600,14 @@@ int notes_merge(struct notes_merge_opti
                        printf("No merge base found; doing history-less merge\n");
        } else if (!bases->next) {
                base_oid = &bases->item->object.oid;
-               base_tree_oid = &bases->item->tree->object.oid;
+               base_tree_oid = get_commit_tree_oid(bases->item);
                if (o->verbosity >= 4)
                        printf("One merge base found (%.7s)\n",
                               oid_to_hex(base_oid));
        } else {
                /* TODO: How to handle multiple merge-bases? */
                base_oid = &bases->item->object.oid;
-               base_tree_oid = &bases->item->tree->object.oid;
+               base_tree_oid = get_commit_tree_oid(bases->item);
                if (o->verbosity >= 3)
                        printf("Multiple merge bases found. Using the first "
                                "(%.7s)\n", oid_to_hex(base_oid));
                goto found_result;
        }
  
-       result = merge_from_diffs(o, base_tree_oid, &local->tree->object.oid,
-                                 &remote->tree->object.oid, local_tree);
+       result = merge_from_diffs(o, base_tree_oid,
+                                 get_commit_tree_oid(local),
+                                 get_commit_tree_oid(remote), local_tree);
  
        if (result != 0) { /* non-trivial merge (with or without conflicts) */
                /* Commit (partial) result */
diff --combined packfile.c
index 6c3ddc3c31d008eb3817f21512815d89e37c4e1f,88ba8191518711d24fb42fdd2cd0bb3f70fd2397..bfe2385f2a2b43984449f0cd49e92ce5541c998c
@@@ -1,7 -1,6 +1,7 @@@
  #include "cache.h"
  #include "list.h"
  #include "pack.h"
 +#include "repository.h"
  #include "dir.h"
  #include "mergesort.h"
  #include "packfile.h"
@@@ -14,7 -13,6 +14,7 @@@
  #include "tag.h"
  #include "tree-walk.h"
  #include "tree.h"
 +#include "object-store.h"
  
  char *odb_pack_name(struct strbuf *buf,
                    const unsigned char *sha1,
@@@ -46,6 -44,8 +46,6 @@@ static unsigned int pack_open_fds
  static unsigned int pack_max_fds;
  static size_t peak_pack_mapped;
  static size_t pack_mapped;
 -struct packed_git *packed_git;
 -LIST_HEAD(packed_git_mru);
  
  #define SZ_FMT PRIuMAX
  static inline uintmax_t sz_fmt(size_t s) { return s; }
@@@ -245,7 -245,7 +245,7 @@@ static int unuse_one_window(struct pack
  
        if (current)
                scan_windows(current, &lru_p, &lru_w, &lru_l);
 -      for (p = packed_git; p; p = p->next)
 +      for (p = the_repository->objects->packed_git; p; p = p->next)
                scan_windows(p, &lru_p, &lru_w, &lru_l);
        if (lru_p) {
                munmap(lru_w->base, lru_w->len);
@@@ -311,11 -311,11 +311,11 @@@ void close_pack(struct packed_git *p
        close_pack_index(p);
  }
  
 -void close_all_packs(void)
 +void close_all_packs(struct raw_object_store *o)
  {
        struct packed_git *p;
  
 -      for (p = packed_git; p; p = p->next)
 +      for (p = o->packed_git; p; p = p->next)
                if (p->do_not_close)
                        die("BUG: want to close pack marked 'do-not-close'");
                else
@@@ -383,7 -383,7 +383,7 @@@ static int close_one_pack(void
        struct pack_window *mru_w = NULL;
        int accept_windows_inuse = 1;
  
 -      for (p = packed_git; p; p = p->next) {
 +      for (p = the_repository->objects->packed_git; p; p = p->next) {
                if (p->pack_fd == -1)
                        continue;
                find_lru_pack(p, &lru_p, &mru_w, &accept_windows_inuse);
@@@ -680,13 -680,13 +680,13 @@@ struct packed_git *add_packed_git(cons
        return p;
  }
  
 -void install_packed_git(struct packed_git *pack)
 +void install_packed_git(struct repository *r, struct packed_git *pack)
  {
        if (pack->pack_fd != -1)
                pack_open_fds++;
  
 -      pack->next = packed_git;
 -      packed_git = pack;
 +      pack->next = r->objects->packed_git;
 +      r->objects->packed_git = pack;
  }
  
  void (*report_garbage)(unsigned seen_bits, const char *path);
@@@ -735,7 -735,7 +735,7 @@@ static void report_pack_garbage(struct 
        report_helper(list, seen_bits, first, list->nr);
  }
  
 -static void prepare_packed_git_one(char *objdir, int local)
 +static void prepare_packed_git_one(struct repository *r, char *objdir, int local)
  {
        struct strbuf path = STRBUF_INIT;
        size_t dirnamelen;
                base_len = path.len;
                if (strip_suffix_mem(path.buf, &base_len, ".idx")) {
                        /* Don't reopen a pack we already have. */
 -                      for (p = packed_git; p; p = p->next) {
 +                      for (p = r->objects->packed_git; p;
 +                           p = p->next) {
                                size_t len;
                                if (strip_suffix(p->pack_name, ".pack", &len) &&
                                    len == base_len &&
                             * corresponding .pack file that we can map.
                             */
                            (p = add_packed_git(path.buf, path.len, local)) != NULL)
 -                              install_packed_git(p);
 +                              install_packed_git(r, p);
                }
  
                if (!report_garbage)
        strbuf_release(&path);
  }
  
 -static int approximate_object_count_valid;
 -
 +static void prepare_packed_git(struct repository *r);
  /*
   * Give a fast, rough count of the number of objects in the repository. This
   * ignores loose objects completely. If you have a lot of them, then either
   */
  unsigned long approximate_object_count(void)
  {
 -      static unsigned long count;
 -      if (!approximate_object_count_valid) {
 +      if (!the_repository->objects->approximate_object_count_valid) {
 +              unsigned long count;
                struct packed_git *p;
  
 -              prepare_packed_git();
 +              prepare_packed_git(the_repository);
                count = 0;
 -              for (p = packed_git; p; p = p->next) {
 +              for (p = the_repository->objects->packed_git; p; p = p->next) {
                        if (open_pack_index(p))
                                continue;
                        count += p->num_objects;
                }
 +              the_repository->objects->approximate_object_count = count;
        }
 -      return count;
 +      return the_repository->objects->approximate_object_count;
  }
  
  static void *get_next_packed_git(const void *p)
@@@ -867,55 -866,43 +867,55 @@@ static int sort_pack(const void *a_, co
        return -1;
  }
  
 -static void rearrange_packed_git(void)
 +static void rearrange_packed_git(struct repository *r)
  {
 -      packed_git = llist_mergesort(packed_git, get_next_packed_git,
 -                                   set_next_packed_git, sort_pack);
 +      r->objects->packed_git = llist_mergesort(
 +              r->objects->packed_git, get_next_packed_git,
 +              set_next_packed_git, sort_pack);
  }
  
 -static void prepare_packed_git_mru(void)
 +static void prepare_packed_git_mru(struct repository *r)
  {
        struct packed_git *p;
  
 -      INIT_LIST_HEAD(&packed_git_mru);
 +      INIT_LIST_HEAD(&r->objects->packed_git_mru);
  
 -      for (p = packed_git; p; p = p->next)
 -              list_add_tail(&p->mru, &packed_git_mru);
 +      for (p = r->objects->packed_git; p; p = p->next)
 +              list_add_tail(&p->mru, &r->objects->packed_git_mru);
  }
  
 -static int prepare_packed_git_run_once = 0;
 -void prepare_packed_git(void)
 +static void prepare_packed_git(struct repository *r)
  {
        struct alternate_object_database *alt;
  
 -      if (prepare_packed_git_run_once)
 +      if (r->objects->packed_git_initialized)
                return;
 -      prepare_packed_git_one(get_object_directory(), 1);
 -      prepare_alt_odb();
 -      for (alt = alt_odb_list; alt; alt = alt->next)
 -              prepare_packed_git_one(alt->path, 0);
 -      rearrange_packed_git();
 -      prepare_packed_git_mru();
 -      prepare_packed_git_run_once = 1;
 +      prepare_packed_git_one(r, r->objects->objectdir, 1);
 +      prepare_alt_odb(r);
 +      for (alt = r->objects->alt_odb_list; alt; alt = alt->next)
 +              prepare_packed_git_one(r, alt->path, 0);
 +      rearrange_packed_git(r);
 +      prepare_packed_git_mru(r);
 +      r->objects->packed_git_initialized = 1;
 +}
 +
 +void reprepare_packed_git(struct repository *r)
 +{
 +      r->objects->approximate_object_count_valid = 0;
 +      r->objects->packed_git_initialized = 0;
 +      prepare_packed_git(r);
 +}
 +
 +struct packed_git *get_packed_git(struct repository *r)
 +{
 +      prepare_packed_git(r);
 +      return r->objects->packed_git;
  }
  
 -void reprepare_packed_git(void)
 +struct list_head *get_packed_git_mru(struct repository *r)
  {
 -      approximate_object_count_valid = 0;
 -      prepare_packed_git_run_once = 0;
 -      prepare_packed_git();
 +      prepare_packed_git(r);
 +      return &r->objects->packed_git_mru;
  }
  
  unsigned long unpack_object_header_buffer(const unsigned char *buf,
@@@ -1026,7 -1013,7 +1026,7 @@@ const struct packed_git *has_packed_and
        struct packed_git *p;
        unsigned i;
  
 -      for (p = packed_git; p; p = p->next)
 +      for (p = the_repository->objects->packed_git; p; p = p->next)
                for (i = 0; i < p->num_bad_objects; i++)
                        if (!hashcmp(sha1, p->bad_object_sha1 + 20 * i))
                                return p;
@@@ -1108,13 -1095,13 +1108,13 @@@ static int retry_bad_packed_offset(stru
  {
        int type;
        struct revindex_entry *revidx;
 -      const unsigned char *sha1;
 +      struct object_id oid;
        revidx = find_pack_revindex(p, obj_offset);
        if (!revidx)
                return OBJ_BAD;
 -      sha1 = nth_packed_object_sha1(p, revidx->nr);
 -      mark_bad_packed_object(p, sha1);
 -      type = sha1_object_info(sha1, NULL);
 +      nth_packed_object_oid(&oid, p, revidx->nr);
 +      mark_bad_packed_object(p, oid.hash);
 +      type = oid_object_info(&oid, NULL);
        if (type <= OBJ_NONE)
                return OBJ_BAD;
        return type;
@@@ -1465,7 -1452,7 +1465,7 @@@ struct unpack_entry_stack_ent 
        unsigned long size;
  };
  
 -static void *read_object(const unsigned char *sha1, enum object_type *type,
 +static void *read_object(const struct object_id *oid, enum object_type *type,
                         unsigned long *size)
  {
        struct object_info oi = OBJECT_INFO_INIT;
        oi.sizep = size;
        oi.contentp = &content;
  
 -      if (sha1_object_info_extended(sha1, &oi, 0) < 0)
 +      if (oid_object_info_extended(oid, &oi, 0) < 0)
                return NULL;
        return content;
  }
@@@ -1514,11 -1501,11 +1514,11 @@@ void *unpack_entry(struct packed_git *p
                        struct revindex_entry *revidx = find_pack_revindex(p, obj_offset);
                        off_t len = revidx[1].offset - obj_offset;
                        if (check_pack_crc(p, &w_curs, obj_offset, len, revidx->nr)) {
 -                              const unsigned char *sha1 =
 -                                      nth_packed_object_sha1(p, revidx->nr);
 +                              struct object_id oid;
 +                              nth_packed_object_oid(&oid, p, revidx->nr);
                                error("bad packed object CRC for %s",
 -                                    sha1_to_hex(sha1));
 -                              mark_bad_packed_object(p, sha1);
 +                                    oid_to_hex(&oid));
 +                              mark_bad_packed_object(p, oid.hash);
                                data = NULL;
                                goto out;
                        }
                         * of a corrupted pack, and is better than failing outright.
                         */
                        struct revindex_entry *revidx;
 -                      const unsigned char *base_sha1;
 +                      struct object_id base_oid;
                        revidx = find_pack_revindex(p, obj_offset);
                        if (revidx) {
 -                              base_sha1 = nth_packed_object_sha1(p, revidx->nr);
 +                              nth_packed_object_oid(&base_oid, p, revidx->nr);
                                error("failed to read delta base object %s"
                                      " at offset %"PRIuMAX" from %s",
 -                                    sha1_to_hex(base_sha1), (uintmax_t)obj_offset,
 +                                    oid_to_hex(&base_oid), (uintmax_t)obj_offset,
                                      p->pack_name);
 -                              mark_bad_packed_object(p, base_sha1);
 -                              base = read_object(base_sha1, &type, &base_size);
 +                              mark_bad_packed_object(p, base_oid.hash);
 +                              base = read_object(&base_oid, &type, &base_size);
                                external_base = base;
                        }
                }
        return data;
  }
  
 +int bsearch_pack(const struct object_id *oid, const struct packed_git *p, uint32_t *result)
 +{
 +      const unsigned char *index_fanout = p->index_data;
 +      const unsigned char *index_lookup;
 +      int index_lookup_width;
 +
 +      if (!index_fanout)
 +              BUG("bsearch_pack called without a valid pack-index");
 +
 +      index_lookup = index_fanout + 4 * 256;
 +      if (p->index_version == 1) {
 +              index_lookup_width = 24;
 +              index_lookup += 4;
 +      } else {
 +              index_lookup_width = 20;
 +              index_fanout += 8;
 +              index_lookup += 8;
 +      }
 +
 +      return bsearch_hash(oid->hash, (const uint32_t*)index_fanout,
 +                          index_lookup, index_lookup_width, result);
 +}
 +
  const unsigned char *nth_packed_object_sha1(struct packed_git *p,
                                            uint32_t n)
  {
@@@ -1756,17 -1720,30 +1756,17 @@@ off_t nth_packed_object_offset(const st
  off_t find_pack_entry_one(const unsigned char *sha1,
                                  struct packed_git *p)
  {
 -      const uint32_t *level1_ofs = p->index_data;
        const unsigned char *index = p->index_data;
 -      unsigned stride;
 +      struct object_id oid;
        uint32_t result;
  
        if (!index) {
                if (open_pack_index(p))
                        return 0;
 -              level1_ofs = p->index_data;
 -              index = p->index_data;
 -      }
 -      if (p->index_version > 1) {
 -              level1_ofs += 2;
 -              index += 8;
 -      }
 -      index += 4 * 256;
 -      if (p->index_version > 1) {
 -              stride = 20;
 -      } else {
 -              stride = 24;
 -              index += 4;
        }
  
 -      if (bsearch_hash(sha1, level1_ofs, index, stride, &result))
 +      hashcpy(oid.hash, sha1);
 +      if (bsearch_pack(&oid, p, &result))
                return nth_packed_object_offset(p, result);
        return 0;
  }
@@@ -1837,18 -1814,22 +1837,18 @@@ static int fill_pack_entry(const unsign
        return 1;
  }
  
 -/*
 - * Iff a pack file contains the object named by sha1, return true and
 - * store its location to e.
 - */
 -int find_pack_entry(const unsigned char *sha1, struct pack_entry *e)
 +int find_pack_entry(struct repository *r, const unsigned char *sha1, struct pack_entry *e)
  {
        struct list_head *pos;
  
 -      prepare_packed_git();
 -      if (!packed_git)
 +      prepare_packed_git(r);
 +      if (!r->objects->packed_git)
                return 0;
  
 -      list_for_each(pos, &packed_git_mru) {
 +      list_for_each(pos, &r->objects->packed_git_mru) {
                struct packed_git *p = list_entry(pos, struct packed_git, mru);
                if (fill_pack_entry(sha1, e, p)) {
 -                      list_move(&p->mru, &packed_git_mru);
 +                      list_move(&p->mru, &r->objects->packed_git_mru);
                        return 1;
                }
        }
  int has_sha1_pack(const unsigned char *sha1)
  {
        struct pack_entry e;
 -      return find_pack_entry(sha1, &e);
 +      return find_pack_entry(the_repository, sha1, &e);
  }
  
  int has_pack_index(const unsigned char *sha1)
@@@ -1894,8 -1875,8 +1894,8 @@@ int for_each_packed_object(each_packed_
        int r = 0;
        int pack_errors = 0;
  
 -      prepare_packed_git();
 -      for (p = packed_git; p; p = p->next) {
 +      prepare_packed_git(the_repository);
 +      for (p = the_repository->objects->packed_git; p; p = p->next) {
                if ((flags & FOR_EACH_OBJECT_LOCAL_ONLY) && !p->pack_local)
                        continue;
                if ((flags & FOR_EACH_OBJECT_PROMISOR_ONLY) &&
@@@ -1926,7 -1907,7 +1926,7 @@@ static int add_promisor_object(const st
  
        /*
         * If this is a tree, commit, or tag, the objects it refers
 -       * to are also promisor objects. (Blobs refer to no objects.)
 +       * to are also promisor objects. (Blobs refer to no objects->)
         */
        if (obj->type == OBJ_TREE) {
                struct tree *tree = (struct tree *)obj;
                struct commit *commit = (struct commit *) obj;
                struct commit_list *parents = commit->parents;
  
-               oidset_insert(set, &commit->tree->object.oid);
+               oidset_insert(set, get_commit_tree_oid(commit));
                for (; parents; parents = parents->next)
                        oidset_insert(set, &parents->item->object.oid);
        } else if (obj->type == OBJ_TAG) {
diff --combined pretty.c
index 34fe891fc03672fa042257e4d32630882868eadf,15997f5e0186c0623de36ab3542dbcbaea1fa47b..703fa6ff7bf297e9d0dd91586f951f715032e06a
+++ b/pretty.c
@@@ -549,7 -549,7 +549,7 @@@ static void add_merge_info(const struc
                struct object_id *oidp = &parent->item->object.oid;
                strbuf_addch(sb, ' ');
                if (pp->abbrev)
 -                      strbuf_add_unique_abbrev(sb, oidp->hash, pp->abbrev);
 +                      strbuf_add_unique_abbrev(sb, oidp, pp->abbrev);
                else
                        strbuf_addstr(sb, oid_to_hex(oidp));
                parent = parent->next;
@@@ -1156,15 -1156,16 +1156,16 @@@ static size_t format_commit_one(struct 
                return 1;
        case 'h':               /* abbreviated commit hash */
                strbuf_addstr(sb, diff_get_color(c->auto_color, DIFF_COMMIT));
 -              strbuf_add_unique_abbrev(sb, commit->object.oid.hash,
 +              strbuf_add_unique_abbrev(sb, &commit->object.oid,
                                         c->pretty_ctx->abbrev);
                strbuf_addstr(sb, diff_get_color(c->auto_color, DIFF_RESET));
                return 1;
        case 'T':               /* tree hash */
-               strbuf_addstr(sb, oid_to_hex(&commit->tree->object.oid));
+               strbuf_addstr(sb, oid_to_hex(get_commit_tree_oid(commit)));
                return 1;
        case 't':               /* abbreviated tree hash */
-               strbuf_add_unique_abbrev(sb, &commit->tree->object.oid,
+               strbuf_add_unique_abbrev(sb,
 -                                       get_commit_tree_oid(commit)->hash,
++                                       get_commit_tree_oid(commit),
                                         c->pretty_ctx->abbrev);
                return 1;
        case 'P':               /* parent hashes */
                for (p = commit->parents; p; p = p->next) {
                        if (p != commit->parents)
                                strbuf_addch(sb, ' ');
 -                      strbuf_add_unique_abbrev(sb, p->item->object.oid.hash,
 +                      strbuf_add_unique_abbrev(sb, &p->item->object.oid,
                                                 c->pretty_ctx->abbrev);
                }
                return 1;
diff --combined ref-filter.c
index 39e2744c949bb7c4ffbcb7c7e08d3757a6b732de,cffd8bf3ce72abfcc9ef9ca1fa3f968c69539695..dba826e71803d44d648ecdcf793bd01e55ecb830
@@@ -101,38 -101,22 +101,38 @@@ static struct used_atom 
  } *used_atom;
  static int used_atom_cnt, need_tagged, need_symref;
  
 -static void color_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *color_value)
 +/*
 + * Expand string, append it to strbuf *sb, then return error code ret.
 + * Allow to save few lines of code.
 + */
 +static int strbuf_addf_ret(struct strbuf *sb, int ret, const char *fmt, ...)
 +{
 +      va_list ap;
 +      va_start(ap, fmt);
 +      strbuf_vaddf(sb, fmt, ap);
 +      va_end(ap);
 +      return ret;
 +}
 +
 +static int color_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                           const char *color_value, struct strbuf *err)
  {
        if (!color_value)
 -              die(_("expected format: %%(color:<color>)"));
 +              return strbuf_addf_ret(err, -1, _("expected format: %%(color:<color>)"));
        if (color_parse(color_value, atom->u.color) < 0)
 -              die(_("unrecognized color: %%(color:%s)"), color_value);
 +              return strbuf_addf_ret(err, -1, _("unrecognized color: %%(color:%s)"),
 +                                     color_value);
        /*
         * We check this after we've parsed the color, which lets us complain
         * about syntactically bogus color names even if they won't be used.
         */
        if (!want_color(format->use_color))
                color_parse("", atom->u.color);
 +      return 0;
  }
  
 -static void refname_atom_parser_internal(struct refname_atom *atom,
 -                                       const char *arg, const char *name)
 +static int refname_atom_parser_internal(struct refname_atom *atom, const char *arg,
 +                                       const char *name, struct strbuf *err)
  {
        if (!arg)
                atom->option = R_NORMAL;
                 skip_prefix(arg, "strip=", &arg)) {
                atom->option = R_LSTRIP;
                if (strtol_i(arg, 10, &atom->lstrip))
 -                      die(_("Integer value expected refname:lstrip=%s"), arg);
 +                      return strbuf_addf_ret(err, -1, _("Integer value expected refname:lstrip=%s"), arg);
        } else if (skip_prefix(arg, "rstrip=", &arg)) {
                atom->option = R_RSTRIP;
                if (strtol_i(arg, 10, &atom->rstrip))
 -                      die(_("Integer value expected refname:rstrip=%s"), arg);
 +                      return strbuf_addf_ret(err, -1, _("Integer value expected refname:rstrip=%s"), arg);
        } else
 -              die(_("unrecognized %%(%s) argument: %s"), name, arg);
 +              return strbuf_addf_ret(err, -1, _("unrecognized %%(%s) argument: %s"), name, arg);
 +      return 0;
  }
  
 -static void remote_ref_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int remote_ref_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                                const char *arg, struct strbuf *err)
  {
        struct string_list params = STRING_LIST_INIT_DUP;
        int i;
  
        if (!arg) {
                atom->u.remote_ref.option = RR_REF;
 -              refname_atom_parser_internal(&atom->u.remote_ref.refname,
 -                                           arg, atom->name);
 -              return;
 +              return refname_atom_parser_internal(&atom->u.remote_ref.refname,
 +                                                  arg, atom->name, err);
        }
  
        atom->u.remote_ref.nobracket = 0;
                        atom->u.remote_ref.push_remote = 1;
                } else {
                        atom->u.remote_ref.option = RR_REF;
 -                      refname_atom_parser_internal(&atom->u.remote_ref.refname,
 -                                                   arg, atom->name);
 +                      if (refname_atom_parser_internal(&atom->u.remote_ref.refname,
 +                                                       arg, atom->name, err)) {
 +                              string_list_clear(&params, 0);
 +                              return -1;
 +                      }
                }
        }
  
        string_list_clear(&params, 0);
 +      return 0;
  }
  
 -static void body_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int body_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                          const char *arg, struct strbuf *err)
  {
        if (arg)
 -              die(_("%%(body) does not take arguments"));
 +              return strbuf_addf_ret(err, -1, _("%%(body) does not take arguments"));
        atom->u.contents.option = C_BODY_DEP;
 +      return 0;
  }
  
 -static void subject_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int subject_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                             const char *arg, struct strbuf *err)
  {
        if (arg)
 -              die(_("%%(subject) does not take arguments"));
 +              return strbuf_addf_ret(err, -1, _("%%(subject) does not take arguments"));
        atom->u.contents.option = C_SUB;
 +      return 0;
  }
  
 -static void trailers_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int trailers_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                              const char *arg, struct strbuf *err)
  {
        struct string_list params = STRING_LIST_INIT_DUP;
        int i;
                                atom->u.contents.trailer_opts.unfold = 1;
                        else if (!strcmp(s, "only"))
                                atom->u.contents.trailer_opts.only_trailers = 1;
 -                      else
 -                              die(_("unknown %%(trailers) argument: %s"), s);
 +                      else {
 +                              strbuf_addf(err, _("unknown %%(trailers) argument: %s"), s);
 +                              string_list_clear(&params, 0);
 +                              return -1;
 +                      }
                }
        }
        atom->u.contents.option = C_TRAILERS;
        string_list_clear(&params, 0);
 +      return 0;
  }
  
 -static void contents_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int contents_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                              const char *arg, struct strbuf *err)
  {
        if (!arg)
                atom->u.contents.option = C_BARE;
                atom->u.contents.option = C_SUB;
        else if (skip_prefix(arg, "trailers", &arg)) {
                skip_prefix(arg, ":", &arg);
 -              trailers_atom_parser(format, atom, *arg ? arg : NULL);
 +              if (trailers_atom_parser(format, atom, *arg ? arg : NULL, err))
 +                      return -1;
        } else if (skip_prefix(arg, "lines=", &arg)) {
                atom->u.contents.option = C_LINES;
                if (strtoul_ui(arg, 10, &atom->u.contents.nlines))
 -                      die(_("positive value expected contents:lines=%s"), arg);
 +                      return strbuf_addf_ret(err, -1, _("positive value expected contents:lines=%s"), arg);
        } else
 -              die(_("unrecognized %%(contents) argument: %s"), arg);
 +              return strbuf_addf_ret(err, -1, _("unrecognized %%(contents) argument: %s"), arg);
 +      return 0;
  }
  
 -static void objectname_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int objectname_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                                const char *arg, struct strbuf *err)
  {
        if (!arg)
                atom->u.objectname.option = O_FULL;
                atom->u.objectname.option = O_LENGTH;
                if (strtoul_ui(arg, 10, &atom->u.objectname.length) ||
                    atom->u.objectname.length == 0)
 -                      die(_("positive value expected objectname:short=%s"), arg);
 +                      return strbuf_addf_ret(err, -1, _("positive value expected objectname:short=%s"), arg);
                if (atom->u.objectname.length < MINIMUM_ABBREV)
                        atom->u.objectname.length = MINIMUM_ABBREV;
        } else
 -              die(_("unrecognized %%(objectname) argument: %s"), arg);
 +              return strbuf_addf_ret(err, -1, _("unrecognized %%(objectname) argument: %s"), arg);
 +      return 0;
  }
  
 -static void refname_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int refname_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                             const char *arg, struct strbuf *err)
  {
 -      refname_atom_parser_internal(&atom->u.refname, arg, atom->name);
 +      return refname_atom_parser_internal(&atom->u.refname, arg, atom->name, err);
  }
  
  static align_type parse_align_position(const char *s)
        return -1;
  }
  
 -static void align_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int align_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                           const char *arg, struct strbuf *err)
  {
        struct align *align = &atom->u.align;
        struct string_list params = STRING_LIST_INIT_DUP;
        unsigned int width = ~0U;
  
        if (!arg)
 -              die(_("expected format: %%(align:<width>,<position>)"));
 +              return strbuf_addf_ret(err, -1, _("expected format: %%(align:<width>,<position>)"));
  
        align->position = ALIGN_LEFT;
  
  
                if (skip_prefix(s, "position=", &s)) {
                        position = parse_align_position(s);
 -                      if (position < 0)
 -                              die(_("unrecognized position:%s"), s);
 +                      if (position < 0) {
 +                              strbuf_addf(err, _("unrecognized position:%s"), s);
 +                              string_list_clear(&params, 0);
 +                              return -1;
 +                      }
                        align->position = position;
                } else if (skip_prefix(s, "width=", &s)) {
 -                      if (strtoul_ui(s, 10, &width))
 -                              die(_("unrecognized width:%s"), s);
 +                      if (strtoul_ui(s, 10, &width)) {
 +                              strbuf_addf(err, _("unrecognized width:%s"), s);
 +                              string_list_clear(&params, 0);
 +                              return -1;
 +                      }
                } else if (!strtoul_ui(s, 10, &width))
                        ;
                else if ((position = parse_align_position(s)) >= 0)
                        align->position = position;
 -              else
 -                      die(_("unrecognized %%(align) argument: %s"), s);
 +              else {
 +                      strbuf_addf(err, _("unrecognized %%(align) argument: %s"), s);
 +                      string_list_clear(&params, 0);
 +                      return -1;
 +              }
        }
  
 -      if (width == ~0U)
 -              die(_("positive width expected with the %%(align) atom"));
 +      if (width == ~0U) {
 +              string_list_clear(&params, 0);
 +              return strbuf_addf_ret(err, -1, _("positive width expected with the %%(align) atom"));
 +      }
        align->width = width;
        string_list_clear(&params, 0);
 +      return 0;
  }
  
 -static void if_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int if_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                        const char *arg, struct strbuf *err)
  {
        if (!arg) {
                atom->u.if_then_else.cmp_status = COMPARE_NONE;
 -              return;
 +              return 0;
        } else if (skip_prefix(arg, "equals=", &atom->u.if_then_else.str)) {
                atom->u.if_then_else.cmp_status = COMPARE_EQUAL;
        } else if (skip_prefix(arg, "notequals=", &atom->u.if_then_else.str)) {
                atom->u.if_then_else.cmp_status = COMPARE_UNEQUAL;
 -      } else {
 -              die(_("unrecognized %%(if) argument: %s"), arg);
 -      }
 +      } else
 +              return strbuf_addf_ret(err, -1, _("unrecognized %%(if) argument: %s"), arg);
 +      return 0;
  }
  
 -static void head_atom_parser(const struct ref_format *format, struct used_atom *atom, const char *arg)
 +static int head_atom_parser(const struct ref_format *format, struct used_atom *atom,
 +                          const char *arg, struct strbuf *unused_err)
  {
        atom->u.head = resolve_refdup("HEAD", RESOLVE_REF_READING, NULL, NULL);
 +      return 0;
  }
  
  static struct {
        const char *name;
        cmp_type cmp_type;
 -      void (*parser)(const struct ref_format *format, struct used_atom *atom, const char *arg);
 +      int (*parser)(const struct ref_format *format, struct used_atom *atom,
 +                    const char *arg, struct strbuf *err);
  } valid_atom[] = {
        { "refname" , FIELD_STR, refname_atom_parser },
        { "objecttype" },
@@@ -440,8 -387,7 +440,8 @@@ struct ref_formatting_state 
  
  struct atom_value {
        const char *s;
 -      void (*handler)(struct atom_value *atomv, struct ref_formatting_state *state);
 +      int (*handler)(struct atom_value *atomv, struct ref_formatting_state *state,
 +                     struct strbuf *err);
        uintmax_t value; /* used for sorting when not FIELD_STR */
        struct used_atom *atom;
  };
   * Used to parse format string and sort specifiers
   */
  static int parse_ref_filter_atom(const struct ref_format *format,
 -                               const char *atom, const char *ep)
 +                               const char *atom, const char *ep,
 +                               struct strbuf *err)
  {
        const char *sp;
        const char *arg;
        if (*sp == '*' && sp < ep)
                sp++; /* deref */
        if (ep <= sp)
 -              die(_("malformed field name: %.*s"), (int)(ep-atom), atom);
 +              return strbuf_addf_ret(err, -1, _("malformed field name: %.*s"),
 +                                     (int)(ep-atom), atom);
  
        /* Do we have the atom already used elsewhere? */
        for (i = 0; i < used_atom_cnt; i++) {
        }
  
        if (ARRAY_SIZE(valid_atom) <= i)
 -              die(_("unknown field name: %.*s"), (int)(ep-atom), atom);
 +              return strbuf_addf_ret(err, -1, _("unknown field name: %.*s"),
 +                                     (int)(ep-atom), atom);
  
        /* Add it in, including the deref prefix */
        at = used_atom_cnt;
                }
        }
        memset(&used_atom[at].u, 0, sizeof(used_atom[at].u));
 -      if (valid_atom[i].parser)
 -              valid_atom[i].parser(format, &used_atom[at], arg);
 +      if (valid_atom[i].parser && valid_atom[i].parser(format, &used_atom[at], arg, err))
 +              return -1;
        if (*atom == '*')
                need_tagged = 1;
        if (!strcmp(valid_atom[i].name, "symref"))
@@@ -538,8 -481,7 +538,8 @@@ static void quote_formatting(struct str
        }
  }
  
 -static void append_atom(struct atom_value *v, struct ref_formatting_state *state)
 +static int append_atom(struct atom_value *v, struct ref_formatting_state *state,
 +                     struct strbuf *unused_err)
  {
        /*
         * Quote formatting is only done when the stack has a single
                quote_formatting(&state->stack->output, v->s, state->quote_style);
        else
                strbuf_addstr(&state->stack->output, v->s);
 +      return 0;
  }
  
  static void push_stack_element(struct ref_formatting_stack **stack)
@@@ -586,8 -527,7 +586,8 @@@ static void end_align_handler(struct re
        strbuf_release(&s);
  }
  
 -static void align_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state)
 +static int align_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state,
 +                            struct strbuf *unused_err)
  {
        struct ref_formatting_stack *new_stack;
  
        new_stack = state->stack;
        new_stack->at_end = end_align_handler;
        new_stack->at_end_data = &atomv->atom->u.align;
 +      return 0;
  }
  
  static void if_then_else_handler(struct ref_formatting_stack **stack)
        free(if_then_else);
  }
  
 -static void if_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state)
 +static int if_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state,
 +                         struct strbuf *unused_err)
  {
        struct ref_formatting_stack *new_stack;
        struct if_then_else *if_then_else = xcalloc(sizeof(struct if_then_else), 1);
        new_stack = state->stack;
        new_stack->at_end = if_then_else_handler;
        new_stack->at_end_data = if_then_else;
 +      return 0;
  }
  
  static int is_empty(const char *s)
        return 1;
  }
  
 -static void then_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state)
 +static int then_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state,
 +                           struct strbuf *err)
  {
        struct ref_formatting_stack *cur = state->stack;
        struct if_then_else *if_then_else = NULL;
        if (cur->at_end == if_then_else_handler)
                if_then_else = (struct if_then_else *)cur->at_end_data;
        if (!if_then_else)
 -              die(_("format: %%(then) atom used without an %%(if) atom"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(then) atom used without an %%(if) atom"));
        if (if_then_else->then_atom_seen)
 -              die(_("format: %%(then) atom used more than once"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(then) atom used more than once"));
        if (if_then_else->else_atom_seen)
 -              die(_("format: %%(then) atom used after %%(else)"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(then) atom used after %%(else)"));
        if_then_else->then_atom_seen = 1;
        /*
         * If the 'equals' or 'notequals' attribute is used then
        } else if (cur->output.len && !is_empty(cur->output.buf))
                if_then_else->condition_satisfied = 1;
        strbuf_reset(&cur->output);
 +      return 0;
  }
  
 -static void else_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state)
 +static int else_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state,
 +                           struct strbuf *err)
  {
        struct ref_formatting_stack *prev = state->stack;
        struct if_then_else *if_then_else = NULL;
        if (prev->at_end == if_then_else_handler)
                if_then_else = (struct if_then_else *)prev->at_end_data;
        if (!if_then_else)
 -              die(_("format: %%(else) atom used without an %%(if) atom"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(else) atom used without an %%(if) atom"));
        if (!if_then_else->then_atom_seen)
 -              die(_("format: %%(else) atom used without a %%(then) atom"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(else) atom used without a %%(then) atom"));
        if (if_then_else->else_atom_seen)
 -              die(_("format: %%(else) atom used more than once"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(else) atom used more than once"));
        if_then_else->else_atom_seen = 1;
        push_stack_element(&state->stack);
        state->stack->at_end_data = prev->at_end_data;
        state->stack->at_end = prev->at_end;
 +      return 0;
  }
  
 -static void end_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state)
 +static int end_atom_handler(struct atom_value *atomv, struct ref_formatting_state *state,
 +                          struct strbuf *err)
  {
        struct ref_formatting_stack *current = state->stack;
        struct strbuf s = STRBUF_INIT;
  
        if (!current->at_end)
 -              die(_("format: %%(end) atom used without corresponding atom"));
 +              return strbuf_addf_ret(err, -1, _("format: %%(end) atom used without corresponding atom"));
        current->at_end(&state->stack);
  
        /*  Stack may have been popped within at_end(), hence reset the current pointer */
        }
        strbuf_release(&s);
        pop_stack_element(&state->stack);
 +      return 0;
  }
  
  /*
@@@ -771,21 -702,17 +771,21 @@@ int verify_ref_format(struct ref_forma
  
        format->need_color_reset_at_eol = 0;
        for (cp = format->format; *cp && (sp = find_next(cp)); ) {
 +              struct strbuf err = STRBUF_INIT;
                const char *color, *ep = strchr(sp, ')');
                int at;
  
                if (!ep)
                        return error(_("malformed format string %s"), sp);
                /* sp points at "%(" and ep points at the closing ")" */
 -              at = parse_ref_filter_atom(format, sp + 2, ep);
 +              at = parse_ref_filter_atom(format, sp + 2, ep, &err);
 +              if (at < 0)
 +                      die("%s", err.buf);
                cp = ep + 1;
  
                if (skip_prefix(used_atom[at].name, "color:", &color))
                        format->need_color_reset_at_eol = !!strcmp(color, "reset");
 +              strbuf_release(&err);
        }
        if (format->need_color_reset_at_eol && !want_color(format->use_color))
                format->need_color_reset_at_eol = 0;
  static void *get_obj(const struct object_id *oid, struct object **obj, unsigned long *sz, int *eaten)
  {
        enum object_type type;
 -      void *buf = read_sha1_file(oid->hash, &type, sz);
 +      void *buf = read_object_file(oid, &type, sz);
  
        if (buf)
                *obj = parse_object_buffer(oid, type, *sz, buf, eaten);
        return buf;
  }
  
 -static int grab_objectname(const char *name, const unsigned char *sha1,
 +static int grab_objectname(const char *name, const struct object_id *oid,
                           struct atom_value *v, struct used_atom *atom)
  {
        if (starts_with(name, "objectname")) {
                if (atom->u.objectname.option == O_SHORT) {
 -                      v->s = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV));
 +                      v->s = xstrdup(find_unique_abbrev(oid, DEFAULT_ABBREV));
                        return 1;
                } else if (atom->u.objectname.option == O_FULL) {
 -                      v->s = xstrdup(sha1_to_hex(sha1));
 +                      v->s = xstrdup(oid_to_hex(oid));
                        return 1;
                } else if (atom->u.objectname.option == O_LENGTH) {
 -                      v->s = xstrdup(find_unique_abbrev(sha1, atom->u.objectname.length));
 +                      v->s = xstrdup(find_unique_abbrev(oid, atom->u.objectname.length));
                        return 1;
                } else
                        die("BUG: unknown %%(objectname) option");
@@@ -848,7 -775,7 +848,7 @@@ static void grab_common_values(struct a
                        v->s = xstrfmt("%lu", sz);
                }
                else if (deref)
 -                      grab_objectname(name, obj->oid.hash, v, &used_atom[i]);
 +                      grab_objectname(name, &obj->oid, v, &used_atom[i]);
        }
  }
  
@@@ -888,7 -815,7 +888,7 @@@ static void grab_commit_values(struct a
                if (deref)
                        name++;
                if (!strcmp(name, "tree")) {
-                       v->s = xstrdup(oid_to_hex(&commit->tree->object.oid));
+                       v->s = xstrdup(oid_to_hex(get_commit_tree_oid(commit)));
                }
                else if (!strcmp(name, "numparent")) {
                        v->value = commit_list_count(commit->parents);
@@@ -1322,8 -1249,8 +1322,8 @@@ static void fill_remote_ref_details(str
        if (atom->u.remote_ref.option == RR_REF)
                *s = show_ref(&atom->u.remote_ref.refname, refname);
        else if (atom->u.remote_ref.option == RR_TRACK) {
 -              if (stat_tracking_info(branch, &num_ours,
 -                                     &num_theirs, NULL)) {
 +              if (stat_tracking_info(branch, &num_ours, &num_theirs,
 +                                     NULL, AHEAD_BEHIND_FULL) < 0) {
                        *s = xstrdup(msgs.gone);
                } else if (!num_ours && !num_theirs)
                        *s = "";
                        free((void *)to_free);
                }
        } else if (atom->u.remote_ref.option == RR_TRACKSHORT) {
 -              if (stat_tracking_info(branch, &num_ours,
 -                                     &num_theirs, NULL))
 +              if (stat_tracking_info(branch, &num_ours, &num_theirs,
 +                                     NULL, AHEAD_BEHIND_FULL) < 0)
                        return;
  
                if (!num_ours && !num_theirs)
@@@ -1382,14 -1309,10 +1382,14 @@@ char *get_head_description(void
        memset(&state, 0, sizeof(state));
        wt_status_get_state(&state, 1);
        if (state.rebase_in_progress ||
 -          state.rebase_interactive_in_progress)
 -              strbuf_addf(&desc, _("(no branch, rebasing %s)"),
 -                          state.branch);
 -      else if (state.bisect_in_progress)
 +          state.rebase_interactive_in_progress) {
 +              if (state.branch)
 +                      strbuf_addf(&desc, _("(no branch, rebasing %s)"),
 +                                  state.branch);
 +              else
 +                      strbuf_addf(&desc, _("(no branch, rebasing detached HEAD %s)"),
 +                                  state.detached_from);
 +      } else if (state.bisect_in_progress)
                strbuf_addf(&desc, _("(no branch, bisect started on %s)"),
                            state.branch);
        else if (state.detached_from) {
@@@ -1431,33 -1354,15 +1431,33 @@@ static const char *get_refname(struct u
        return show_ref(&atom->u.refname, ref->refname);
  }
  
 +static int get_object(struct ref_array_item *ref, const struct object_id *oid,
 +                     int deref, struct object **obj, struct strbuf *err)
 +{
 +      int eaten;
 +      int ret = 0;
 +      unsigned long size;
 +      void *buf = get_obj(oid, obj, &size, &eaten);
 +      if (!buf)
 +              ret = strbuf_addf_ret(err, -1, _("missing object %s for %s"),
 +                                    oid_to_hex(oid), ref->refname);
 +      else if (!*obj)
 +              ret = strbuf_addf_ret(err, -1, _("parse_object_buffer failed on %s for %s"),
 +                                    oid_to_hex(oid), ref->refname);
 +      else
 +              grab_values(ref->value, deref, *obj, buf, size);
 +      if (!eaten)
 +              free(buf);
 +      return ret;
 +}
 +
  /*
   * Parse the object referred by ref, and grab needed value.
   */
 -static void populate_value(struct ref_array_item *ref)
 +static int populate_value(struct ref_array_item *ref, struct strbuf *err)
  {
 -      void *buf;
        struct object *obj;
 -      int eaten, i;
 -      unsigned long size;
 +      int i;
        const struct object_id *tagged;
  
        ref->value = xcalloc(used_atom_cnt, sizeof(struct atom_value));
                                v->s = xstrdup(buf + 1);
                        }
                        continue;
 -              } else if (!deref && grab_objectname(name, ref->objectname.hash, v, atom)) {
 +              } else if (!deref && grab_objectname(name, &ref->objectname, v, atom)) {
                        continue;
                } else if (!strcmp(name, "HEAD")) {
                        if (atom->u.head && !strcmp(ref->refname, atom->u.head))
        for (i = 0; i < used_atom_cnt; i++) {
                struct atom_value *v = &ref->value[i];
                if (v->s == NULL)
 -                      goto need_obj;
 +                      break;
        }
 -      return;
 -
 - need_obj:
 -      buf = get_obj(&ref->objectname, &obj, &size, &eaten);
 -      if (!buf)
 -              die(_("missing object %s for %s"),
 -                  oid_to_hex(&ref->objectname), ref->refname);
 -      if (!obj)
 -              die(_("parse_object_buffer failed on %s for %s"),
 -                  oid_to_hex(&ref->objectname), ref->refname);
 +      if (used_atom_cnt <= i)
 +              return 0;
  
 -      grab_values(ref->value, 0, obj, buf, size);
 -      if (!eaten)
 -              free(buf);
 +      if (get_object(ref, &ref->objectname, 0, &obj, err))
 +              return -1;
  
        /*
         * If there is no atom that wants to know about tagged
         * object, we are done.
         */
        if (!need_tagged || (obj->type != OBJ_TAG))
 -              return;
 +              return 0;
  
        /*
         * If it is a tag object, see if we use a value that derefs
         * is not consistent with what deref_tag() does
         * which peels the onion to the core.
         */
 -      buf = get_obj(tagged, &obj, &size, &eaten);
 -      if (!buf)
 -              die(_("missing object %s for %s"),
 -                  oid_to_hex(tagged), ref->refname);
 -      if (!obj)
 -              die(_("parse_object_buffer failed on %s for %s"),
 -                  oid_to_hex(tagged), ref->refname);
 -      grab_values(ref->value, 1, obj, buf, size);
 -      if (!eaten)
 -              free(buf);
 +      return get_object(ref, tagged, 1, &obj, err);
  }
  
  /*
   * Given a ref, return the value for the atom.  This lazily gets value
   * out of the object by calling populate value.
   */
 -static void get_ref_atom_value(struct ref_array_item *ref, int atom, struct atom_value **v)
 +static int get_ref_atom_value(struct ref_array_item *ref, int atom,
 +                            struct atom_value **v, struct strbuf *err)
  {
        if (!ref->value) {
 -              populate_value(ref);
 +              if (populate_value(ref, err))
 +                      return -1;
                fill_missing_values(ref->value);
        }
        *v = &ref->value[atom];
 +      return 0;
  }
  
  /*
@@@ -1907,30 -1827,15 +1907,30 @@@ static const struct object_id *match_po
        return NULL;
  }
  
 -/* Allocate space for a new ref_array_item and copy the objectname and flag to it */
 +/*
 + * Allocate space for a new ref_array_item and copy the name and oid to it.
 + *
 + * Callers can then fill in other struct members at their leisure.
 + */
  static struct ref_array_item *new_ref_array_item(const char *refname,
 -                                               const unsigned char *objectname,
 -                                               int flag)
 +                                               const struct object_id *oid)
  {
        struct ref_array_item *ref;
 +
        FLEX_ALLOC_STR(ref, refname, refname);
 -      hashcpy(ref->objectname.hash, objectname);
 -      ref->flag = flag;
 +      oidcpy(&ref->objectname, oid);
 +
 +      return ref;
 +}
 +
 +struct ref_array_item *ref_array_push(struct ref_array *array,
 +                                    const char *refname,
 +                                    const struct object_id *oid)
 +{
 +      struct ref_array_item *ref = new_ref_array_item(refname, oid);
 +
 +      ALLOC_GROW(array->items, array->nr + 1, array->alloc);
 +      array->items[array->nr++] = ref;
  
        return ref;
  }
@@@ -2025,11 -1930,12 +2025,11 @@@ static int ref_filter_handler(const cha
         * to do its job and the resulting list may yet to be pruned
         * by maxcount logic.
         */
 -      ref = new_ref_array_item(refname, oid->hash, flag);
 +      ref = ref_array_push(ref_cbdata->array, refname, oid);
        ref->commit = commit;
 -
 -      REALLOC_ARRAY(ref_cbdata->array->items, ref_cbdata->array->nr + 1);
 -      ref_cbdata->array->items[ref_cbdata->array->nr++] = ref;
 +      ref->flag = flag;
        ref->kind = kind;
 +
        return 0;
  }
  
@@@ -2154,13 -2060,9 +2154,13 @@@ static int cmp_ref_sorting(struct ref_s
        int cmp;
        cmp_type cmp_type = used_atom[s->atom].type;
        int (*cmp_fn)(const char *, const char *);
 +      struct strbuf err = STRBUF_INIT;
  
 -      get_ref_atom_value(a, s->atom, &va);
 -      get_ref_atom_value(b, s->atom, &vb);
 +      if (get_ref_atom_value(a, s->atom, &va, &err))
 +              die("%s", err.buf);
 +      if (get_ref_atom_value(b, s->atom, &vb, &err))
 +              die("%s", err.buf);
 +      strbuf_release(&err);
        cmp_fn = s->ignore_case ? strcasecmp : strcmp;
        if (s->version)
                cmp = versioncmp(va->s, vb->s);
@@@ -2219,10 -2121,9 +2219,10 @@@ static void append_literal(const char *
        }
  }
  
 -void format_ref_array_item(struct ref_array_item *info,
 +int format_ref_array_item(struct ref_array_item *info,
                           const struct ref_format *format,
 -                         struct strbuf *final_buf)
 +                         struct strbuf *final_buf,
 +                         struct strbuf *error_buf)
  {
        const char *cp, *sp, *ep;
        struct ref_formatting_state state = REF_FORMATTING_STATE_INIT;
  
        for (cp = format->format; *cp && (sp = find_next(cp)); cp = ep + 1) {
                struct atom_value *atomv;
 +              int pos;
  
                ep = strchr(sp, ')');
                if (cp < sp)
                        append_literal(cp, sp, &state);
 -              get_ref_atom_value(info,
 -                                 parse_ref_filter_atom(format, sp + 2, ep),
 -                                 &atomv);
 -              atomv->handler(atomv, &state);
 +              pos = parse_ref_filter_atom(format, sp + 2, ep, error_buf);
 +              if (pos < 0 || get_ref_atom_value(info, pos, &atomv, error_buf) ||
 +                  atomv->handler(atomv, &state, error_buf)) {
 +                      pop_stack_element(&state.stack);
 +                      return -1;
 +              }
        }
        if (*cp) {
                sp = cp + strlen(cp);
        if (format->need_color_reset_at_eol) {
                struct atom_value resetv;
                resetv.s = GIT_COLOR_RESET;
 -              append_atom(&resetv, &state);
 +              if (append_atom(&resetv, &state, error_buf)) {
 +                      pop_stack_element(&state.stack);
 +                      return -1;
 +              }
 +      }
 +      if (state.stack->prev) {
 +              pop_stack_element(&state.stack);
 +              return strbuf_addf_ret(error_buf, -1, _("format: %%(end) atom missing"));
        }
 -      if (state.stack->prev)
 -              die(_("format: %%(end) atom missing"));
        strbuf_addbuf(final_buf, &state.stack->output);
        pop_stack_element(&state.stack);
 +      return 0;
  }
  
  void show_ref_array_item(struct ref_array_item *info,
                         const struct ref_format *format)
  {
        struct strbuf final_buf = STRBUF_INIT;
 +      struct strbuf error_buf = STRBUF_INIT;
  
 -      format_ref_array_item(info, format, &final_buf);
 +      if (format_ref_array_item(info, format, &final_buf, &error_buf))
 +              die("%s", error_buf.buf);
        fwrite(final_buf.buf, 1, final_buf.len, stdout);
 +      strbuf_release(&error_buf);
        strbuf_release(&final_buf);
        putchar('\n');
  }
  
 -void pretty_print_ref(const char *name, const unsigned char *sha1,
 +void pretty_print_ref(const char *name, const struct object_id *oid,
                      const struct ref_format *format)
  {
        struct ref_array_item *ref_item;
 -      ref_item = new_ref_array_item(name, sha1, 0);
 +      ref_item = new_ref_array_item(name, oid);
        ref_item->kind = ref_kind_from_refname(name);
        show_ref_array_item(ref_item, format);
        free_array_item(ref_item);
@@@ -2297,12 -2186,7 +2297,12 @@@ static int parse_sorting_atom(const cha
         */
        struct ref_format dummy = REF_FORMAT_INIT;
        const char *end = atom + strlen(atom);
 -      return parse_ref_filter_atom(&dummy, atom, end);
 +      struct strbuf err = STRBUF_INIT;
 +      int res = parse_ref_filter_atom(&dummy, atom, end, &err);
 +      if (res < 0)
 +              die("%s", err.buf);
 +      strbuf_release(&err);
 +      return res;
  }
  
  /*  If no sorting option is given, use refname to sort as default */
diff --combined revision.c
index 1cff11833e7e2ce64114e4d18339d6ae21ec80e8,d64d2a859e9750a1902994c091d02e9cd6743c2f..4e0e193e57e0d1360c52ae566770df61677e554e
@@@ -6,7 -6,6 +6,7 @@@
  #include "diff.h"
  #include "refs.h"
  #include "revision.h"
 +#include "repository.h"
  #include "graph.h"
  #include "grep.h"
  #include "reflog-walk.h"
@@@ -114,8 -113,7 +114,8 @@@ void mark_parents_uninteresting(struct 
                         * it is popped next time around, we won't be trying
                         * to parse it and get an error.
                         */
 -                      if (!has_object_file(&commit->object.oid))
 +                      if (!commit->object.parsed &&
 +                          !has_object_file(&commit->object.oid))
                                commit->object.parsed = 1;
  
                        if (commit->object.flags & UNINTERESTING)
@@@ -441,8 -439,8 +441,8 @@@ static void file_change(struct diff_opt
  static int rev_compare_tree(struct rev_info *revs,
                            struct commit *parent, struct commit *commit)
  {
-       struct tree *t1 = parent->tree;
-       struct tree *t2 = commit->tree;
+       struct tree *t1 = get_commit_tree(parent);
+       struct tree *t2 = get_commit_tree(commit);
  
        if (!t1)
                return REV_TREE_NEW;
  static int rev_same_tree_as_empty(struct rev_info *revs, struct commit *commit)
  {
        int retval;
-       struct tree *t1 = commit->tree;
+       struct tree *t1 = get_commit_tree(commit);
  
        if (!t1)
                return 0;
@@@ -616,7 -614,7 +616,7 @@@ static void try_to_simplify_commit(stru
        if (!revs->prune)
                return;
  
-       if (!commit->tree)
+       if (!get_commit_tree(commit))
                return;
  
        if (!commit->parents) {
@@@ -1286,7 -1284,7 +1286,7 @@@ void add_reflogs_to_pending(struct rev_
  
        cb.all_revs = revs;
        cb.all_flags = flags;
 -      cb.refs = get_main_ref_store();
 +      cb.refs = get_main_ref_store(the_repository);
        for_each_reflog(handle_one_reflog, &cb);
  
        if (!revs->single_worktree)
@@@ -2177,7 -2175,7 +2177,7 @@@ static int handle_revision_pseudo_opt(c
                        die("BUG: --single-worktree cannot be used together with submodule");
                refs = get_submodule_ref_store(submodule);
        } else
 -              refs = get_main_ref_store();
 +              refs = get_main_ref_store(the_repository);
  
        /*
         * NOTE!
diff --combined sequencer.c
index 4ce5120e777085227dd0f677dfed70a003cffe96,abebf6988fe7ec7db59de94f95bb7826592d6de9..2f69f5a0d3a64628dbab60f939b1f40f5f689316
@@@ -7,7 -7,7 +7,7 @@@
  #include "sequencer.h"
  #include "tag.h"
  #include "run-command.h"
 -#include "exec_cmd.h"
 +#include "exec-cmd.h"
  #include "utf8.h"
  #include "cache-tree.h"
  #include "diff.h"
@@@ -127,7 -127,6 +127,7 @@@ static GIT_PATH_FUNC(rebase_path_rewrit
  static GIT_PATH_FUNC(rebase_path_gpg_sign_opt, "rebase-merge/gpg_sign_opt")
  static GIT_PATH_FUNC(rebase_path_orig_head, "rebase-merge/orig-head")
  static GIT_PATH_FUNC(rebase_path_verbose, "rebase-merge/verbose")
 +static GIT_PATH_FUNC(rebase_path_signoff, "rebase-merge/signoff")
  static GIT_PATH_FUNC(rebase_path_head_name, "rebase-merge/head-name")
  static GIT_PATH_FUNC(rebase_path_onto, "rebase-merge/onto")
  static GIT_PATH_FUNC(rebase_path_autostash, "rebase-merge/autostash")
@@@ -283,7 -282,7 +283,7 @@@ struct commit_message 
  
  static const char *short_commit_name(struct commit *commit)
  {
 -      return find_unique_abbrev(commit->object.oid.hash, DEFAULT_ABBREV);
 +      return find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV);
  }
  
  static int get_message(struct commit *commit, struct commit_message *out)
@@@ -340,7 -339,7 +340,7 @@@ static void print_advice(int show_hint
  static int write_message(const void *buf, size_t len, const char *filename,
                         int append_eol)
  {
 -      static struct lock_file msg_file;
 +      struct lock_file msg_file = LOCK_INIT;
  
        int msg_fd = hold_lock_file_for_update(&msg_file, filename, 0);
        if (msg_fd < 0)
                rollback_lock_file(&msg_file);
                return error_errno(_("could not write eol to '%s'"), filename);
        }
 -      if (commit_lock_file(&msg_file) < 0) {
 -              rollback_lock_file(&msg_file);
 -              return error(_("failed to finalize '%s'."), filename);
 -      }
 +      if (commit_lock_file(&msg_file) < 0)
 +              return error(_("failed to finalize '%s'"), filename);
  
        return 0;
  }
@@@ -484,7 -485,7 +484,7 @@@ static int do_recursive_merge(struct co
        struct tree *result, *next_tree, *base_tree, *head_tree;
        int clean;
        char **xopt;
 -      static struct lock_file index_lock;
 +      struct lock_file index_lock = LOCK_INIT;
  
        if (hold_locked_index(&index_lock, LOCK_REPORT_ON_ERROR) < 0)
                return -1;
        o.show_rename_progress = 1;
  
        head_tree = parse_tree_indirect(head);
-       next_tree = next ? next->tree : empty_tree();
-       base_tree = base ? base->tree : empty_tree();
+       next_tree = next ? get_commit_tree(next) : empty_tree();
+       base_tree = base ? get_commit_tree(base) : empty_tree();
  
        for (xopt = opts->xopts; xopt != opts->xopts + opts->xopts_nr; xopt++)
                parse_merge_opt(&o, *xopt);
                fputs(o.obuf.buf, stdout);
        strbuf_release(&o.obuf);
        diff_warn_rename_limit("merge.renamelimit", o.needed_rename_limit, 0);
 -      if (clean < 0)
 +      if (clean < 0) {
 +              rollback_lock_file(&index_lock);
                return clean;
 +      }
  
 -      if (active_cache_changed &&
 -          write_locked_index(&the_index, &index_lock, COMMIT_LOCK))
 +      if (write_locked_index(&the_index, &index_lock,
 +                             COMMIT_LOCK | SKIP_IF_UNCHANGED))
                /*
                 * TRANSLATORS: %s will be "revert", "cherry-pick" or
                 * "rebase -i".
                 */
                return error(_("%s: Unable to write new index file"),
                        _(action_name(opts)));
 -      rollback_lock_file(&index_lock);
  
        if (!clean)
                append_conflicts_hint(msgbuf);
@@@ -562,7 -562,7 +562,7 @@@ static int is_index_unchanged(void
                        return error(_("unable to update cache tree"));
  
        return !oidcmp(&active_cache_tree->oid,
-                      &head_commit->tree->object.oid);
+                      get_commit_tree_oid(head_commit));
  }
  
  static int write_author_script(const char *message)
@@@ -1113,13 -1113,13 +1113,13 @@@ static int try_to_commit(struct strbuf 
                commit_list_insert(current_head, &parents);
        }
  
 -      if (write_cache_as_tree(tree.hash, 0, NULL)) {
 +      if (write_cache_as_tree(&tree, 0, NULL)) {
                res = error(_("git write-tree failed to write a tree"));
                goto out;
        }
  
        if (!(flags & ALLOW_EMPTY) && !oidcmp(current_head ?
-                                             &current_head->tree->object.oid :
+                                             get_commit_tree_oid(current_head) :
                                              &empty_tree_oid, &tree)) {
                res = 1; /* run 'git commit' to display error message */
                goto out;
                goto out;
        }
  
 +      reset_ident_date();
 +
        if (commit_tree_extended(msg->buf, msg->len, &tree, parents,
                                 oid, author, opts->gpg_sign, extra)) {
                res = error(_("failed to write commit object"));
@@@ -1219,12 -1217,12 +1219,12 @@@ static int is_original_commit_empty(str
                if (parse_commit(parent))
                        return error(_("could not parse parent commit %s"),
                                oid_to_hex(&parent->object.oid));
-               ptree_oid = &parent->tree->object.oid;
+               ptree_oid = get_commit_tree_oid(parent);
        } else {
                ptree_oid = the_hash_algo->empty_tree; /* commit is root */
        }
  
-       return !oidcmp(ptree_oid, &commit->tree->object.oid);
+       return !oidcmp(ptree_oid, get_commit_tree_oid(commit));
  }
  
  /*
@@@ -1477,7 -1475,7 +1477,7 @@@ static int do_pick_commit(enum todo_com
                 * that represents the "current" state for merge-recursive
                 * to work on.
                 */
 -              if (write_cache_as_tree(head.hash, 0, NULL))
 +              if (write_cache_as_tree(&head, 0, NULL))
                        return error(_("your index file is unmerged."));
        } else {
                unborn = get_oid("HEAD", &head);
                }
        }
  
 -      if (opts->signoff)
 +      if (opts->signoff && !is_fixup(command))
                append_signoff(&msgbuf, 0, 0);
  
        if (is_rebase_i(opts) && write_author_script(msg.message) < 0)
@@@ -1707,7 -1705,7 +1707,7 @@@ static int prepare_revs(struct replay_o
  
  static int read_and_refresh_cache(struct replay_opts *opts)
  {
 -      static struct lock_file index_lock;
 +      struct lock_file index_lock = LOCK_INIT;
        int index_fd = hold_locked_index(&index_lock, 0);
        if (read_index_preload(&the_index, NULL) < 0) {
                rollback_lock_file(&index_lock);
                        _(action_name(opts)));
        }
        refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, NULL, NULL, NULL);
 -      if (the_index.cache_changed && index_fd >= 0) {
 -              if (write_locked_index(&the_index, &index_lock, COMMIT_LOCK)) {
 +      if (index_fd >= 0) {
 +              if (write_locked_index(&the_index, &index_lock,
 +                                     COMMIT_LOCK | SKIP_IF_UNCHANGED)) {
                        return error(_("git %s: failed to refresh the index"),
                                _(action_name(opts)));
                }
        }
 -      rollback_lock_file(&index_lock);
        return 0;
  }
  
@@@ -1871,31 -1869,22 +1871,31 @@@ static int count_commands(struct todo_l
        return count;
  }
  
 +static ssize_t strbuf_read_file_or_whine(struct strbuf *sb, const char *path)
 +{
 +      int fd;
 +      ssize_t len;
 +
 +      fd = open(path, O_RDONLY);
 +      if (fd < 0)
 +              return error_errno(_("could not open '%s'"), path);
 +      len = strbuf_read(sb, fd, 0);
 +      close(fd);
 +      if (len < 0)
 +              return error(_("could not read '%s'."), path);
 +      return len;
 +}
 +
  static int read_populate_todo(struct todo_list *todo_list,
                        struct replay_opts *opts)
  {
        struct stat st;
        const char *todo_file = get_todo_path(opts);
 -      int fd, res;
 +      int res;
  
        strbuf_reset(&todo_list->buf);
 -      fd = open(todo_file, O_RDONLY);
 -      if (fd < 0)
 -              return error_errno(_("could not open '%s'"), todo_file);
 -      if (strbuf_read(&todo_list->buf, fd, 0) < 0) {
 -              close(fd);
 -              return error(_("could not read '%s'."), todo_file);
 -      }
 -      close(fd);
 +      if (strbuf_read_file_or_whine(&todo_list->buf, todo_file) < 0)
 +              return -1;
  
        res = stat(todo_file, &st);
        if (res)
@@@ -2046,11 -2035,6 +2046,11 @@@ static int read_populate_opts(struct re
                if (file_exists(rebase_path_verbose()))
                        opts->verbose = 1;
  
 +              if (file_exists(rebase_path_signoff())) {
 +                      opts->allow_ff = 0;
 +                      opts->signoff = 1;
 +              }
 +
                read_strategy_opts(opts, &buf);
                strbuf_release(&buf);
  
@@@ -2115,14 -2099,16 +2115,14 @@@ static int create_seq_dir(void
  
  static int save_head(const char *head)
  {
 -      static struct lock_file head_lock;
 +      struct lock_file head_lock = LOCK_INIT;
        struct strbuf buf = STRBUF_INIT;
        int fd;
        ssize_t written;
  
        fd = hold_lock_file_for_update(&head_lock, git_path_head_file(), 0);
 -      if (fd < 0) {
 -              rollback_lock_file(&head_lock);
 +      if (fd < 0)
                return error_errno(_("could not lock HEAD"));
 -      }
        strbuf_addf(&buf, "%s\n", head);
        written = write_in_full(fd, buf.buf, buf.len);
        strbuf_release(&buf);
                return error_errno(_("could not write to '%s'"),
                                   git_path_head_file());
        }
 -      if (commit_lock_file(&head_lock) < 0) {
 -              rollback_lock_file(&head_lock);
 -              return error(_("failed to finalize '%s'."), git_path_head_file());
 -      }
 +      if (commit_lock_file(&head_lock) < 0)
 +              return error(_("failed to finalize '%s'"), git_path_head_file());
        return 0;
  }
  
@@@ -2236,7 -2224,7 +2236,7 @@@ fail
  
  static int save_todo(struct todo_list *todo_list, struct replay_opts *opts)
  {
 -      static struct lock_file todo_lock;
 +      struct lock_file todo_lock = LOCK_INIT;
        const char *todo_path = get_todo_path(opts);
        int next = todo_list->current, offset, fd;
  
                        todo_list->buf.len - offset) < 0)
                return error_errno(_("could not write to '%s'"), todo_path);
        if (commit_lock_file(&todo_lock) < 0)
 -              return error(_("failed to finalize '%s'."), todo_path);
 +              return error(_("failed to finalize '%s'"), todo_path);
  
        if (is_rebase_i(opts)) {
                const char *done_path = rebase_path_done();
@@@ -2326,9 -2314,6 +2326,9 @@@ static int make_patch(struct commit *co
        p = short_commit_name(commit);
        if (write_message(p, strlen(p), rebase_path_stopped_sha(), 1) < 0)
                return -1;
 +      if (update_ref("rebase", "REBASE_HEAD", &commit->object.oid,
 +                     NULL, REF_NO_DEREF, UPDATE_REFS_MSG_ON_ERR))
 +              res |= error(_("could not update %s"), "REBASE_HEAD");
  
        strbuf_addf(&buf, "%s/patch", get_dir(opts));
        memset(&log_tree_opt, 0, sizeof(log_tree_opt));
@@@ -2580,7 -2565,6 +2580,7 @@@ static int pick_commits(struct todo_lis
                        unlink(rebase_path_author_script());
                        unlink(rebase_path_stopped_sha());
                        unlink(rebase_path_amend());
 +                      delete_ref(NULL, "REBASE_HEAD", NULL, REF_NO_DEREF);
                }
                if (item->command <= TODO_SQUASH) {
                        if (is_rebase_i(opts))
@@@ -2884,8 -2868,7 +2884,8 @@@ int sequencer_pick_revisions(struct rep
  
                if (!get_oid(name, &oid)) {
                        if (!lookup_commit_reference_gently(&oid, 1)) {
 -                              enum object_type type = sha1_object_info(oid.hash, NULL);
 +                              enum object_type type = oid_object_info(&oid,
 +                                                                      NULL);
                                return error(_("%s: can't cherry-pick a %s"),
                                        name, type_name(type));
                        }
@@@ -3009,7 -2992,7 +3009,7 @@@ int sequencer_make_script(FILE *out, in
        init_revisions(&revs, NULL);
        revs.verbose_header = 1;
        revs.max_parents = 1;
 -      revs.cherry_pick = 1;
 +      revs.cherry_mark = 1;
        revs.limited = 1;
        revs.reverse = 1;
        revs.right_only = 1;
                return error(_("make_script: error preparing revisions"));
  
        while ((commit = get_revision(&revs))) {
 +              int is_empty  = is_original_commit_empty(commit);
 +
 +              if (!is_empty && (commit->object.flags & PATCHSAME))
 +                      continue;
                strbuf_reset(&buf);
 -              if (!keep_empty && is_original_commit_empty(commit))
 +              if (!keep_empty && is_empty)
                        strbuf_addf(&buf, "%c ", comment_line_char);
                strbuf_addf(&buf, "%s %s ", insn,
                            oid_to_hex(&commit->object.oid));
@@@ -3172,13 -3151,20 +3172,13 @@@ int check_todo_list(void
        struct strbuf todo_file = STRBUF_INIT;
        struct todo_list todo_list = TODO_LIST_INIT;
        struct strbuf missing = STRBUF_INIT;
 -      int advise_to_edit_todo = 0, res = 0, fd, i;
 +      int advise_to_edit_todo = 0, res = 0, i;
  
        strbuf_addstr(&todo_file, rebase_path_todo());
 -      fd = open(todo_file.buf, O_RDONLY);
 -      if (fd < 0) {
 -              res = error_errno(_("could not open '%s'"), todo_file.buf);
 -              goto leave_check;
 -      }
 -      if (strbuf_read(&todo_list.buf, fd, 0) < 0) {
 -              close(fd);
 -              res = error(_("could not read '%s'."), todo_file.buf);
 +      if (strbuf_read_file_or_whine(&todo_list.buf, todo_file.buf) < 0) {
 +              res = -1;
                goto leave_check;
        }
 -      close(fd);
        advise_to_edit_todo = res =
                parse_insn_buffer(todo_list.buf.buf, &todo_list);
  
  
        todo_list_release(&todo_list);
        strbuf_addstr(&todo_file, ".backup");
 -      fd = open(todo_file.buf, O_RDONLY);
 -      if (fd < 0) {
 -              res = error_errno(_("could not open '%s'"), todo_file.buf);
 -              goto leave_check;
 -      }
 -      if (strbuf_read(&todo_list.buf, fd, 0) < 0) {
 -              close(fd);
 -              res = error(_("could not read '%s'."), todo_file.buf);
 +      if (strbuf_read_file_or_whine(&todo_list.buf, todo_file.buf) < 0) {
 +              res = -1;
                goto leave_check;
        }
 -      close(fd);
        strbuf_release(&todo_file);
        res = !!parse_insn_buffer(todo_list.buf.buf, &todo_list);
  
@@@ -3278,8 -3271,15 +3278,8 @@@ int skip_unnecessary_picks(void
        }
        strbuf_release(&buf);
  
 -      fd = open(todo_file, O_RDONLY);
 -      if (fd < 0) {
 -              return error_errno(_("could not open '%s'"), todo_file);
 -      }
 -      if (strbuf_read(&todo_list.buf, fd, 0) < 0) {
 -              close(fd);
 -              return error(_("could not read '%s'."), todo_file);
 -      }
 -      close(fd);
 +      if (strbuf_read_file_or_whine(&todo_list.buf, todo_file) < 0)
 +              return -1;
        if (parse_insn_buffer(todo_list.buf.buf, &todo_list) < 0) {
                todo_list_release(&todo_list);
                return -1;
@@@ -3370,11 -3370,17 +3370,11 @@@ int rearrange_squash(void
        const char *todo_file = rebase_path_todo();
        struct todo_list todo_list = TODO_LIST_INIT;
        struct hashmap subject2item;
 -      int res = 0, rearranged = 0, *next, *tail, fd, i;
 +      int res = 0, rearranged = 0, *next, *tail, i;
        char **subjects;
  
 -      fd = open(todo_file, O_RDONLY);
 -      if (fd < 0)
 -              return error_errno(_("could not open '%s'"), todo_file);
 -      if (strbuf_read(&todo_list.buf, fd, 0) < 0) {
 -              close(fd);
 -              return error(_("could not read '%s'."), todo_file);
 -      }
 -      close(fd);
 +      if (strbuf_read_file_or_whine(&todo_list.buf, todo_file) < 0)
 +              return -1;
        if (parse_insn_buffer(todo_list.buf.buf, &todo_list) < 0) {
                todo_list_release(&todo_list);
                return -1;
diff --combined sha1-name.c
index 5b93bf8da36939376b506f96624f568875397969,0000000000000000000000000000000000000000..bd99fd822bd4c6948eb401ae305192bdaa8ce36e
mode 100644,000000..100644
--- /dev/null
@@@ -1,1734 -1,0 +1,1734 @@@
-                       o = &(((struct commit *) o)->tree->object);
 +#include "cache.h"
 +#include "config.h"
 +#include "tag.h"
 +#include "commit.h"
 +#include "tree.h"
 +#include "blob.h"
 +#include "tree-walk.h"
 +#include "refs.h"
 +#include "remote.h"
 +#include "dir.h"
 +#include "sha1-array.h"
 +#include "packfile.h"
 +#include "object-store.h"
 +#include "repository.h"
 +
 +static int get_oid_oneline(const char *, struct object_id *, struct commit_list *);
 +
 +typedef int (*disambiguate_hint_fn)(const struct object_id *, void *);
 +
 +struct disambiguate_state {
 +      int len; /* length of prefix in hex chars */
 +      char hex_pfx[GIT_MAX_HEXSZ + 1];
 +      struct object_id bin_pfx;
 +
 +      disambiguate_hint_fn fn;
 +      void *cb_data;
 +      struct object_id candidate;
 +      unsigned candidate_exists:1;
 +      unsigned candidate_checked:1;
 +      unsigned candidate_ok:1;
 +      unsigned disambiguate_fn_used:1;
 +      unsigned ambiguous:1;
 +      unsigned always_call_fn:1;
 +};
 +
 +static void update_candidates(struct disambiguate_state *ds, const struct object_id *current)
 +{
 +      if (ds->always_call_fn) {
 +              ds->ambiguous = ds->fn(current, ds->cb_data) ? 1 : 0;
 +              return;
 +      }
 +      if (!ds->candidate_exists) {
 +              /* this is the first candidate */
 +              oidcpy(&ds->candidate, current);
 +              ds->candidate_exists = 1;
 +              return;
 +      } else if (!oidcmp(&ds->candidate, current)) {
 +              /* the same as what we already have seen */
 +              return;
 +      }
 +
 +      if (!ds->fn) {
 +              /* cannot disambiguate between ds->candidate and current */
 +              ds->ambiguous = 1;
 +              return;
 +      }
 +
 +      if (!ds->candidate_checked) {
 +              ds->candidate_ok = ds->fn(&ds->candidate, ds->cb_data);
 +              ds->disambiguate_fn_used = 1;
 +              ds->candidate_checked = 1;
 +      }
 +
 +      if (!ds->candidate_ok) {
 +              /* discard the candidate; we know it does not satisfy fn */
 +              oidcpy(&ds->candidate, current);
 +              ds->candidate_checked = 0;
 +              return;
 +      }
 +
 +      /* if we reach this point, we know ds->candidate satisfies fn */
 +      if (ds->fn(current, ds->cb_data)) {
 +              /*
 +               * if both current and candidate satisfy fn, we cannot
 +               * disambiguate.
 +               */
 +              ds->candidate_ok = 0;
 +              ds->ambiguous = 1;
 +      }
 +
 +      /* otherwise, current can be discarded and candidate is still good */
 +}
 +
 +static int append_loose_object(const struct object_id *oid, const char *path,
 +                             void *data)
 +{
 +      oid_array_append(data, oid);
 +      return 0;
 +}
 +
 +static int match_sha(unsigned, const unsigned char *, const unsigned char *);
 +
 +static void find_short_object_filename(struct disambiguate_state *ds)
 +{
 +      int subdir_nr = ds->bin_pfx.hash[0];
 +      struct alternate_object_database *alt;
 +      static struct alternate_object_database *fakeent;
 +
 +      if (!fakeent) {
 +              /*
 +               * Create a "fake" alternate object database that
 +               * points to our own object database, to make it
 +               * easier to get a temporary working space in
 +               * alt->name/alt->base while iterating over the
 +               * object databases including our own.
 +               */
 +              fakeent = alloc_alt_odb(get_object_directory());
 +      }
 +      fakeent->next = the_repository->objects->alt_odb_list;
 +
 +      for (alt = fakeent; alt && !ds->ambiguous; alt = alt->next) {
 +              int pos;
 +
 +              if (!alt->loose_objects_subdir_seen[subdir_nr]) {
 +                      struct strbuf *buf = alt_scratch_buf(alt);
 +                      for_each_file_in_obj_subdir(subdir_nr, buf,
 +                                                  append_loose_object,
 +                                                  NULL, NULL,
 +                                                  &alt->loose_objects_cache);
 +                      alt->loose_objects_subdir_seen[subdir_nr] = 1;
 +              }
 +
 +              pos = oid_array_lookup(&alt->loose_objects_cache, &ds->bin_pfx);
 +              if (pos < 0)
 +                      pos = -1 - pos;
 +              while (!ds->ambiguous && pos < alt->loose_objects_cache.nr) {
 +                      const struct object_id *oid;
 +                      oid = alt->loose_objects_cache.oid + pos;
 +                      if (!match_sha(ds->len, ds->bin_pfx.hash, oid->hash))
 +                              break;
 +                      update_candidates(ds, oid);
 +                      pos++;
 +              }
 +      }
 +}
 +
 +static int match_sha(unsigned len, const unsigned char *a, const unsigned char *b)
 +{
 +      do {
 +              if (*a != *b)
 +                      return 0;
 +              a++;
 +              b++;
 +              len -= 2;
 +      } while (len > 1);
 +      if (len)
 +              if ((*a ^ *b) & 0xf0)
 +                      return 0;
 +      return 1;
 +}
 +
 +static void unique_in_pack(struct packed_git *p,
 +                         struct disambiguate_state *ds)
 +{
 +      uint32_t num, i, first = 0;
 +      const struct object_id *current = NULL;
 +
 +      if (open_pack_index(p) || !p->num_objects)
 +              return;
 +
 +      num = p->num_objects;
 +      bsearch_pack(&ds->bin_pfx, p, &first);
 +
 +      /*
 +       * At this point, "first" is the location of the lowest object
 +       * with an object name that could match "bin_pfx".  See if we have
 +       * 0, 1 or more objects that actually match(es).
 +       */
 +      for (i = first; i < num && !ds->ambiguous; i++) {
 +              struct object_id oid;
 +              current = nth_packed_object_oid(&oid, p, i);
 +              if (!match_sha(ds->len, ds->bin_pfx.hash, current->hash))
 +                      break;
 +              update_candidates(ds, current);
 +      }
 +}
 +
 +static void find_short_packed_object(struct disambiguate_state *ds)
 +{
 +      struct packed_git *p;
 +
 +      for (p = get_packed_git(the_repository); p && !ds->ambiguous;
 +           p = p->next)
 +              unique_in_pack(p, ds);
 +}
 +
 +#define SHORT_NAME_NOT_FOUND (-1)
 +#define SHORT_NAME_AMBIGUOUS (-2)
 +
 +static int finish_object_disambiguation(struct disambiguate_state *ds,
 +                                      struct object_id *oid)
 +{
 +      if (ds->ambiguous)
 +              return SHORT_NAME_AMBIGUOUS;
 +
 +      if (!ds->candidate_exists)
 +              return SHORT_NAME_NOT_FOUND;
 +
 +      if (!ds->candidate_checked)
 +              /*
 +               * If this is the only candidate, there is no point
 +               * calling the disambiguation hint callback.
 +               *
 +               * On the other hand, if the current candidate
 +               * replaced an earlier candidate that did _not_ pass
 +               * the disambiguation hint callback, then we do have
 +               * more than one objects that match the short name
 +               * given, so we should make sure this one matches;
 +               * otherwise, if we discovered this one and the one
 +               * that we previously discarded in the reverse order,
 +               * we would end up showing different results in the
 +               * same repository!
 +               */
 +              ds->candidate_ok = (!ds->disambiguate_fn_used ||
 +                                  ds->fn(&ds->candidate, ds->cb_data));
 +
 +      if (!ds->candidate_ok)
 +              return SHORT_NAME_AMBIGUOUS;
 +
 +      oidcpy(oid, &ds->candidate);
 +      return 0;
 +}
 +
 +static int disambiguate_commit_only(const struct object_id *oid, void *cb_data_unused)
 +{
 +      int kind = oid_object_info(oid, NULL);
 +      return kind == OBJ_COMMIT;
 +}
 +
 +static int disambiguate_committish_only(const struct object_id *oid, void *cb_data_unused)
 +{
 +      struct object *obj;
 +      int kind;
 +
 +      kind = oid_object_info(oid, NULL);
 +      if (kind == OBJ_COMMIT)
 +              return 1;
 +      if (kind != OBJ_TAG)
 +              return 0;
 +
 +      /* We need to do this the hard way... */
 +      obj = deref_tag(parse_object(oid), NULL, 0);
 +      if (obj && obj->type == OBJ_COMMIT)
 +              return 1;
 +      return 0;
 +}
 +
 +static int disambiguate_tree_only(const struct object_id *oid, void *cb_data_unused)
 +{
 +      int kind = oid_object_info(oid, NULL);
 +      return kind == OBJ_TREE;
 +}
 +
 +static int disambiguate_treeish_only(const struct object_id *oid, void *cb_data_unused)
 +{
 +      struct object *obj;
 +      int kind;
 +
 +      kind = oid_object_info(oid, NULL);
 +      if (kind == OBJ_TREE || kind == OBJ_COMMIT)
 +              return 1;
 +      if (kind != OBJ_TAG)
 +              return 0;
 +
 +      /* We need to do this the hard way... */
 +      obj = deref_tag(parse_object(oid), NULL, 0);
 +      if (obj && (obj->type == OBJ_TREE || obj->type == OBJ_COMMIT))
 +              return 1;
 +      return 0;
 +}
 +
 +static int disambiguate_blob_only(const struct object_id *oid, void *cb_data_unused)
 +{
 +      int kind = oid_object_info(oid, NULL);
 +      return kind == OBJ_BLOB;
 +}
 +
 +static disambiguate_hint_fn default_disambiguate_hint;
 +
 +int set_disambiguate_hint_config(const char *var, const char *value)
 +{
 +      static const struct {
 +              const char *name;
 +              disambiguate_hint_fn fn;
 +      } hints[] = {
 +              { "none", NULL },
 +              { "commit", disambiguate_commit_only },
 +              { "committish", disambiguate_committish_only },
 +              { "tree", disambiguate_tree_only },
 +              { "treeish", disambiguate_treeish_only },
 +              { "blob", disambiguate_blob_only }
 +      };
 +      int i;
 +
 +      if (!value)
 +              return config_error_nonbool(var);
 +
 +      for (i = 0; i < ARRAY_SIZE(hints); i++) {
 +              if (!strcasecmp(value, hints[i].name)) {
 +                      default_disambiguate_hint = hints[i].fn;
 +                      return 0;
 +              }
 +      }
 +
 +      return error("unknown hint type for '%s': %s", var, value);
 +}
 +
 +static int init_object_disambiguation(const char *name, int len,
 +                                    struct disambiguate_state *ds)
 +{
 +      int i;
 +
 +      if (len < MINIMUM_ABBREV || len > GIT_SHA1_HEXSZ)
 +              return -1;
 +
 +      memset(ds, 0, sizeof(*ds));
 +
 +      for (i = 0; i < len ;i++) {
 +              unsigned char c = name[i];
 +              unsigned char val;
 +              if (c >= '0' && c <= '9')
 +                      val = c - '0';
 +              else if (c >= 'a' && c <= 'f')
 +                      val = c - 'a' + 10;
 +              else if (c >= 'A' && c <='F') {
 +                      val = c - 'A' + 10;
 +                      c -= 'A' - 'a';
 +              }
 +              else
 +                      return -1;
 +              ds->hex_pfx[i] = c;
 +              if (!(i & 1))
 +                      val <<= 4;
 +              ds->bin_pfx.hash[i >> 1] |= val;
 +      }
 +
 +      ds->len = len;
 +      ds->hex_pfx[len] = '\0';
 +      prepare_alt_odb(the_repository);
 +      return 0;
 +}
 +
 +static int show_ambiguous_object(const struct object_id *oid, void *data)
 +{
 +      const struct disambiguate_state *ds = data;
 +      struct strbuf desc = STRBUF_INIT;
 +      int type;
 +
 +
 +      if (ds->fn && !ds->fn(oid, ds->cb_data))
 +              return 0;
 +
 +      type = oid_object_info(oid, NULL);
 +      if (type == OBJ_COMMIT) {
 +              struct commit *commit = lookup_commit(oid);
 +              if (commit) {
 +                      struct pretty_print_context pp = {0};
 +                      pp.date_mode.type = DATE_SHORT;
 +                      format_commit_message(commit, " %ad - %s", &desc, &pp);
 +              }
 +      } else if (type == OBJ_TAG) {
 +              struct tag *tag = lookup_tag(oid);
 +              if (!parse_tag(tag) && tag->tag)
 +                      strbuf_addf(&desc, " %s", tag->tag);
 +      }
 +
 +      advise("  %s %s%s",
 +             find_unique_abbrev(oid, DEFAULT_ABBREV),
 +             type_name(type) ? type_name(type) : "unknown type",
 +             desc.buf);
 +
 +      strbuf_release(&desc);
 +      return 0;
 +}
 +
 +static int get_short_oid(const char *name, int len, struct object_id *oid,
 +                        unsigned flags)
 +{
 +      int status;
 +      struct disambiguate_state ds;
 +      int quietly = !!(flags & GET_OID_QUIETLY);
 +
 +      if (init_object_disambiguation(name, len, &ds) < 0)
 +              return -1;
 +
 +      if (HAS_MULTI_BITS(flags & GET_OID_DISAMBIGUATORS))
 +              die("BUG: multiple get_short_oid disambiguator flags");
 +
 +      if (flags & GET_OID_COMMIT)
 +              ds.fn = disambiguate_commit_only;
 +      else if (flags & GET_OID_COMMITTISH)
 +              ds.fn = disambiguate_committish_only;
 +      else if (flags & GET_OID_TREE)
 +              ds.fn = disambiguate_tree_only;
 +      else if (flags & GET_OID_TREEISH)
 +              ds.fn = disambiguate_treeish_only;
 +      else if (flags & GET_OID_BLOB)
 +              ds.fn = disambiguate_blob_only;
 +      else
 +              ds.fn = default_disambiguate_hint;
 +
 +      find_short_object_filename(&ds);
 +      find_short_packed_object(&ds);
 +      status = finish_object_disambiguation(&ds, oid);
 +
 +      if (!quietly && (status == SHORT_NAME_AMBIGUOUS)) {
 +              error(_("short SHA1 %s is ambiguous"), ds.hex_pfx);
 +
 +              /*
 +               * We may still have ambiguity if we simply saw a series of
 +               * candidates that did not satisfy our hint function. In
 +               * that case, we still want to show them, so disable the hint
 +               * function entirely.
 +               */
 +              if (!ds.ambiguous)
 +                      ds.fn = NULL;
 +
 +              advise(_("The candidates are:"));
 +              for_each_abbrev(ds.hex_pfx, show_ambiguous_object, &ds);
 +      }
 +
 +      return status;
 +}
 +
 +static int collect_ambiguous(const struct object_id *oid, void *data)
 +{
 +      oid_array_append(data, oid);
 +      return 0;
 +}
 +
 +int for_each_abbrev(const char *prefix, each_abbrev_fn fn, void *cb_data)
 +{
 +      struct oid_array collect = OID_ARRAY_INIT;
 +      struct disambiguate_state ds;
 +      int ret;
 +
 +      if (init_object_disambiguation(prefix, strlen(prefix), &ds) < 0)
 +              return -1;
 +
 +      ds.always_call_fn = 1;
 +      ds.fn = collect_ambiguous;
 +      ds.cb_data = &collect;
 +      find_short_object_filename(&ds);
 +      find_short_packed_object(&ds);
 +
 +      ret = oid_array_for_each_unique(&collect, fn, cb_data);
 +      oid_array_clear(&collect);
 +      return ret;
 +}
 +
 +/*
 + * Return the slot of the most-significant bit set in "val". There are various
 + * ways to do this quickly with fls() or __builtin_clzl(), but speed is
 + * probably not a big deal here.
 + */
 +static unsigned msb(unsigned long val)
 +{
 +      unsigned r = 0;
 +      while (val >>= 1)
 +              r++;
 +      return r;
 +}
 +
 +struct min_abbrev_data {
 +      unsigned int init_len;
 +      unsigned int cur_len;
 +      char *hex;
 +      const struct object_id *oid;
 +};
 +
 +static inline char get_hex_char_from_oid(const struct object_id *oid,
 +                                       unsigned int pos)
 +{
 +      static const char hex[] = "0123456789abcdef";
 +
 +      if ((pos & 1) == 0)
 +              return hex[oid->hash[pos >> 1] >> 4];
 +      else
 +              return hex[oid->hash[pos >> 1] & 0xf];
 +}
 +
 +static int extend_abbrev_len(const struct object_id *oid, void *cb_data)
 +{
 +      struct min_abbrev_data *mad = cb_data;
 +
 +      unsigned int i = mad->init_len;
 +      while (mad->hex[i] && mad->hex[i] == get_hex_char_from_oid(oid, i))
 +              i++;
 +
 +      if (i < GIT_MAX_RAWSZ && i >= mad->cur_len)
 +              mad->cur_len = i + 1;
 +
 +      return 0;
 +}
 +
 +static void find_abbrev_len_for_pack(struct packed_git *p,
 +                                   struct min_abbrev_data *mad)
 +{
 +      int match = 0;
 +      uint32_t num, first = 0;
 +      struct object_id oid;
 +      const struct object_id *mad_oid;
 +
 +      if (open_pack_index(p) || !p->num_objects)
 +              return;
 +
 +      num = p->num_objects;
 +      mad_oid = mad->oid;
 +      match = bsearch_pack(mad_oid, p, &first);
 +
 +      /*
 +       * first is now the position in the packfile where we would insert
 +       * mad->hash if it does not exist (or the position of mad->hash if
 +       * it does exist). Hence, we consider a maximum of two objects
 +       * nearby for the abbreviation length.
 +       */
 +      mad->init_len = 0;
 +      if (!match) {
 +              if (nth_packed_object_oid(&oid, p, first))
 +                      extend_abbrev_len(&oid, mad);
 +      } else if (first < num - 1) {
 +              if (nth_packed_object_oid(&oid, p, first + 1))
 +                      extend_abbrev_len(&oid, mad);
 +      }
 +      if (first > 0) {
 +              if (nth_packed_object_oid(&oid, p, first - 1))
 +                      extend_abbrev_len(&oid, mad);
 +      }
 +      mad->init_len = mad->cur_len;
 +}
 +
 +static void find_abbrev_len_packed(struct min_abbrev_data *mad)
 +{
 +      struct packed_git *p;
 +
 +      for (p = get_packed_git(the_repository); p; p = p->next)
 +              find_abbrev_len_for_pack(p, mad);
 +}
 +
 +int find_unique_abbrev_r(char *hex, const struct object_id *oid, int len)
 +{
 +      struct disambiguate_state ds;
 +      struct min_abbrev_data mad;
 +      struct object_id oid_ret;
 +      if (len < 0) {
 +              unsigned long count = approximate_object_count();
 +              /*
 +               * Add one because the MSB only tells us the highest bit set,
 +               * not including the value of all the _other_ bits (so "15"
 +               * is only one off of 2^4, but the MSB is the 3rd bit.
 +               */
 +              len = msb(count) + 1;
 +              /*
 +               * We now know we have on the order of 2^len objects, which
 +               * expects a collision at 2^(len/2). But we also care about hex
 +               * chars, not bits, and there are 4 bits per hex. So all
 +               * together we need to divide by 2 and round up.
 +               */
 +              len = DIV_ROUND_UP(len, 2);
 +              /*
 +               * For very small repos, we stick with our regular fallback.
 +               */
 +              if (len < FALLBACK_DEFAULT_ABBREV)
 +                      len = FALLBACK_DEFAULT_ABBREV;
 +      }
 +
 +      oid_to_hex_r(hex, oid);
 +      if (len == GIT_SHA1_HEXSZ || !len)
 +              return GIT_SHA1_HEXSZ;
 +
 +      mad.init_len = len;
 +      mad.cur_len = len;
 +      mad.hex = hex;
 +      mad.oid = oid;
 +
 +      find_abbrev_len_packed(&mad);
 +
 +      if (init_object_disambiguation(hex, mad.cur_len, &ds) < 0)
 +              return -1;
 +
 +      ds.fn = extend_abbrev_len;
 +      ds.always_call_fn = 1;
 +      ds.cb_data = (void *)&mad;
 +
 +      find_short_object_filename(&ds);
 +      (void)finish_object_disambiguation(&ds, &oid_ret);
 +
 +      hex[mad.cur_len] = 0;
 +      return mad.cur_len;
 +}
 +
 +const char *find_unique_abbrev(const struct object_id *oid, int len)
 +{
 +      static int bufno;
 +      static char hexbuffer[4][GIT_MAX_HEXSZ + 1];
 +      char *hex = hexbuffer[bufno];
 +      bufno = (bufno + 1) % ARRAY_SIZE(hexbuffer);
 +      find_unique_abbrev_r(hex, oid, len);
 +      return hex;
 +}
 +
 +static int ambiguous_path(const char *path, int len)
 +{
 +      int slash = 1;
 +      int cnt;
 +
 +      for (cnt = 0; cnt < len; cnt++) {
 +              switch (*path++) {
 +              case '\0':
 +                      break;
 +              case '/':
 +                      if (slash)
 +                              break;
 +                      slash = 1;
 +                      continue;
 +              case '.':
 +                      continue;
 +              default:
 +                      slash = 0;
 +                      continue;
 +              }
 +              break;
 +      }
 +      return slash;
 +}
 +
 +static inline int at_mark(const char *string, int len,
 +                        const char **suffix, int nr)
 +{
 +      int i;
 +
 +      for (i = 0; i < nr; i++) {
 +              int suffix_len = strlen(suffix[i]);
 +              if (suffix_len <= len
 +                  && !strncasecmp(string, suffix[i], suffix_len))
 +                      return suffix_len;
 +      }
 +      return 0;
 +}
 +
 +static inline int upstream_mark(const char *string, int len)
 +{
 +      const char *suffix[] = { "@{upstream}", "@{u}" };
 +      return at_mark(string, len, suffix, ARRAY_SIZE(suffix));
 +}
 +
 +static inline int push_mark(const char *string, int len)
 +{
 +      const char *suffix[] = { "@{push}" };
 +      return at_mark(string, len, suffix, ARRAY_SIZE(suffix));
 +}
 +
 +static int get_oid_1(const char *name, int len, struct object_id *oid, unsigned lookup_flags);
 +static int interpret_nth_prior_checkout(const char *name, int namelen, struct strbuf *buf);
 +
 +static int get_oid_basic(const char *str, int len, struct object_id *oid,
 +                        unsigned int flags)
 +{
 +      static const char *warn_msg = "refname '%.*s' is ambiguous.";
 +      static const char *object_name_msg = N_(
 +      "Git normally never creates a ref that ends with 40 hex characters\n"
 +      "because it will be ignored when you just specify 40-hex. These refs\n"
 +      "may be created by mistake. For example,\n"
 +      "\n"
 +      "  git checkout -b $br $(git rev-parse ...)\n"
 +      "\n"
 +      "where \"$br\" is somehow empty and a 40-hex ref is created. Please\n"
 +      "examine these refs and maybe delete them. Turn this message off by\n"
 +      "running \"git config advice.objectNameWarning false\"");
 +      struct object_id tmp_oid;
 +      char *real_ref = NULL;
 +      int refs_found = 0;
 +      int at, reflog_len, nth_prior = 0;
 +
 +      if (len == GIT_SHA1_HEXSZ && !get_oid_hex(str, oid)) {
 +              if (warn_ambiguous_refs && warn_on_object_refname_ambiguity) {
 +                      refs_found = dwim_ref(str, len, &tmp_oid, &real_ref);
 +                      if (refs_found > 0) {
 +                              warning(warn_msg, len, str);
 +                              if (advice_object_name_warning)
 +                                      fprintf(stderr, "%s\n", _(object_name_msg));
 +                      }
 +                      free(real_ref);
 +              }
 +              return 0;
 +      }
 +
 +      /* basic@{time or number or -number} format to query ref-log */
 +      reflog_len = at = 0;
 +      if (len && str[len-1] == '}') {
 +              for (at = len-4; at >= 0; at--) {
 +                      if (str[at] == '@' && str[at+1] == '{') {
 +                              if (str[at+2] == '-') {
 +                                      if (at != 0)
 +                                              /* @{-N} not at start */
 +                                              return -1;
 +                                      nth_prior = 1;
 +                                      continue;
 +                              }
 +                              if (!upstream_mark(str + at, len - at) &&
 +                                  !push_mark(str + at, len - at)) {
 +                                      reflog_len = (len-1) - (at+2);
 +                                      len = at;
 +                              }
 +                              break;
 +                      }
 +              }
 +      }
 +
 +      /* Accept only unambiguous ref paths. */
 +      if (len && ambiguous_path(str, len))
 +              return -1;
 +
 +      if (nth_prior) {
 +              struct strbuf buf = STRBUF_INIT;
 +              int detached;
 +
 +              if (interpret_nth_prior_checkout(str, len, &buf) > 0) {
 +                      detached = (buf.len == GIT_SHA1_HEXSZ && !get_oid_hex(buf.buf, oid));
 +                      strbuf_release(&buf);
 +                      if (detached)
 +                              return 0;
 +              }
 +      }
 +
 +      if (!len && reflog_len)
 +              /* allow "@{...}" to mean the current branch reflog */
 +              refs_found = dwim_ref("HEAD", 4, oid, &real_ref);
 +      else if (reflog_len)
 +              refs_found = dwim_log(str, len, oid, &real_ref);
 +      else
 +              refs_found = dwim_ref(str, len, oid, &real_ref);
 +
 +      if (!refs_found)
 +              return -1;
 +
 +      if (warn_ambiguous_refs && !(flags & GET_OID_QUIETLY) &&
 +          (refs_found > 1 ||
 +           !get_short_oid(str, len, &tmp_oid, GET_OID_QUIETLY)))
 +              warning(warn_msg, len, str);
 +
 +      if (reflog_len) {
 +              int nth, i;
 +              timestamp_t at_time;
 +              timestamp_t co_time;
 +              int co_tz, co_cnt;
 +
 +              /* Is it asking for N-th entry, or approxidate? */
 +              for (i = nth = 0; 0 <= nth && i < reflog_len; i++) {
 +                      char ch = str[at+2+i];
 +                      if ('0' <= ch && ch <= '9')
 +                              nth = nth * 10 + ch - '0';
 +                      else
 +                              nth = -1;
 +              }
 +              if (100000000 <= nth) {
 +                      at_time = nth;
 +                      nth = -1;
 +              } else if (0 <= nth)
 +                      at_time = 0;
 +              else {
 +                      int errors = 0;
 +                      char *tmp = xstrndup(str + at + 2, reflog_len);
 +                      at_time = approxidate_careful(tmp, &errors);
 +                      free(tmp);
 +                      if (errors) {
 +                              free(real_ref);
 +                              return -1;
 +                      }
 +              }
 +              if (read_ref_at(real_ref, flags, at_time, nth, oid, NULL,
 +                              &co_time, &co_tz, &co_cnt)) {
 +                      if (!len) {
 +                              if (starts_with(real_ref, "refs/heads/")) {
 +                                      str = real_ref + 11;
 +                                      len = strlen(real_ref + 11);
 +                              } else {
 +                                      /* detached HEAD */
 +                                      str = "HEAD";
 +                                      len = 4;
 +                              }
 +                      }
 +                      if (at_time) {
 +                              if (!(flags & GET_OID_QUIETLY)) {
 +                                      warning("Log for '%.*s' only goes "
 +                                              "back to %s.", len, str,
 +                                              show_date(co_time, co_tz, DATE_MODE(RFC2822)));
 +                              }
 +                      } else {
 +                              if (flags & GET_OID_QUIETLY) {
 +                                      exit(128);
 +                              }
 +                              die("Log for '%.*s' only has %d entries.",
 +                                  len, str, co_cnt);
 +                      }
 +              }
 +      }
 +
 +      free(real_ref);
 +      return 0;
 +}
 +
 +static int get_parent(const char *name, int len,
 +                    struct object_id *result, int idx)
 +{
 +      struct object_id oid;
 +      int ret = get_oid_1(name, len, &oid, GET_OID_COMMITTISH);
 +      struct commit *commit;
 +      struct commit_list *p;
 +
 +      if (ret)
 +              return ret;
 +      commit = lookup_commit_reference(&oid);
 +      if (parse_commit(commit))
 +              return -1;
 +      if (!idx) {
 +              oidcpy(result, &commit->object.oid);
 +              return 0;
 +      }
 +      p = commit->parents;
 +      while (p) {
 +              if (!--idx) {
 +                      oidcpy(result, &p->item->object.oid);
 +                      return 0;
 +              }
 +              p = p->next;
 +      }
 +      return -1;
 +}
 +
 +static int get_nth_ancestor(const char *name, int len,
 +                          struct object_id *result, int generation)
 +{
 +      struct object_id oid;
 +      struct commit *commit;
 +      int ret;
 +
 +      ret = get_oid_1(name, len, &oid, GET_OID_COMMITTISH);
 +      if (ret)
 +              return ret;
 +      commit = lookup_commit_reference(&oid);
 +      if (!commit)
 +              return -1;
 +
 +      while (generation--) {
 +              if (parse_commit(commit) || !commit->parents)
 +                      return -1;
 +              commit = commit->parents->item;
 +      }
 +      oidcpy(result, &commit->object.oid);
 +      return 0;
 +}
 +
 +struct object *peel_to_type(const char *name, int namelen,
 +                          struct object *o, enum object_type expected_type)
 +{
 +      if (name && !namelen)
 +              namelen = strlen(name);
 +      while (1) {
 +              if (!o || (!o->parsed && !parse_object(&o->oid)))
 +                      return NULL;
 +              if (expected_type == OBJ_ANY || o->type == expected_type)
 +                      return o;
 +              if (o->type == OBJ_TAG)
 +                      o = ((struct tag*) o)->tagged;
 +              else if (o->type == OBJ_COMMIT)
++                      o = &(get_commit_tree(((struct commit *)o))->object);
 +              else {
 +                      if (name)
 +                              error("%.*s: expected %s type, but the object "
 +                                    "dereferences to %s type",
 +                                    namelen, name, type_name(expected_type),
 +                                    type_name(o->type));
 +                      return NULL;
 +              }
 +      }
 +}
 +
 +static int peel_onion(const char *name, int len, struct object_id *oid,
 +                    unsigned lookup_flags)
 +{
 +      struct object_id outer;
 +      const char *sp;
 +      unsigned int expected_type = 0;
 +      struct object *o;
 +
 +      /*
 +       * "ref^{type}" dereferences ref repeatedly until you cannot
 +       * dereference anymore, or you get an object of given type,
 +       * whichever comes first.  "ref^{}" means just dereference
 +       * tags until you get a non-tag.  "ref^0" is a shorthand for
 +       * "ref^{commit}".  "commit^{tree}" could be used to find the
 +       * top-level tree of the given commit.
 +       */
 +      if (len < 4 || name[len-1] != '}')
 +              return -1;
 +
 +      for (sp = name + len - 1; name <= sp; sp--) {
 +              int ch = *sp;
 +              if (ch == '{' && name < sp && sp[-1] == '^')
 +                      break;
 +      }
 +      if (sp <= name)
 +              return -1;
 +
 +      sp++; /* beginning of type name, or closing brace for empty */
 +      if (starts_with(sp, "commit}"))
 +              expected_type = OBJ_COMMIT;
 +      else if (starts_with(sp, "tag}"))
 +              expected_type = OBJ_TAG;
 +      else if (starts_with(sp, "tree}"))
 +              expected_type = OBJ_TREE;
 +      else if (starts_with(sp, "blob}"))
 +              expected_type = OBJ_BLOB;
 +      else if (starts_with(sp, "object}"))
 +              expected_type = OBJ_ANY;
 +      else if (sp[0] == '}')
 +              expected_type = OBJ_NONE;
 +      else if (sp[0] == '/')
 +              expected_type = OBJ_COMMIT;
 +      else
 +              return -1;
 +
 +      lookup_flags &= ~GET_OID_DISAMBIGUATORS;
 +      if (expected_type == OBJ_COMMIT)
 +              lookup_flags |= GET_OID_COMMITTISH;
 +      else if (expected_type == OBJ_TREE)
 +              lookup_flags |= GET_OID_TREEISH;
 +
 +      if (get_oid_1(name, sp - name - 2, &outer, lookup_flags))
 +              return -1;
 +
 +      o = parse_object(&outer);
 +      if (!o)
 +              return -1;
 +      if (!expected_type) {
 +              o = deref_tag(o, name, sp - name - 2);
 +              if (!o || (!o->parsed && !parse_object(&o->oid)))
 +                      return -1;
 +              oidcpy(oid, &o->oid);
 +              return 0;
 +      }
 +
 +      /*
 +       * At this point, the syntax look correct, so
 +       * if we do not get the needed object, we should
 +       * barf.
 +       */
 +      o = peel_to_type(name, len, o, expected_type);
 +      if (!o)
 +              return -1;
 +
 +      oidcpy(oid, &o->oid);
 +      if (sp[0] == '/') {
 +              /* "$commit^{/foo}" */
 +              char *prefix;
 +              int ret;
 +              struct commit_list *list = NULL;
 +
 +              /*
 +               * $commit^{/}. Some regex implementation may reject.
 +               * We don't need regex anyway. '' pattern always matches.
 +               */
 +              if (sp[1] == '}')
 +                      return 0;
 +
 +              prefix = xstrndup(sp + 1, name + len - 1 - (sp + 1));
 +              commit_list_insert((struct commit *)o, &list);
 +              ret = get_oid_oneline(prefix, oid, list);
 +              free(prefix);
 +              return ret;
 +      }
 +      return 0;
 +}
 +
 +static int get_describe_name(const char *name, int len, struct object_id *oid)
 +{
 +      const char *cp;
 +      unsigned flags = GET_OID_QUIETLY | GET_OID_COMMIT;
 +
 +      for (cp = name + len - 1; name + 2 <= cp; cp--) {
 +              char ch = *cp;
 +              if (!isxdigit(ch)) {
 +                      /* We must be looking at g in "SOMETHING-g"
 +                       * for it to be describe output.
 +                       */
 +                      if (ch == 'g' && cp[-1] == '-') {
 +                              cp++;
 +                              len -= cp - name;
 +                              return get_short_oid(cp, len, oid, flags);
 +                      }
 +              }
 +      }
 +      return -1;
 +}
 +
 +static int get_oid_1(const char *name, int len, struct object_id *oid, unsigned lookup_flags)
 +{
 +      int ret, has_suffix;
 +      const char *cp;
 +
 +      /*
 +       * "name~3" is "name^^^", "name~" is "name~1", and "name^" is "name^1".
 +       */
 +      has_suffix = 0;
 +      for (cp = name + len - 1; name <= cp; cp--) {
 +              int ch = *cp;
 +              if ('0' <= ch && ch <= '9')
 +                      continue;
 +              if (ch == '~' || ch == '^')
 +                      has_suffix = ch;
 +              break;
 +      }
 +
 +      if (has_suffix) {
 +              int num = 0;
 +              int len1 = cp - name;
 +              cp++;
 +              while (cp < name + len)
 +                      num = num * 10 + *cp++ - '0';
 +              if (!num && len1 == len - 1)
 +                      num = 1;
 +              if (has_suffix == '^')
 +                      return get_parent(name, len1, oid, num);
 +              /* else if (has_suffix == '~') -- goes without saying */
 +              return get_nth_ancestor(name, len1, oid, num);
 +      }
 +
 +      ret = peel_onion(name, len, oid, lookup_flags);
 +      if (!ret)
 +              return 0;
 +
 +      ret = get_oid_basic(name, len, oid, lookup_flags);
 +      if (!ret)
 +              return 0;
 +
 +      /* It could be describe output that is "SOMETHING-gXXXX" */
 +      ret = get_describe_name(name, len, oid);
 +      if (!ret)
 +              return 0;
 +
 +      return get_short_oid(name, len, oid, lookup_flags);
 +}
 +
 +/*
 + * This interprets names like ':/Initial revision of "git"' by searching
 + * through history and returning the first commit whose message starts
 + * the given regular expression.
 + *
 + * For negative-matching, prefix the pattern-part with '!-', like: ':/!-WIP'.
 + *
 + * For a literal '!' character at the beginning of a pattern, you have to repeat
 + * that, like: ':/!!foo'
 + *
 + * For future extension, all other sequences beginning with ':/!' are reserved.
 + */
 +
 +/* Remember to update object flag allocation in object.h */
 +#define ONELINE_SEEN (1u<<20)
 +
 +static int handle_one_ref(const char *path, const struct object_id *oid,
 +                        int flag, void *cb_data)
 +{
 +      struct commit_list **list = cb_data;
 +      struct object *object = parse_object(oid);
 +      if (!object)
 +              return 0;
 +      if (object->type == OBJ_TAG) {
 +              object = deref_tag(object, path, strlen(path));
 +              if (!object)
 +                      return 0;
 +      }
 +      if (object->type != OBJ_COMMIT)
 +              return 0;
 +      commit_list_insert((struct commit *)object, list);
 +      return 0;
 +}
 +
 +static int get_oid_oneline(const char *prefix, struct object_id *oid,
 +                          struct commit_list *list)
 +{
 +      struct commit_list *backup = NULL, *l;
 +      int found = 0;
 +      int negative = 0;
 +      regex_t regex;
 +
 +      if (prefix[0] == '!') {
 +              prefix++;
 +
 +              if (prefix[0] == '-') {
 +                      prefix++;
 +                      negative = 1;
 +              } else if (prefix[0] != '!') {
 +                      return -1;
 +              }
 +      }
 +
 +      if (regcomp(&regex, prefix, REG_EXTENDED))
 +              return -1;
 +
 +      for (l = list; l; l = l->next) {
 +              l->item->object.flags |= ONELINE_SEEN;
 +              commit_list_insert(l->item, &backup);
 +      }
 +      while (list) {
 +              const char *p, *buf;
 +              struct commit *commit;
 +              int matches;
 +
 +              commit = pop_most_recent_commit(&list, ONELINE_SEEN);
 +              if (!parse_object(&commit->object.oid))
 +                      continue;
 +              buf = get_commit_buffer(commit, NULL);
 +              p = strstr(buf, "\n\n");
 +              matches = negative ^ (p && !regexec(&regex, p + 2, 0, NULL, 0));
 +              unuse_commit_buffer(commit, buf);
 +
 +              if (matches) {
 +                      oidcpy(oid, &commit->object.oid);
 +                      found = 1;
 +                      break;
 +              }
 +      }
 +      regfree(&regex);
 +      free_commit_list(list);
 +      for (l = backup; l; l = l->next)
 +              clear_commit_marks(l->item, ONELINE_SEEN);
 +      free_commit_list(backup);
 +      return found ? 0 : -1;
 +}
 +
 +struct grab_nth_branch_switch_cbdata {
 +      int remaining;
 +      struct strbuf buf;
 +};
 +
 +static int grab_nth_branch_switch(struct object_id *ooid, struct object_id *noid,
 +                                const char *email, timestamp_t timestamp, int tz,
 +                                const char *message, void *cb_data)
 +{
 +      struct grab_nth_branch_switch_cbdata *cb = cb_data;
 +      const char *match = NULL, *target = NULL;
 +      size_t len;
 +
 +      if (skip_prefix(message, "checkout: moving from ", &match))
 +              target = strstr(match, " to ");
 +
 +      if (!match || !target)
 +              return 0;
 +      if (--(cb->remaining) == 0) {
 +              len = target - match;
 +              strbuf_reset(&cb->buf);
 +              strbuf_add(&cb->buf, match, len);
 +              return 1; /* we are done */
 +      }
 +      return 0;
 +}
 +
 +/*
 + * Parse @{-N} syntax, return the number of characters parsed
 + * if successful; otherwise signal an error with negative value.
 + */
 +static int interpret_nth_prior_checkout(const char *name, int namelen,
 +                                      struct strbuf *buf)
 +{
 +      long nth;
 +      int retval;
 +      struct grab_nth_branch_switch_cbdata cb;
 +      const char *brace;
 +      char *num_end;
 +
 +      if (namelen < 4)
 +              return -1;
 +      if (name[0] != '@' || name[1] != '{' || name[2] != '-')
 +              return -1;
 +      brace = memchr(name, '}', namelen);
 +      if (!brace)
 +              return -1;
 +      nth = strtol(name + 3, &num_end, 10);
 +      if (num_end != brace)
 +              return -1;
 +      if (nth <= 0)
 +              return -1;
 +      cb.remaining = nth;
 +      strbuf_init(&cb.buf, 20);
 +
 +      retval = 0;
 +      if (0 < for_each_reflog_ent_reverse("HEAD", grab_nth_branch_switch, &cb)) {
 +              strbuf_reset(buf);
 +              strbuf_addbuf(buf, &cb.buf);
 +              retval = brace - name + 1;
 +      }
 +
 +      strbuf_release(&cb.buf);
 +      return retval;
 +}
 +
 +int get_oid_mb(const char *name, struct object_id *oid)
 +{
 +      struct commit *one, *two;
 +      struct commit_list *mbs;
 +      struct object_id oid_tmp;
 +      const char *dots;
 +      int st;
 +
 +      dots = strstr(name, "...");
 +      if (!dots)
 +              return get_oid(name, oid);
 +      if (dots == name)
 +              st = get_oid("HEAD", &oid_tmp);
 +      else {
 +              struct strbuf sb;
 +              strbuf_init(&sb, dots - name);
 +              strbuf_add(&sb, name, dots - name);
 +              st = get_oid_committish(sb.buf, &oid_tmp);
 +              strbuf_release(&sb);
 +      }
 +      if (st)
 +              return st;
 +      one = lookup_commit_reference_gently(&oid_tmp, 0);
 +      if (!one)
 +              return -1;
 +
 +      if (get_oid_committish(dots[3] ? (dots + 3) : "HEAD", &oid_tmp))
 +              return -1;
 +      two = lookup_commit_reference_gently(&oid_tmp, 0);
 +      if (!two)
 +              return -1;
 +      mbs = get_merge_bases(one, two);
 +      if (!mbs || mbs->next)
 +              st = -1;
 +      else {
 +              st = 0;
 +              oidcpy(oid, &mbs->item->object.oid);
 +      }
 +      free_commit_list(mbs);
 +      return st;
 +}
 +
 +/* parse @something syntax, when 'something' is not {.*} */
 +static int interpret_empty_at(const char *name, int namelen, int len, struct strbuf *buf)
 +{
 +      const char *next;
 +
 +      if (len || name[1] == '{')
 +              return -1;
 +
 +      /* make sure it's a single @, or @@{.*}, not @foo */
 +      next = memchr(name + len + 1, '@', namelen - len - 1);
 +      if (next && next[1] != '{')
 +              return -1;
 +      if (!next)
 +              next = name + namelen;
 +      if (next != name + 1)
 +              return -1;
 +
 +      strbuf_reset(buf);
 +      strbuf_add(buf, "HEAD", 4);
 +      return 1;
 +}
 +
 +static int reinterpret(const char *name, int namelen, int len,
 +                     struct strbuf *buf, unsigned allowed)
 +{
 +      /* we have extra data, which might need further processing */
 +      struct strbuf tmp = STRBUF_INIT;
 +      int used = buf->len;
 +      int ret;
 +
 +      strbuf_add(buf, name + len, namelen - len);
 +      ret = interpret_branch_name(buf->buf, buf->len, &tmp, allowed);
 +      /* that data was not interpreted, remove our cruft */
 +      if (ret < 0) {
 +              strbuf_setlen(buf, used);
 +              return len;
 +      }
 +      strbuf_reset(buf);
 +      strbuf_addbuf(buf, &tmp);
 +      strbuf_release(&tmp);
 +      /* tweak for size of {-N} versus expanded ref name */
 +      return ret - used + len;
 +}
 +
 +static void set_shortened_ref(struct strbuf *buf, const char *ref)
 +{
 +      char *s = shorten_unambiguous_ref(ref, 0);
 +      strbuf_reset(buf);
 +      strbuf_addstr(buf, s);
 +      free(s);
 +}
 +
 +static int branch_interpret_allowed(const char *refname, unsigned allowed)
 +{
 +      if (!allowed)
 +              return 1;
 +
 +      if ((allowed & INTERPRET_BRANCH_LOCAL) &&
 +          starts_with(refname, "refs/heads/"))
 +              return 1;
 +      if ((allowed & INTERPRET_BRANCH_REMOTE) &&
 +          starts_with(refname, "refs/remotes/"))
 +              return 1;
 +
 +      return 0;
 +}
 +
 +static int interpret_branch_mark(const char *name, int namelen,
 +                               int at, struct strbuf *buf,
 +                               int (*get_mark)(const char *, int),
 +                               const char *(*get_data)(struct branch *,
 +                                                       struct strbuf *),
 +                               unsigned allowed)
 +{
 +      int len;
 +      struct branch *branch;
 +      struct strbuf err = STRBUF_INIT;
 +      const char *value;
 +
 +      len = get_mark(name + at, namelen - at);
 +      if (!len)
 +              return -1;
 +
 +      if (memchr(name, ':', at))
 +              return -1;
 +
 +      if (at) {
 +              char *name_str = xmemdupz(name, at);
 +              branch = branch_get(name_str);
 +              free(name_str);
 +      } else
 +              branch = branch_get(NULL);
 +
 +      value = get_data(branch, &err);
 +      if (!value)
 +              die("%s", err.buf);
 +
 +      if (!branch_interpret_allowed(value, allowed))
 +              return -1;
 +
 +      set_shortened_ref(buf, value);
 +      return len + at;
 +}
 +
 +int interpret_branch_name(const char *name, int namelen, struct strbuf *buf,
 +                        unsigned allowed)
 +{
 +      char *at;
 +      const char *start;
 +      int len;
 +
 +      if (!namelen)
 +              namelen = strlen(name);
 +
 +      if (!allowed || (allowed & INTERPRET_BRANCH_LOCAL)) {
 +              len = interpret_nth_prior_checkout(name, namelen, buf);
 +              if (!len) {
 +                      return len; /* syntax Ok, not enough switches */
 +              } else if (len > 0) {
 +                      if (len == namelen)
 +                              return len; /* consumed all */
 +                      else
 +                              return reinterpret(name, namelen, len, buf, allowed);
 +              }
 +      }
 +
 +      for (start = name;
 +           (at = memchr(start, '@', namelen - (start - name)));
 +           start = at + 1) {
 +
 +              if (!allowed || (allowed & INTERPRET_BRANCH_HEAD)) {
 +                      len = interpret_empty_at(name, namelen, at - name, buf);
 +                      if (len > 0)
 +                              return reinterpret(name, namelen, len, buf,
 +                                                 allowed);
 +              }
 +
 +              len = interpret_branch_mark(name, namelen, at - name, buf,
 +                                          upstream_mark, branch_get_upstream,
 +                                          allowed);
 +              if (len > 0)
 +                      return len;
 +
 +              len = interpret_branch_mark(name, namelen, at - name, buf,
 +                                          push_mark, branch_get_push,
 +                                          allowed);
 +              if (len > 0)
 +                      return len;
 +      }
 +
 +      return -1;
 +}
 +
 +void strbuf_branchname(struct strbuf *sb, const char *name, unsigned allowed)
 +{
 +      int len = strlen(name);
 +      int used = interpret_branch_name(name, len, sb, allowed);
 +
 +      if (used < 0)
 +              used = 0;
 +      strbuf_add(sb, name + used, len - used);
 +}
 +
 +int strbuf_check_branch_ref(struct strbuf *sb, const char *name)
 +{
 +      if (startup_info->have_repository)
 +              strbuf_branchname(sb, name, INTERPRET_BRANCH_LOCAL);
 +      else
 +              strbuf_addstr(sb, name);
 +
 +      /*
 +       * This splice must be done even if we end up rejecting the
 +       * name; builtin/branch.c::copy_or_rename_branch() still wants
 +       * to see what the name expanded to so that "branch -m" can be
 +       * used as a tool to correct earlier mistakes.
 +       */
 +      strbuf_splice(sb, 0, 0, "refs/heads/", 11);
 +
 +      if (*name == '-' ||
 +          !strcmp(sb->buf, "refs/heads/HEAD"))
 +              return -1;
 +
 +      return check_refname_format(sb->buf, 0);
 +}
 +
 +/*
 + * This is like "get_oid_basic()", except it allows "object ID expressions",
 + * notably "xyz^" for "parent of xyz"
 + */
 +int get_oid(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, 0, oid, &unused);
 +}
 +
 +
 +/*
 + * Many callers know that the user meant to name a commit-ish by
 + * syntactical positions where the object name appears.  Calling this
 + * function allows the machinery to disambiguate shorter-than-unique
 + * abbreviated object names between commit-ish and others.
 + *
 + * Note that this does NOT error out when the named object is not a
 + * commit-ish. It is merely to give a hint to the disambiguation
 + * machinery.
 + */
 +int get_oid_committish(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, GET_OID_COMMITTISH,
 +                                  oid, &unused);
 +}
 +
 +int get_oid_treeish(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, GET_OID_TREEISH,
 +                                  oid, &unused);
 +}
 +
 +int get_oid_commit(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, GET_OID_COMMIT,
 +                                  oid, &unused);
 +}
 +
 +int get_oid_tree(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, GET_OID_TREE,
 +                                  oid, &unused);
 +}
 +
 +int get_oid_blob(const char *name, struct object_id *oid)
 +{
 +      struct object_context unused;
 +      return get_oid_with_context(name, GET_OID_BLOB,
 +                                  oid, &unused);
 +}
 +
 +/* Must be called only when object_name:filename doesn't exist. */
 +static void diagnose_invalid_oid_path(const char *prefix,
 +                                    const char *filename,
 +                                    const struct object_id *tree_oid,
 +                                    const char *object_name,
 +                                    int object_name_len)
 +{
 +      struct object_id oid;
 +      unsigned mode;
 +
 +      if (!prefix)
 +              prefix = "";
 +
 +      if (file_exists(filename))
 +              die("Path '%s' exists on disk, but not in '%.*s'.",
 +                  filename, object_name_len, object_name);
 +      if (is_missing_file_error(errno)) {
 +              char *fullname = xstrfmt("%s%s", prefix, filename);
 +
 +              if (!get_tree_entry(tree_oid, fullname, &oid, &mode)) {
 +                      die("Path '%s' exists, but not '%s'.\n"
 +                          "Did you mean '%.*s:%s' aka '%.*s:./%s'?",
 +                          fullname,
 +                          filename,
 +                          object_name_len, object_name,
 +                          fullname,
 +                          object_name_len, object_name,
 +                          filename);
 +              }
 +              die("Path '%s' does not exist in '%.*s'",
 +                  filename, object_name_len, object_name);
 +      }
 +}
 +
 +/* Must be called only when :stage:filename doesn't exist. */
 +static void diagnose_invalid_index_path(int stage,
 +                                      const char *prefix,
 +                                      const char *filename)
 +{
 +      const struct cache_entry *ce;
 +      int pos;
 +      unsigned namelen = strlen(filename);
 +      struct strbuf fullname = STRBUF_INIT;
 +
 +      if (!prefix)
 +              prefix = "";
 +
 +      /* Wrong stage number? */
 +      pos = cache_name_pos(filename, namelen);
 +      if (pos < 0)
 +              pos = -pos - 1;
 +      if (pos < active_nr) {
 +              ce = active_cache[pos];
 +              if (ce_namelen(ce) == namelen &&
 +                  !memcmp(ce->name, filename, namelen))
 +                      die("Path '%s' is in the index, but not at stage %d.\n"
 +                          "Did you mean ':%d:%s'?",
 +                          filename, stage,
 +                          ce_stage(ce), filename);
 +      }
 +
 +      /* Confusion between relative and absolute filenames? */
 +      strbuf_addstr(&fullname, prefix);
 +      strbuf_addstr(&fullname, filename);
 +      pos = cache_name_pos(fullname.buf, fullname.len);
 +      if (pos < 0)
 +              pos = -pos - 1;
 +      if (pos < active_nr) {
 +              ce = active_cache[pos];
 +              if (ce_namelen(ce) == fullname.len &&
 +                  !memcmp(ce->name, fullname.buf, fullname.len))
 +                      die("Path '%s' is in the index, but not '%s'.\n"
 +                          "Did you mean ':%d:%s' aka ':%d:./%s'?",
 +                          fullname.buf, filename,
 +                          ce_stage(ce), fullname.buf,
 +                          ce_stage(ce), filename);
 +      }
 +
 +      if (file_exists(filename))
 +              die("Path '%s' exists on disk, but not in the index.", filename);
 +      if (is_missing_file_error(errno))
 +              die("Path '%s' does not exist (neither on disk nor in the index).",
 +                  filename);
 +
 +      strbuf_release(&fullname);
 +}
 +
 +
 +static char *resolve_relative_path(const char *rel)
 +{
 +      if (!starts_with(rel, "./") && !starts_with(rel, "../"))
 +              return NULL;
 +
 +      if (!is_inside_work_tree())
 +              die("relative path syntax can't be used outside working tree.");
 +
 +      /* die() inside prefix_path() if resolved path is outside worktree */
 +      return prefix_path(startup_info->prefix,
 +                         startup_info->prefix ? strlen(startup_info->prefix) : 0,
 +                         rel);
 +}
 +
 +static int get_oid_with_context_1(const char *name,
 +                                unsigned flags,
 +                                const char *prefix,
 +                                struct object_id *oid,
 +                                struct object_context *oc)
 +{
 +      int ret, bracket_depth;
 +      int namelen = strlen(name);
 +      const char *cp;
 +      int only_to_die = flags & GET_OID_ONLY_TO_DIE;
 +
 +      if (only_to_die)
 +              flags |= GET_OID_QUIETLY;
 +
 +      memset(oc, 0, sizeof(*oc));
 +      oc->mode = S_IFINVALID;
 +      strbuf_init(&oc->symlink_path, 0);
 +      ret = get_oid_1(name, namelen, oid, flags);
 +      if (!ret)
 +              return ret;
 +      /*
 +       * sha1:path --> object name of path in ent sha1
 +       * :path -> object name of absolute path in index
 +       * :./path -> object name of path relative to cwd in index
 +       * :[0-3]:path -> object name of path in index at stage
 +       * :/foo -> recent commit matching foo
 +       */
 +      if (name[0] == ':') {
 +              int stage = 0;
 +              const struct cache_entry *ce;
 +              char *new_path = NULL;
 +              int pos;
 +              if (!only_to_die && namelen > 2 && name[1] == '/') {
 +                      struct commit_list *list = NULL;
 +
 +                      for_each_ref(handle_one_ref, &list);
 +                      commit_list_sort_by_date(&list);
 +                      return get_oid_oneline(name + 2, oid, list);
 +              }
 +              if (namelen < 3 ||
 +                  name[2] != ':' ||
 +                  name[1] < '0' || '3' < name[1])
 +                      cp = name + 1;
 +              else {
 +                      stage = name[1] - '0';
 +                      cp = name + 3;
 +              }
 +              new_path = resolve_relative_path(cp);
 +              if (!new_path) {
 +                      namelen = namelen - (cp - name);
 +              } else {
 +                      cp = new_path;
 +                      namelen = strlen(cp);
 +              }
 +
 +              if (flags & GET_OID_RECORD_PATH)
 +                      oc->path = xstrdup(cp);
 +
 +              if (!active_cache)
 +                      read_cache();
 +              pos = cache_name_pos(cp, namelen);
 +              if (pos < 0)
 +                      pos = -pos - 1;
 +              while (pos < active_nr) {
 +                      ce = active_cache[pos];
 +                      if (ce_namelen(ce) != namelen ||
 +                          memcmp(ce->name, cp, namelen))
 +                              break;
 +                      if (ce_stage(ce) == stage) {
 +                              oidcpy(oid, &ce->oid);
 +                              oc->mode = ce->ce_mode;
 +                              free(new_path);
 +                              return 0;
 +                      }
 +                      pos++;
 +              }
 +              if (only_to_die && name[1] && name[1] != '/')
 +                      diagnose_invalid_index_path(stage, prefix, cp);
 +              free(new_path);
 +              return -1;
 +      }
 +      for (cp = name, bracket_depth = 0; *cp; cp++) {
 +              if (*cp == '{')
 +                      bracket_depth++;
 +              else if (bracket_depth && *cp == '}')
 +                      bracket_depth--;
 +              else if (!bracket_depth && *cp == ':')
 +                      break;
 +      }
 +      if (*cp == ':') {
 +              struct object_id tree_oid;
 +              int len = cp - name;
 +              unsigned sub_flags = flags;
 +
 +              sub_flags &= ~GET_OID_DISAMBIGUATORS;
 +              sub_flags |= GET_OID_TREEISH;
 +
 +              if (!get_oid_1(name, len, &tree_oid, sub_flags)) {
 +                      const char *filename = cp+1;
 +                      char *new_filename = NULL;
 +
 +                      new_filename = resolve_relative_path(filename);
 +                      if (new_filename)
 +                              filename = new_filename;
 +                      if (flags & GET_OID_FOLLOW_SYMLINKS) {
 +                              ret = get_tree_entry_follow_symlinks(tree_oid.hash,
 +                                      filename, oid->hash, &oc->symlink_path,
 +                                      &oc->mode);
 +                      } else {
 +                              ret = get_tree_entry(&tree_oid, filename, oid,
 +                                                   &oc->mode);
 +                              if (ret && only_to_die) {
 +                                      diagnose_invalid_oid_path(prefix,
 +                                                                 filename,
 +                                                                 &tree_oid,
 +                                                                 name, len);
 +                              }
 +                      }
 +                      hashcpy(oc->tree, tree_oid.hash);
 +                      if (flags & GET_OID_RECORD_PATH)
 +                              oc->path = xstrdup(filename);
 +
 +                      free(new_filename);
 +                      return ret;
 +              } else {
 +                      if (only_to_die)
 +                              die("Invalid object name '%.*s'.", len, name);
 +              }
 +      }
 +      return ret;
 +}
 +
 +/*
 + * Call this function when you know "name" given by the end user must
 + * name an object but it doesn't; the function _may_ die with a better
 + * diagnostic message than "no such object 'name'", e.g. "Path 'doc' does not
 + * exist in 'HEAD'" when given "HEAD:doc", or it may return in which case
 + * you have a chance to diagnose the error further.
 + */
 +void maybe_die_on_misspelt_object_name(const char *name, const char *prefix)
 +{
 +      struct object_context oc;
 +      struct object_id oid;
 +      get_oid_with_context_1(name, GET_OID_ONLY_TO_DIE, prefix, &oid, &oc);
 +}
 +
 +int get_oid_with_context(const char *str, unsigned flags, struct object_id *oid, struct object_context *oc)
 +{
 +      if (flags & GET_OID_FOLLOW_SYMLINKS && flags & GET_OID_ONLY_TO_DIE)
 +              die("BUG: incompatible flags for get_sha1_with_context");
 +      return get_oid_with_context_1(str, flags, NULL, oid, oc);
 +}
diff --combined tree.c
index 1c68ea586bd30d3e3389efa1c83f25ed607d1d80,dec53f3ecae066aa8f9389fad836a75873df1a7f..244eb5e665e931a6b735366d74b5ed2bcbce4c9b
--- 1/tree.c
--- 2/tree.c
+++ b/tree.c
@@@ -10,7 -10,7 +10,7 @@@
  const char *tree_type = "tree";
  
  static int read_one_entry_opt(struct index_state *istate,
 -                            const unsigned char *sha1,
 +                            const struct object_id *oid,
                              const char *base, int baselen,
                              const char *pathname,
                              unsigned mode, int stage, int opt)
        ce->ce_namelen = baselen + len;
        memcpy(ce->name, base, baselen);
        memcpy(ce->name + baselen, pathname, len+1);
 -      hashcpy(ce->oid.hash, sha1);
 +      oidcpy(&ce->oid, oid);
        return add_index_entry(istate, ce, opt);
  }
  
 -static int read_one_entry(const unsigned char *sha1, struct strbuf *base,
 +static int read_one_entry(const struct object_id *oid, struct strbuf *base,
                          const char *pathname, unsigned mode, int stage,
                          void *context)
  {
        struct index_state *istate = context;
 -      return read_one_entry_opt(istate, sha1, base->buf, base->len, pathname,
 +      return read_one_entry_opt(istate, oid, base->buf, base->len, pathname,
                                  mode, stage,
                                  ADD_CACHE_OK_TO_ADD|ADD_CACHE_SKIP_DFCHECK);
  }
   * This is used when the caller knows there is no existing entries at
   * the stage that will conflict with the entry being added.
   */
 -static int read_one_entry_quick(const unsigned char *sha1, struct strbuf *base,
 +static int read_one_entry_quick(const struct object_id *oid, struct strbuf *base,
                                const char *pathname, unsigned mode, int stage,
                                void *context)
  {
        struct index_state *istate = context;
 -      return read_one_entry_opt(istate, sha1, base->buf, base->len, pathname,
 +      return read_one_entry_opt(istate, oid, base->buf, base->len, pathname,
                                  mode, stage,
                                  ADD_CACHE_JUST_APPEND);
  }
@@@ -83,7 -83,7 +83,7 @@@ static int read_tree_1(struct tree *tre
                                continue;
                }
  
 -              switch (fn(entry.oid->hash, base,
 +              switch (fn(entry.oid, base,
                           entry.path, entry.mode, stage, context)) {
                case 0:
                        continue;
                                    oid_to_hex(entry.oid),
                                    base->buf, entry.path);
  
-                       oidcpy(&oid, &commit->tree->object.oid);
+                       oidcpy(&oid, get_commit_tree_oid(commit));
                }
                else
                        continue;
@@@ -219,7 -219,7 +219,7 @@@ int parse_tree_gently(struct tree *item
  
        if (item->object.parsed)
                return 0;
 -      buffer = read_sha1_file(item->object.oid.hash, &type, &size);
 +      buffer = read_object_file(&item->object.oid, &type, &size);
        if (!buffer)
                return quiet_on_missing ? -1 :
                        error("Could not read %s",
@@@ -248,7 -248,7 +248,7 @@@ struct tree *parse_tree_indirect(const 
                if (obj->type == OBJ_TREE)
                        return (struct tree *) obj;
                else if (obj->type == OBJ_COMMIT)
-                       obj = &(((struct commit *) obj)->tree->object);
+                       obj = &(get_commit_tree(((struct commit *)obj))->object);
                else if (obj->type == OBJ_TAG)
                        obj = ((struct tag *) obj)->tagged;
                else
diff --combined walker.c
index 8eb7db7a52782c9862718979e5270724fd982d1f,f51b8558723354aad4dbfeb7764baa97893f6c1c..0b162a09b95a3eadeef47f3e6d314d386215cc9f
+++ b/walker.c
@@@ -72,8 -72,6 +72,8 @@@ static struct commit_list *complete = N
  
  static int process_commit(struct walker *walker, struct commit *commit)
  {
 +      struct commit_list *parents;
 +
        if (parse_commit(commit))
                return -1;
  
  
        walker_say(walker, "walk %s\n", oid_to_hex(&commit->object.oid));
  
-       if (process(walker, &commit->tree->object))
 -      if (walker->get_tree) {
 -              if (process(walker, &get_commit_tree(commit)->object))
++      if (process(walker, &get_commit_tree(commit)->object))
 +              return -1;
 +
 +      for (parents = commit->parents; parents; parents = parents->next) {
 +              if (process(walker, &parents->item->object))
                        return -1;
 -              if (!walker->get_all)
 -                      walker->get_tree = 0;
 -      }
 -      if (walker->get_history) {
 -              struct commit_list *parents = commit->parents;
 -              for (; parents; parents = parents->next) {
 -                      if (process(walker, &parents->item->object))
 -                              return -1;
 -              }
        }
 +
        return 0;
  }