perl: bump the required Perl version to 5.8 from 5.6.[21]

Formalize our dependency on perl 5.8, bumped from 5.6.[12]. We already
used the three-arg form of open() which was introduced in 5.6.1, but
t/t9700/test.pl explicitly depended on 5.6.2.

However git-add--interactive.pl has been failing on the 5.6 line since
it was introduced in v1.5.0-rc0~12^2~2 back in 2006 due to this open
syntax:

sub run_cmd_pipe {
my $fh = undef;
open($fh, '-|', @_) or die;
return <$fh>;
}

Which when executed dies on "Can't use an undefined value as
filehandle reference". Several of our tests also fail on 5.6 (even
more when compiled with NO_PERL_MAKEMAKER=1):

t2016-checkout-patch.sh
t3904-stash-patch.sh
t3701-add-interactive.sh
t7105-reset-patch.sh
t7501-commit.sh
t9700-perl-git.sh

Our code is bitrotting on 5.6 with no-one interested in fixing it, and
pinning us to such an ancient release of Perl is keeping us from using
useful features introduced in the 5.8 release.

The 5.6 series is now over 10 years old, and the 5.6.2 maintenance
release almost 7. 5.8 on the other hand is more than 8 years old.

All the modern Unix-like operating systems have now upgraded to it or
a later version, and 5.8 packages are available for old IRIX, AIX
Solaris and Tru64 systems.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Tor Arntsen <tor@spacetec.no>
Acked-by: Randal L. Schwartz <merlyn@stonehenge.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/INSTALL b/INSTALL
index 59200b730ec00a63f981691f7fd37f2eacb11653..10a1cba643cc9e6cc9a441708b1d43f468fb8383 100644 (file)
--- a/INSTALL
+++ b/INSTALL
@@ -67,10 +67,10 @@ Issues of note:
        - A POSIX-compliant shell is required to run many scripts needed
          for everyday use (e.g. "bisect", "pull").
 
        - A POSIX-compliant shell is required to run many scripts needed
          for everyday use (e.g. "bisect", "pull").
 

-       - "Perl" is needed to use some of the features (e.g. preparing a
-         partial commit using "git add -i/-p", interacting with svn
-         repositories with "git svn").  If you can live without these, use
-         NO_PERL.
+       - "Perl" version 5.8 or later is needed to use some of the
+         features (e.g. preparing a partial commit using "git add -i/-p",
+         interacting with svn repositories with "git svn").  If you can
+         live without these, use NO_PERL.

 
        - "openssl" library is used by git-imap-send to use IMAP over SSL.
          If you don't need it, use NO_OPENSSL.
 
        - "openssl" library is used by git-imap-send to use IMAP over SSL.
          If you don't need it, use NO_OPENSSL.

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index 27fc79347af428dd39daa5b550814cc6cf980510..a96fb53156214177701c12f8995b277059e55ebd 100755 (executable)
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 
 #!/usr/bin/perl -w
 

+use 5.008;

 use strict;
 use Git;
 
 use strict;
 use Git;
 

diff --git a/git-archimport.perl b/git-archimport.perl
index 98f3ede566a6cb0c902ce84795f7de8f8afbe633..947638c38d8a4cf0e5df53d5a4890f141cc393f8 100755 (executable)
--- a/git-archimport.perl
+++ b/git-archimport.perl
@@ -54,6 +54,7 @@ =head1 Devel Notes
 
 =cut
 
 
 =cut
 

+use 5.008;

 use strict;
 use warnings;
 use Getopt::Std;
 use strict;
 use warnings;
 use Getopt::Std;

diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index 59b672213bfc36f95db089f0e13bafc1c2f2ed71..9a8188bba785ad68d47ec7b277b016ee76e46f4c 100755 (executable)
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 
 #!/usr/bin/perl -w
 

+use 5.008;

 use strict;
 use Getopt::Std;
 use File::Temp qw(tempdir);
 use strict;
 use Getopt::Std;
 use File::Temp qw(tempdir);

diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 9e03eee4586ca3b7476b56f66e9dcf6ffe3088cf..53869fb644c24cca17ccfef73d31cbc5fe8578bd 100755 (executable)
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -13,6 +13,7 @@
 # The head revision is on branch "origin" by default.
 # You can change that with the '-o' option.
 
 # The head revision is on branch "origin" by default.
 # You can change that with the '-o' option.
 

+use 5.008;

 use strict;
 use warnings;
 use Getopt::Long;
 use strict;
 use warnings;
 use Getopt::Long;

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index e9f3037df351ceed0262a8995f19903464163af8..2822bed1fdf6977cd415461bc48630a4996f7084 100755 (executable)
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -15,6 +15,7 @@
 ####
 ####
 
 ####
 ####
 

+use 5.008;

 use strict;
 use warnings;
 use bytes;
 use strict;
 use warnings;
 use bytes;

diff --git a/git-difftool.perl b/git-difftool.perl
index adc42de8752fd395707f1e395c61991b3146cebb..e95e4ad973f21dd104950dc6ebb28485844b36f4 100755 (executable)
--- a/git-difftool.perl
+++ b/git-difftool.perl
@@ -10,6 +10,7 @@
 #
 # Any arguments that are unknown to this script are forwarded to 'git diff'.
 
 #
 # Any arguments that are unknown to this script are forwarded to 'git diff'.
 

+use 5.008;

 use strict;
 use warnings;
 use Cwd qw(abs_path);
 use strict;
 use warnings;
 use Cwd qw(abs_path);

diff --git a/git-relink.perl b/git-relink.perl
index 937c69a74858a8a3c63bb41a23705b579df1b3a3..af2e305fa39aa1b04ffaca7f026eb2a3dda71b0d 100755 (executable)
--- a/git-relink.perl
+++ b/git-relink.perl
@@ -6,7 +6,7 @@
 #
 # Scan two git object-trees, and hardlink any common objects between them.
 
 #
 # Scan two git object-trees, and hardlink any common objects between them.
 

-use 5.006;
+use 5.008;

 use strict;
 use warnings;
 use Getopt::Long;
 use strict;
 use warnings;
 use Getopt::Long;

diff --git a/git-send-email.perl b/git-send-email.perl
index 6dab3bf6a74bb52c7294e33dbac5bf87b51a9fdf..314e59e7a9f14d8bf1106cf5f5dd73da65f30905 100755 (executable)
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -16,6 +16,7 @@
 #    and second line is the subject of the message.
 #
 
 #    and second line is the subject of the message.
 #
 

+use 5.008;

 use strict;
 use warnings;
 use Term::ReadLine;
 use strict;
 use warnings;
 use Term::ReadLine;

diff --git a/git-svn.perl b/git-svn.perl
index 9b046b693fe82c992b3844bf6e8f79214dfa7a59..d2922245aa76448e551a4b427e7c8c721527952d 100755 (executable)
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1,6 +1,7 @@
 #!/usr/bin/env perl
 # Copyright (C) 2006, Eric Wong <normalperson@yhbt.net>
 # License: GPL v2 or later
 #!/usr/bin/env perl
 # Copyright (C) 2006, Eric Wong <normalperson@yhbt.net>
 # License: GPL v2 or later

+use 5.008;

 use warnings;
 use strict;
 use vars qw/   $AUTHOR $VERSION
 use warnings;
 use strict;
 use vars qw/   $AUTHOR $VERSION

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a85e2f63197649bff4842ea2970448205618c104..e645d4a821f7eab28911f508923abd3e9a9dc53b 100755 (executable)
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7,6 +7,7 @@
 #
 # This program is licensed under the GPLv2
 
 #
 # This program is licensed under the GPLv2
 

+use 5.008;

 use strict;
 use warnings;
 use CGI qw(:standard :escapeHTML -nosticky);
 use strict;
 use warnings;
 use CGI qw(:standard :escapeHTML -nosticky);

diff --git a/perl/Git.pm b/perl/Git.pm
index 6cb0dd19344ba1169b23b7e4949033f8a9088a00..205e48aa3a7b912005565ac9c296205a897a1476 100644 (file)
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -7,6 +7,7 @@ =head1 NAME
 
 package Git;
 
 
 package Git;
 

+use 5.008;

 use strict;
 
 
 use strict;
 
 

diff --git a/t/t7006/test-terminal.perl b/t/t7006/test-terminal.perl
index 73ff80937195f3ee8d4bf647a6c06bef23bb8891..6b5f22ae4a3ca96a22fa0a7d77bac1b59e747b00 100755 (executable)
--- a/t/t7006/test-terminal.perl
+++ b/t/t7006/test-terminal.perl
@@ -1,4 +1,5 @@
 #!/usr/bin/perl
 #!/usr/bin/perl

+use 5.008;

 use strict;
 use warnings;
 use IO::Pty;
 use strict;
 use warnings;
 use IO::Pty;

diff --git a/t/t9700/test.pl b/t/t9700/test.pl
index 671f38db2bb78c076b281602ca5b87f10fdf4d00..c15ca2d6479a814d7649a38a671a554b6ed8b68f 100755 (executable)
--- a/t/t9700/test.pl
+++ b/t/t9700/test.pl
@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 use lib (split(/:/, $ENV{GITPERLLIB}));
 
 #!/usr/bin/perl
 use lib (split(/:/, $ENV{GITPERLLIB}));
 

-use 5.006002;
+use 5.008;

 use warnings;
 use strict;
 
 use warnings;
 use strict;