gitweb: Check git base URLs before generating URL from it
authorJakub Narebski <jnareb@gmail.com>
Thu, 26 Oct 2006 10:26:44 +0000 (12:26 +0200)
committerJunio C Hamano <junkio@cox.net>
Fri, 27 Oct 2006 09:12:56 +0000 (02:12 -0700)
Check if each of git base URLs in @git_base_url_list is true before
appending "/$project" to it to generate project URL.

This fixes the error that for default configuration for gitweb in
Makefile, with GITWEB_BASE_URL empty (and "++GITWEB_BASE_URL++" being
"" in gitweb.cgi), we had URL of "/$project" in the summary view.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.perl
index 2390603e97a970f47a6f54466e92483ea2649da3..05e7b1253bcd6d92bdd8482e1943ab80b95aacac 100755 (executable)
@@ -69,7 +69,7 @@
 
 # list of git base URLs used for URL to where fetch project from,
 # i.e. full URL is "$git_base_url/$project"
-our @git_base_url_list = ("++GITWEB_BASE_URL++");
+our @git_base_url_list = grep { $_ ne '' } ("++GITWEB_BASE_URL++");
 
 # default blob_plain mimetype and default charset for text/plain blob
 our $default_blob_plain_mimetype = 'text/plain';