Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
CodingGuidelines: once it is in, it is not worth the code churn
author
Junio C Hamano
<gitster@pobox.com>
Wed, 30 Apr 2014 21:23:26 +0000
(14:23 -0700)
committer
Junio C Hamano
<gitster@pobox.com>
Fri, 2 May 2014 20:24:57 +0000
(13:24 -0700)
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/CodingGuidelines
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
7e76a2f
)
diff --git
a/Documentation/CodingGuidelines
b/Documentation/CodingGuidelines
index f424dbd75c80abb4d6fecce18f6fc25859bdcb00..c405b0b9dff81fa00c5aa03ba6cb2222dceac9f8 100644
(file)
--- a/
Documentation/CodingGuidelines
+++ b/
Documentation/CodingGuidelines
@@
-18,6
+18,14
@@
code. For Git in general, three rough rules are:
judgement call, the decision based more on real world
constraints people face than what the paper standard says.
judgement call, the decision based more on real world
constraints people face than what the paper standard says.
+ - Fixing style violations while working on a real change as a
+ preparatory clean-up step is good, but otherwise avoid useless code
+ churn for the sake of conforming to the style.
+
+ "Once it _is_ in the tree, it's not really worth the patch noise to
+ go and fix it up."
+ Cf. http://article.gmane.org/gmane.linux.kernel/943020
+
Make your code readable and sensible, and don't try to be clever.
As for more concrete guidelines, just imitate the existing code
Make your code readable and sensible, and don't try to be clever.
As for more concrete guidelines, just imitate the existing code