tests: don't give unportable ">" to "test" built-in, use -gt
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sun, 6 Aug 2017 23:38:50 +0000 (23:38 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 7 Aug 2017 17:32:11 +0000 (10:32 -0700)
Change an argument to test_line_count (which'll ultimately be turned
into a "test" expression) to use "-gt" instead of ">" for an
arithmetic test.

This broken on e.g. OpenBSD as of v2.13.0 with my commit
ac3f5a3468 ("ref-filter: add --no-contains option to
tag/branch/for-each-ref", 2017-03-24).

Downstream just worked around it by patching git and didn't tell us
about it, I discovered this when reading various Git packaging
implementations: https://github.com/openbsd/ports/commit/7e48bf88a20

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t7004-tag.sh
index 6143113dbbd92a7468e86a5ee1dbc22ba78e3a17..c6791cf396a29d5b80906ee662c2f1036f372f67 100755 (executable)
@@ -1889,7 +1889,7 @@ EOF"
        run_with_limited_stack git tag --contains HEAD >actual &&
        test_cmp expect actual &&
        run_with_limited_stack git tag --no-contains HEAD >actual &&
-       test_line_count ">" 10 actual
+       test_line_count "-gt" 10 actual
 '
 
 test_expect_success '--format should list tags as per format given' '