Add explanatory comment for transport-helpers refs mapping.
authorFlorian Achleitner <florian.achleitner.2.6.31@gmail.com>
Mon, 30 Jul 2012 14:31:18 +0000 (16:31 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 30 Jul 2012 19:22:35 +0000 (12:22 -0700)
The patch below adds a comment to fetch_with_import() explaining the
loop that saves the fetched commit names after 'git fast-import' has
done its work. It avoids some confusion about which refs the
fast-import stream is supposed to use to write its result.

Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
transport-helper.c
index 61c928f6cd85aa9cf60942208423e615c9b99352..cfe098849022fcc56bcb1a57d00e4c89e753492b 100644 (file)
@@ -444,6 +444,21 @@ static int fetch_with_import(struct transport *transport,
        free(fastimport.argv);
        fastimport.argv = NULL;
 
+       /*
+        * The fast-import stream of a remote helper that advertises
+        * the "refspec" capability writes to the refs named after the
+        * right hand side of the first refspec matching each ref we
+        * were fetching.
+        *
+        * (If no "refspec" capability was specified, for historical
+        * reasons we default to *:*.)
+        *
+        * Store the result in to_fetch[i].old_sha1.  Callers such
+        * as "git fetch" can use the value to write feedback to the
+        * terminal, populate FETCH_HEAD, and determine what new value
+        * should be written to peer_ref if the update is a
+        * fast-forward or this is a forced update.
+        */
        for (i = 0; i < nr_heads; i++) {
                char *private;
                posn = to_fetch[i];