Merge branch 'nd/grep-true-path'
authorJeff King <peff@peff.net>
Mon, 29 Oct 2012 08:13:16 +0000 (04:13 -0400)
committerJeff King <peff@peff.net>
Mon, 29 Oct 2012 08:13:16 +0000 (04:13 -0400)
"git grep -e pattern <tree>" asked the attribute system to read
"<tree>:.gitattributes" file in the working tree, which was
nonsense.

* nd/grep-true-path:
grep: stop looking at random places for .gitattributes

1  2 
builtin/grep.c
grep.c
grep.h
diff --combined builtin/grep.c
index c296e6f99e0c96807c2d95f3e396d01878e1f04b,973b1f6e98092a961c9bb410f66f64c1f5cd6448..0e1b6c860e18c6c47f343fad885cbd24f641862e
@@@ -19,7 -19,7 +19,7 @@@
  #include "dir.h"
  
  static char const * const grep_usage[] = {
 -      "git grep [options] [-e] <pattern> [<rev>...] [[--] <path>...]",
 +      N_("git grep [options] [-e] <pattern> [<rev>...] [[--] <path>...]"),
        NULL
  };
  
@@@ -86,7 -86,7 +86,7 @@@ static pthread_cond_t cond_result
  static int skip_first_line;
  
  static void add_work(struct grep_opt *opt, enum grep_source_type type,
-                    const char *name, const void *id)
+                    const char *name, const char *path, const void *id)
  {
        grep_lock();
  
@@@ -94,7 -94,7 +94,7 @@@
                pthread_cond_wait(&cond_write, &grep_mutex);
        }
  
-       grep_source_init(&todo[todo_end].source, type, name, id);
+       grep_source_init(&todo[todo_end].source, type, name, path, id);
        if (opt->binary != GREP_BINARY_TEXT)
                grep_source_load_driver(&todo[todo_end].source);
        todo[todo_end].done = 0;
@@@ -261,12 -261,51 +261,12 @@@ static int wait_all(void
  }
  #endif
  
 -static int grep_config(const char *var, const char *value, void *cb)
 +static int grep_cmd_config(const char *var, const char *value, void *cb)
  {
 -      struct grep_opt *opt = cb;
 -      char *color = NULL;
 -
 -      if (userdiff_config(var, value) < 0)
 -              return -1;
 -
 -      if (!strcmp(var, "grep.extendedregexp")) {
 -              if (git_config_bool(var, value))
 -                      opt->regflags |= REG_EXTENDED;
 -              else
 -                      opt->regflags &= ~REG_EXTENDED;
 -              return 0;
 -      }
 -
 -      if (!strcmp(var, "grep.linenumber")) {
 -              opt->linenum = git_config_bool(var, value);
 -              return 0;
 -      }
 -
 -      if (!strcmp(var, "color.grep"))
 -              opt->color = git_config_colorbool(var, value);
 -      else if (!strcmp(var, "color.grep.context"))
 -              color = opt->color_context;
 -      else if (!strcmp(var, "color.grep.filename"))
 -              color = opt->color_filename;
 -      else if (!strcmp(var, "color.grep.function"))
 -              color = opt->color_function;
 -      else if (!strcmp(var, "color.grep.linenumber"))
 -              color = opt->color_lineno;
 -      else if (!strcmp(var, "color.grep.match"))
 -              color = opt->color_match;
 -      else if (!strcmp(var, "color.grep.selected"))
 -              color = opt->color_selected;
 -      else if (!strcmp(var, "color.grep.separator"))
 -              color = opt->color_sep;
 -      else
 -              return git_color_default_config(var, value, cb);
 -      if (color) {
 -              if (!value)
 -                      return config_error_nonbool(var);
 -              color_parse(value, var, color);
 -      }
 -      return 0;
 +      int st = grep_config(var, value, cb);
 +      if (git_color_default_config(var, value, cb) < 0)
 +              st = -1;
 +      return st;
  }
  
  static void *lock_and_read_sha1_file(const unsigned char *sha1, enum object_type *type, unsigned long *size)
  }
  
  static int grep_sha1(struct grep_opt *opt, const unsigned char *sha1,
-                    const char *filename, int tree_name_len)
+                    const char *filename, int tree_name_len,
+                    const char *path)
  {
        struct strbuf pathbuf = STRBUF_INIT;
  
  
  #ifndef NO_PTHREADS
        if (use_threads) {
-               add_work(opt, GREP_SOURCE_SHA1, pathbuf.buf, sha1);
+               add_work(opt, GREP_SOURCE_SHA1, pathbuf.buf, path, sha1);
                strbuf_release(&pathbuf);
                return 0;
        } else
                struct grep_source gs;
                int hit;
  
-               grep_source_init(&gs, GREP_SOURCE_SHA1, pathbuf.buf, sha1);
+               grep_source_init(&gs, GREP_SOURCE_SHA1, pathbuf.buf, path, sha1);
                strbuf_release(&pathbuf);
                hit = grep_source(opt, &gs);
  
@@@ -323,7 -363,7 +324,7 @@@ static int grep_file(struct grep_opt *o
  
  #ifndef NO_PTHREADS
        if (use_threads) {
-               add_work(opt, GREP_SOURCE_FILE, buf.buf, filename);
+               add_work(opt, GREP_SOURCE_FILE, buf.buf, filename, filename);
                strbuf_release(&buf);
                return 0;
        } else
                struct grep_source gs;
                int hit;
  
-               grep_source_init(&gs, GREP_SOURCE_FILE, buf.buf, filename);
+               grep_source_init(&gs, GREP_SOURCE_FILE, buf.buf, filename, filename);
                strbuf_release(&buf);
                hit = grep_source(opt, &gs);
  
@@@ -388,7 -428,7 +389,7 @@@ static int grep_cache(struct grep_opt *
                if (cached || (ce->ce_flags & CE_VALID) || ce_skip_worktree(ce)) {
                        if (ce_stage(ce))
                                continue;
-                       hit |= grep_sha1(opt, ce->sha1, ce->name, 0);
+                       hit |= grep_sha1(opt, ce->sha1, ce->name, 0, ce->name);
                }
                else
                        hit |= grep_file(opt, ce->name);
  }
  
  static int grep_tree(struct grep_opt *opt, const struct pathspec *pathspec,
-                    struct tree_desc *tree, struct strbuf *base, int tn_len)
+                    struct tree_desc *tree, struct strbuf *base, int tn_len,
+                    int check_attr)
  {
        int hit = 0;
        enum interesting match = entry_not_interesting;
                strbuf_add(base, entry.path, te_len);
  
                if (S_ISREG(entry.mode)) {
-                       hit |= grep_sha1(opt, entry.sha1, base->buf, tn_len);
+                       hit |= grep_sha1(opt, entry.sha1, base->buf, tn_len,
+                                        check_attr ? base->buf + tn_len : NULL);
                }
                else if (S_ISDIR(entry.mode)) {
                        enum object_type type;
  
                        strbuf_addch(base, '/');
                        init_tree_desc(&sub, data, size);
-                       hit |= grep_tree(opt, pathspec, &sub, base, tn_len);
+                       hit |= grep_tree(opt, pathspec, &sub, base, tn_len,
+                                        check_attr);
                        free(data);
                }
                strbuf_setlen(base, old_baselen);
@@@ -457,7 -500,7 +461,7 @@@ static int grep_object(struct grep_opt 
                       struct object *obj, const char *name)
  {
        if (obj->type == OBJ_BLOB)
-               return grep_sha1(opt, obj->sha1, name, 0);
+               return grep_sha1(opt, obj->sha1, name, 0, NULL);
        if (obj->type == OBJ_COMMIT || obj->type == OBJ_TREE) {
                struct tree_desc tree;
                void *data;
                        strbuf_addch(&base, ':');
                }
                init_tree_desc(&tree, data, size);
-               hit = grep_tree(opt, pathspec, &tree, &base, base.len);
+               hit = grep_tree(opt, pathspec, &tree, &base, base.len,
+                               obj->type == OBJ_COMMIT);
                strbuf_release(&base);
                free(data);
                return hit;
@@@ -631,88 -675,95 +636,88 @@@ int cmd_grep(int argc, const char **arg
        int i;
        int dummy;
        int use_index = 1;
 -      enum {
 -              pattern_type_unspecified = 0,
 -              pattern_type_bre,
 -              pattern_type_ere,
 -              pattern_type_fixed,
 -              pattern_type_pcre,
 -      };
 -      int pattern_type = pattern_type_unspecified;
 +      int pattern_type_arg = GREP_PATTERN_TYPE_UNSPECIFIED;
  
        struct option options[] = {
                OPT_BOOLEAN(0, "cached", &cached,
 -                      "search in index instead of in the work tree"),
 +                      N_("search in index instead of in the work tree")),
                OPT_NEGBIT(0, "no-index", &use_index,
 -                       "finds in contents not managed by git", 1),
 +                       N_("find in contents not managed by git"), 1),
                OPT_BOOLEAN(0, "untracked", &untracked,
 -                      "search in both tracked and untracked files"),
 +                      N_("search in both tracked and untracked files")),
                OPT_SET_INT(0, "exclude-standard", &opt_exclude,
 -                          "search also in ignored files", 1),
 +                          N_("search also in ignored files"), 1),
                OPT_GROUP(""),
                OPT_BOOLEAN('v', "invert-match", &opt.invert,
 -                      "show non-matching lines"),
 +                      N_("show non-matching lines")),
                OPT_BOOLEAN('i', "ignore-case", &opt.ignore_case,
 -                      "case insensitive matching"),
 +                      N_("case insensitive matching")),
                OPT_BOOLEAN('w', "word-regexp", &opt.word_regexp,
 -                      "match patterns only at word boundaries"),
 +                      N_("match patterns only at word boundaries")),
                OPT_SET_INT('a', "text", &opt.binary,
 -                      "process binary files as text", GREP_BINARY_TEXT),
 +                      N_("process binary files as text"), GREP_BINARY_TEXT),
                OPT_SET_INT('I', NULL, &opt.binary,
 -                      "don't match patterns in binary files",
 +                      N_("don't match patterns in binary files"),
                        GREP_BINARY_NOMATCH),
 -              { OPTION_INTEGER, 0, "max-depth", &opt.max_depth, "depth",
 -                      "descend at most <depth> levels", PARSE_OPT_NONEG,
 +              { OPTION_INTEGER, 0, "max-depth", &opt.max_depth, N_("depth"),
 +                      N_("descend at most <depth> levels"), PARSE_OPT_NONEG,
                        NULL, 1 },
                OPT_GROUP(""),
 -              OPT_SET_INT('E', "extended-regexp", &pattern_type,
 -                          "use extended POSIX regular expressions",
 -                          pattern_type_ere),
 -              OPT_SET_INT('G', "basic-regexp", &pattern_type,
 -                          "use basic POSIX regular expressions (default)",
 -                          pattern_type_bre),
 -              OPT_SET_INT('F', "fixed-strings", &pattern_type,
 -                          "interpret patterns as fixed strings",
 -                          pattern_type_fixed),
 -              OPT_SET_INT('P', "perl-regexp", &pattern_type,
 -                          "use Perl-compatible regular expressions",
 -                          pattern_type_pcre),
 +              OPT_SET_INT('E', "extended-regexp", &pattern_type_arg,
 +                          N_("use extended POSIX regular expressions"),
 +                          GREP_PATTERN_TYPE_ERE),
 +              OPT_SET_INT('G', "basic-regexp", &pattern_type_arg,
 +                          N_("use basic POSIX regular expressions (default)"),
 +                          GREP_PATTERN_TYPE_BRE),
 +              OPT_SET_INT('F', "fixed-strings", &pattern_type_arg,
 +                          N_("interpret patterns as fixed strings"),
 +                          GREP_PATTERN_TYPE_FIXED),
 +              OPT_SET_INT('P', "perl-regexp", &pattern_type_arg,
 +                          N_("use Perl-compatible regular expressions"),
 +                          GREP_PATTERN_TYPE_PCRE),
                OPT_GROUP(""),
 -              OPT_BOOLEAN('n', "line-number", &opt.linenum, "show line numbers"),
 -              OPT_NEGBIT('h', NULL, &opt.pathname, "don't show filenames", 1),
 -              OPT_BIT('H', NULL, &opt.pathname, "show filenames", 1),
 +              OPT_BOOLEAN('n', "line-number", &opt.linenum, N_("show line numbers")),
 +              OPT_NEGBIT('h', NULL, &opt.pathname, N_("don't show filenames"), 1),
 +              OPT_BIT('H', NULL, &opt.pathname, N_("show filenames"), 1),
                OPT_NEGBIT(0, "full-name", &opt.relative,
 -                      "show filenames relative to top directory", 1),
 +                      N_("show filenames relative to top directory"), 1),
                OPT_BOOLEAN('l', "files-with-matches", &opt.name_only,
 -                      "show only filenames instead of matching lines"),
 +                      N_("show only filenames instead of matching lines")),
                OPT_BOOLEAN(0, "name-only", &opt.name_only,
 -                      "synonym for --files-with-matches"),
 +                      N_("synonym for --files-with-matches")),
                OPT_BOOLEAN('L', "files-without-match",
                        &opt.unmatch_name_only,
 -                      "show only the names of files without match"),
 +                      N_("show only the names of files without match")),
                OPT_BOOLEAN('z', "null", &opt.null_following_name,
 -                      "print NUL after filenames"),
 +                      N_("print NUL after filenames")),
                OPT_BOOLEAN('c', "count", &opt.count,
 -                      "show the number of matches instead of matching lines"),
 -              OPT__COLOR(&opt.color, "highlight matches"),
 +                      N_("show the number of matches instead of matching lines")),
 +              OPT__COLOR(&opt.color, N_("highlight matches")),
                OPT_BOOLEAN(0, "break", &opt.file_break,
 -                      "print empty line between matches from different files"),
 +                      N_("print empty line between matches from different files")),
                OPT_BOOLEAN(0, "heading", &opt.heading,
 -                      "show filename only once above matches from same file"),
 +                      N_("show filename only once above matches from same file")),
                OPT_GROUP(""),
 -              OPT_CALLBACK('C', "context", &opt, "n",
 -                      "show <n> context lines before and after matches",
 +              OPT_CALLBACK('C', "context", &opt, N_("n"),
 +                      N_("show <n> context lines before and after matches"),
                        context_callback),
                OPT_INTEGER('B', "before-context", &opt.pre_context,
 -                      "show <n> context lines before matches"),
 +                      N_("show <n> context lines before matches")),
                OPT_INTEGER('A', "after-context", &opt.post_context,
 -                      "show <n> context lines after matches"),
 -              OPT_NUMBER_CALLBACK(&opt, "shortcut for -C NUM",
 +                      N_("show <n> context lines after matches")),
 +              OPT_NUMBER_CALLBACK(&opt, N_("shortcut for -C NUM"),
                        context_callback),
                OPT_BOOLEAN('p', "show-function", &opt.funcname,
 -                      "show a line with the function name before matches"),
 +                      N_("show a line with the function name before matches")),
                OPT_BOOLEAN('W', "function-context", &opt.funcbody,
 -                      "show the surrounding function"),
 +                      N_("show the surrounding function")),
                OPT_GROUP(""),
 -              OPT_CALLBACK('f', NULL, &opt, "file",
 -                      "read patterns from file", file_callback),
 -              { OPTION_CALLBACK, 'e', NULL, &opt, "pattern",
 -                      "match <pattern>", PARSE_OPT_NONEG, pattern_callback },
 +              OPT_CALLBACK('f', NULL, &opt, N_("file"),
 +                      N_("read patterns from file"), file_callback),
 +              { OPTION_CALLBACK, 'e', NULL, &opt, N_("pattern"),
 +                      N_("match <pattern>"), PARSE_OPT_NONEG, pattern_callback },
                { OPTION_CALLBACK, 0, "and", &opt, NULL,
 -                "combine patterns specified with -e",
 +                N_("combine patterns specified with -e"),
                  PARSE_OPT_NOARG | PARSE_OPT_NONEG, and_callback },
                OPT_BOOLEAN(0, "or", &dummy, ""),
                { OPTION_CALLBACK, 0, "not", &opt, NULL, "",
                  PARSE_OPT_NOARG | PARSE_OPT_NONEG | PARSE_OPT_NODASH,
                  close_callback },
                OPT__QUIET(&opt.status_only,
 -                         "indicate hit with exit status without output"),
 +                         N_("indicate hit with exit status without output")),
                OPT_BOOLEAN(0, "all-match", &opt.all_match,
 -                      "show only matches from files that match all patterns"),
 +                      N_("show only matches from files that match all patterns")),
                { OPTION_SET_INT, 0, "debug", &opt.debug, NULL,
 -                "show parse tree for grep expression",
 +                N_("show parse tree for grep expression"),
                  PARSE_OPT_NOARG | PARSE_OPT_HIDDEN, NULL, 1 },
                OPT_GROUP(""),
                { OPTION_STRING, 'O', "open-files-in-pager", &show_in_pager,
 -                      "pager", "show matching files in the pager",
 +                      N_("pager"), N_("show matching files in the pager"),
                        PARSE_OPT_OPTARG, NULL, (intptr_t)default_pager },
                OPT_BOOLEAN(0, "ext-grep", &external_grep_allowed__ignored,
 -                          "allow calling of grep(1) (ignored by this build)"),
 -              { OPTION_CALLBACK, 0, "help-all", &options, NULL, "show usage",
 +                          N_("allow calling of grep(1) (ignored by this build)")),
 +              { OPTION_CALLBACK, 0, "help-all", &options, NULL, N_("show usage"),
                  PARSE_OPT_HIDDEN | PARSE_OPT_NOARG, help_callback },
                OPT_END()
        };
        if (argc == 2 && !strcmp(argv[1], "-h"))
                usage_with_options(grep_usage, options);
  
 -      memset(&opt, 0, sizeof(opt));
 -      opt.prefix = prefix;
 -      opt.prefix_length = (prefix && *prefix) ? strlen(prefix) : 0;
 -      opt.relative = 1;
 -      opt.pathname = 1;
 -      opt.pattern_tail = &opt.pattern_list;
 -      opt.header_tail = &opt.header_list;
 -      opt.regflags = REG_NEWLINE;
 -      opt.max_depth = -1;
 -
 -      strcpy(opt.color_context, "");
 -      strcpy(opt.color_filename, "");
 -      strcpy(opt.color_function, "");
 -      strcpy(opt.color_lineno, "");
 -      strcpy(opt.color_match, GIT_COLOR_BOLD_RED);
 -      strcpy(opt.color_selected, "");
 -      strcpy(opt.color_sep, GIT_COLOR_CYAN);
 -      opt.color = -1;
 -      git_config(grep_config, &opt);
 +      init_grep_defaults();
 +      git_config(grep_cmd_config, NULL);
 +      grep_init(&opt, prefix);
  
        /*
         * If there is no -- then the paths must exist in the working
                             PARSE_OPT_KEEP_DASHDASH |
                             PARSE_OPT_STOP_AT_NON_OPTION |
                             PARSE_OPT_NO_INTERNAL_HELP);
 -      switch (pattern_type) {
 -      case pattern_type_fixed:
 -              opt.fixed = 1;
 -              opt.pcre = 0;
 -              break;
 -      case pattern_type_bre:
 -              opt.fixed = 0;
 -              opt.pcre = 0;
 -              opt.regflags &= ~REG_EXTENDED;
 -              break;
 -      case pattern_type_ere:
 -              opt.fixed = 0;
 -              opt.pcre = 0;
 -              opt.regflags |= REG_EXTENDED;
 -              break;
 -      case pattern_type_pcre:
 -              opt.fixed = 0;
 -              opt.pcre = 1;
 -              break;
 -      default:
 -              break; /* nothing */
 -      }
 +      grep_commit_pattern_type(pattern_type_arg, &opt);
  
        if (use_index && !startup_info->have_repository)
                /* die the same way as if we did it at the beginning */
diff --combined grep.c
index a947a68a7f26d999db02fa86ccbaa3def8cf78b4,70050d2078552502dc46dc596fc31dc62fc149b2..4bd1b8b1dd67e4f5c2223536b435198ce67463ba
--- 1/grep.c
--- 2/grep.c
+++ b/grep.c
  static int grep_source_load(struct grep_source *gs);
  static int grep_source_is_binary(struct grep_source *gs);
  
 +static struct grep_opt grep_defaults;
 +
 +/*
 + * Initialize the grep_defaults template with hardcoded defaults.
 + * We could let the compiler do this, but without C99 initializers
 + * the code gets unwieldy and unreadable, so...
 + */
 +void init_grep_defaults(void)
 +{
 +      struct grep_opt *opt = &grep_defaults;
 +      static int run_once;
 +
 +      if (run_once)
 +              return;
 +      run_once++;
 +
 +      memset(opt, 0, sizeof(*opt));
 +      opt->relative = 1;
 +      opt->pathname = 1;
 +      opt->regflags = REG_NEWLINE;
 +      opt->max_depth = -1;
 +      opt->pattern_type_option = GREP_PATTERN_TYPE_UNSPECIFIED;
 +      opt->extended_regexp_option = 0;
 +      strcpy(opt->color_context, "");
 +      strcpy(opt->color_filename, "");
 +      strcpy(opt->color_function, "");
 +      strcpy(opt->color_lineno, "");
 +      strcpy(opt->color_match, GIT_COLOR_BOLD_RED);
 +      strcpy(opt->color_selected, "");
 +      strcpy(opt->color_sep, GIT_COLOR_CYAN);
 +      opt->color = -1;
 +}
 +
 +static int parse_pattern_type_arg(const char *opt, const char *arg)
 +{
 +      if (!strcmp(arg, "default"))
 +              return GREP_PATTERN_TYPE_UNSPECIFIED;
 +      else if (!strcmp(arg, "basic"))
 +              return GREP_PATTERN_TYPE_BRE;
 +      else if (!strcmp(arg, "extended"))
 +              return GREP_PATTERN_TYPE_ERE;
 +      else if (!strcmp(arg, "fixed"))
 +              return GREP_PATTERN_TYPE_FIXED;
 +      else if (!strcmp(arg, "perl"))
 +              return GREP_PATTERN_TYPE_PCRE;
 +      die("bad %s argument: %s", opt, arg);
 +}
 +
 +/*
 + * Read the configuration file once and store it in
 + * the grep_defaults template.
 + */
 +int grep_config(const char *var, const char *value, void *cb)
 +{
 +      struct grep_opt *opt = &grep_defaults;
 +      char *color = NULL;
 +
 +      if (userdiff_config(var, value) < 0)
 +              return -1;
 +
 +      if (!strcmp(var, "grep.extendedregexp")) {
 +              if (git_config_bool(var, value))
 +                      opt->extended_regexp_option = 1;
 +              else
 +                      opt->extended_regexp_option = 0;
 +              return 0;
 +      }
 +
 +      if (!strcmp(var, "grep.patterntype")) {
 +              opt->pattern_type_option = parse_pattern_type_arg(var, value);
 +              return 0;
 +      }
 +
 +      if (!strcmp(var, "grep.linenumber")) {
 +              opt->linenum = git_config_bool(var, value);
 +              return 0;
 +      }
 +
 +      if (!strcmp(var, "color.grep"))
 +              opt->color = git_config_colorbool(var, value);
 +      else if (!strcmp(var, "color.grep.context"))
 +              color = opt->color_context;
 +      else if (!strcmp(var, "color.grep.filename"))
 +              color = opt->color_filename;
 +      else if (!strcmp(var, "color.grep.function"))
 +              color = opt->color_function;
 +      else if (!strcmp(var, "color.grep.linenumber"))
 +              color = opt->color_lineno;
 +      else if (!strcmp(var, "color.grep.match"))
 +              color = opt->color_match;
 +      else if (!strcmp(var, "color.grep.selected"))
 +              color = opt->color_selected;
 +      else if (!strcmp(var, "color.grep.separator"))
 +              color = opt->color_sep;
 +
 +      if (color) {
 +              if (!value)
 +                      return config_error_nonbool(var);
 +              color_parse(value, var, color);
 +      }
 +      return 0;
 +}
 +
 +/*
 + * Initialize one instance of grep_opt and copy the
 + * default values from the template we read the configuration
 + * information in an earlier call to git_config(grep_config).
 + */
 +void grep_init(struct grep_opt *opt, const char *prefix)
 +{
 +      struct grep_opt *def = &grep_defaults;
 +
 +      memset(opt, 0, sizeof(*opt));
 +      opt->prefix = prefix;
 +      opt->prefix_length = (prefix && *prefix) ? strlen(prefix) : 0;
 +      opt->pattern_tail = &opt->pattern_list;
 +      opt->header_tail = &opt->header_list;
 +
 +      opt->color = def->color;
 +      opt->extended_regexp_option = def->extended_regexp_option;
 +      opt->pattern_type_option = def->pattern_type_option;
 +      opt->linenum = def->linenum;
 +      opt->max_depth = def->max_depth;
 +      opt->pathname = def->pathname;
 +      opt->regflags = def->regflags;
 +      opt->relative = def->relative;
 +
 +      strcpy(opt->color_context, def->color_context);
 +      strcpy(opt->color_filename, def->color_filename);
 +      strcpy(opt->color_function, def->color_function);
 +      strcpy(opt->color_lineno, def->color_lineno);
 +      strcpy(opt->color_match, def->color_match);
 +      strcpy(opt->color_selected, def->color_selected);
 +      strcpy(opt->color_sep, def->color_sep);
 +}
 +
 +void grep_commit_pattern_type(enum grep_pattern_type pattern_type, struct grep_opt *opt)
 +{
 +      if (pattern_type != GREP_PATTERN_TYPE_UNSPECIFIED)
 +              grep_set_pattern_type_option(pattern_type, opt);
 +      else if (opt->pattern_type_option != GREP_PATTERN_TYPE_UNSPECIFIED)
 +              grep_set_pattern_type_option(opt->pattern_type_option, opt);
 +      else if (opt->extended_regexp_option)
 +              grep_set_pattern_type_option(GREP_PATTERN_TYPE_ERE, opt);
 +}
 +
 +void grep_set_pattern_type_option(enum grep_pattern_type pattern_type, struct grep_opt *opt)
 +{
 +      switch (pattern_type) {
 +      case GREP_PATTERN_TYPE_UNSPECIFIED:
 +              /* fall through */
 +
 +      case GREP_PATTERN_TYPE_BRE:
 +              opt->fixed = 0;
 +              opt->pcre = 0;
 +              opt->regflags &= ~REG_EXTENDED;
 +              break;
 +
 +      case GREP_PATTERN_TYPE_ERE:
 +              opt->fixed = 0;
 +              opt->pcre = 0;
 +              opt->regflags |= REG_EXTENDED;
 +              break;
 +
 +      case GREP_PATTERN_TYPE_FIXED:
 +              opt->fixed = 1;
 +              opt->pcre = 0;
 +              opt->regflags &= ~REG_EXTENDED;
 +              break;
 +
 +      case GREP_PATTERN_TYPE_PCRE:
 +              opt->fixed = 0;
 +              opt->pcre = 1;
 +              opt->regflags &= ~REG_EXTENDED;
 +              break;
 +      }
 +}
  
  static struct grep_pat *create_grep_pat(const char *pat, size_t patlen,
                                        const char *origin, int no,
@@@ -241,8 -64,6 +241,8 @@@ void append_header_grep_pattern(struct 
  {
        struct grep_pat *p = create_grep_pat(pat, strlen(pat), "header", 0,
                                             GREP_PATTERN_HEAD, field);
 +      if (field == GREP_HEADER_REFLOG)
 +              opt->use_reflog_filter = 1;
        do_append_grep_pat(&opt->header_tail, p);
  }
  
@@@ -876,7 -697,6 +876,7 @@@ static struct 
  } header_field[] = {
        { "author ", 7 },
        { "committer ", 10 },
 +      { "reflog ", 7 },
  };
  
  static int match_one_pattern(struct grep_pat *p, char *bol, char *eol,
                if (strncmp(bol, field, len))
                        return 0;
                bol += len;
 -              saved_ch = strip_timestamp(bol, &eol);
 +              switch (p->field) {
 +              case GREP_HEADER_AUTHOR:
 +              case GREP_HEADER_COMMITTER:
 +                      saved_ch = strip_timestamp(bol, &eol);
 +                      break;
 +              default:
 +                      break;
 +              }
        }
  
   again:
@@@ -1550,7 -1363,7 +1550,7 @@@ int grep_buffer(struct grep_opt *opt, c
        struct grep_source gs;
        int r;
  
-       grep_source_init(&gs, GREP_SOURCE_BUF, NULL, NULL);
+       grep_source_init(&gs, GREP_SOURCE_BUF, NULL, NULL, NULL);
        gs.buf = buf;
        gs.size = size;
  
  }
  
  void grep_source_init(struct grep_source *gs, enum grep_source_type type,
-                     const char *name, const void *identifier)
+                     const char *name, const char *path,
+                     const void *identifier)
  {
        gs->type = type;
        gs->name = name ? xstrdup(name) : NULL;
+       gs->path = path ? xstrdup(path) : NULL;
        gs->buf = NULL;
        gs->size = 0;
        gs->driver = NULL;
@@@ -1586,6 -1401,8 +1588,8 @@@ void grep_source_clear(struct grep_sour
  {
        free(gs->name);
        gs->name = NULL;
+       free(gs->path);
+       gs->path = NULL;
        free(gs->identifier);
        gs->identifier = NULL;
        grep_source_clear_data(gs);
@@@ -1678,7 -1495,8 +1682,8 @@@ void grep_source_load_driver(struct gre
                return;
  
        grep_attr_lock();
-       gs->driver = userdiff_find_by_path(gs->name);
+       if (gs->path)
+               gs->driver = userdiff_find_by_path(gs->path);
        if (!gs->driver)
                gs->driver = userdiff_find_by_name("default");
        grep_attr_unlock();
diff --combined grep.h
index 701c78459f95cb94487d99af1fcd0cbfe738d617,1f32944be11e7a090387eee8f7bca6d05718ad5f..8fc854f400802c3329fc3c028942de55b820ac90
--- 1/grep.h
--- 2/grep.h
+++ b/grep.h
@@@ -29,12 -29,9 +29,12 @@@ enum grep_context 
  
  enum grep_header_field {
        GREP_HEADER_AUTHOR = 0,
 -      GREP_HEADER_COMMITTER
 +      GREP_HEADER_COMMITTER,
 +      GREP_HEADER_REFLOG,
 +
 +      /* Must be at the end of the enum */
 +      GREP_HEADER_FIELD_MAX
  };
 -#define GREP_HEADER_FIELD_MAX (GREP_HEADER_COMMITTER + 1)
  
  struct grep_pat {
        struct grep_pat *next;
@@@ -61,14 -58,6 +61,14 @@@ enum grep_expr_node 
        GREP_NODE_OR
  };
  
 +enum grep_pattern_type {
 +      GREP_PATTERN_TYPE_UNSPECIFIED = 0,
 +      GREP_PATTERN_TYPE_BRE,
 +      GREP_PATTERN_TYPE_ERE,
 +      GREP_PATTERN_TYPE_FIXED,
 +      GREP_PATTERN_TYPE_PCRE
 +};
 +
  struct grep_expr {
        enum grep_expr_node node;
        unsigned hit;
@@@ -107,7 -96,6 +107,7 @@@ struct grep_opt 
  #define GREP_BINARY_TEXT      2
        int binary;
        int extended;
 +      int use_reflog_filter;
        int pcre;
        int relative;
        int pathname;
        int max_depth;
        int funcname;
        int funcbody;
 +      int extended_regexp_option;
 +      int pattern_type_option;
        char color_context[COLOR_MAXLEN];
        char color_filename[COLOR_MAXLEN];
        char color_function[COLOR_MAXLEN];
        void *output_priv;
  };
  
 +extern void init_grep_defaults(void);
 +extern int grep_config(const char *var, const char *value, void *);
 +extern void grep_init(struct grep_opt *, const char *prefix);
 +void grep_set_pattern_type_option(enum grep_pattern_type, struct grep_opt *opt);
 +void grep_commit_pattern_type(enum grep_pattern_type, struct grep_opt *opt);
 +
  extern void append_grep_pat(struct grep_opt *opt, const char *pat, size_t patlen, const char *origin, int no, enum grep_pat_token t);
  extern void append_grep_pattern(struct grep_opt *opt, const char *pat, const char *origin, int no, enum grep_pat_token t);
  extern void append_header_grep_pattern(struct grep_opt *, enum grep_header_field, const char *);
@@@ -164,11 -144,13 +164,13 @@@ struct grep_source 
        char *buf;
        unsigned long size;
  
+       char *path; /* for attribute lookups */
        struct userdiff_driver *driver;
  };
  
  void grep_source_init(struct grep_source *gs, enum grep_source_type type,
-                     const char *name, const void *identifier);
+                     const char *name, const char *path,
+                     const void *identifier);
  void grep_source_clear_data(struct grep_source *gs);
  void grep_source_clear(struct grep_source *gs);
  void grep_source_load_driver(struct grep_source *gs);