qsort() ptrdiff_t may be larger than int
authorJunio C Hamano <junkio@cox.net>
Tue, 6 Dec 2005 21:41:48 +0000 (13:41 -0800)
committerJunio C Hamano <junkio@cox.net>
Wed, 7 Dec 2005 01:28:26 +0000 (17:28 -0800)
Morten Welinder <mwelinder@gmail.com> writes:

> The code looks wrong. It assumes that pointers are no larger than ints.
> If pointers are larger than ints, the code does not necessarily compute
> a consistent ordering and qsort is allowed to do whatever it wants.
>
> Morten
>
> static int compare_object_pointers(const void *a, const void *b)
> {
> const struct object * const *pa = a;
> const struct object * const *pb = b;
> return *pa - *pb;
> }

Signed-off-by: Junio C Hamano <junkio@cox.net>
No differences found