Merge branch 'mh/maint-notes-merge-pathbuf-fix'

* mh/maint-notes-merge-pathbuf-fix:
notes_merge_commit(): do not pass temporary buffer to other function

diff --combined notes-merge.c
index 3bbcc9debdc22bd5c7921f30c592c7816504a457,baaf31f4aed4e4cfd967c278b7cfd4bee6a0ab30..e9e41993117ae03ed7c9d1f28081a42b2eee97ca
--- 1/notes-merge.c
--- 2/notes-merge.c
+++ b/notes-merge.c
@@@ -570,8 -570,7 +570,8 @@@ int notes_merge(struct notes_merge_opti
        /* Dereference o->local_ref into local_sha1 */
        if (!resolve_ref(o->local_ref, local_sha1, 0, NULL))
                die("Failed to resolve local notes ref '%s'", o->local_ref);
 -      else if (!check_ref_format(o->local_ref) && is_null_sha1(local_sha1))
 +      else if (!check_refname_format(o->local_ref, 0) &&
 +              is_null_sha1(local_sha1))
                local = NULL; /* local_sha1 == null_sha1 indicates unborn ref */
        else if (!(local = lookup_commit_reference(local_sha1)))
                die("Could not parse local commit %s (%s)",
@@@ -584,7 -583,7 +584,7 @@@
                 * Failed to get remote_sha1. If o->remote_ref looks like an
                 * unborn ref, perform the merge using an empty notes tree.
                 */
 -              if (!check_ref_format(o->remote_ref)) {
 +              if (!check_refname_format(o->remote_ref, 0)) {
                        hashclr(remote_sha1);
                        remote = NULL;
                } else {
@@@ -681,7 -680,7 +681,7 @@@ int notes_merge_commit(struct notes_mer
         * Finally store the new commit object SHA1 into 'result_sha1'.
         */
        struct dir_struct dir;
-       const char *path = git_path(NOTES_MERGE_WORKTREE "/");
+       char *path = xstrdup(git_path(NOTES_MERGE_WORKTREE "/"));
        int path_len = strlen(path), i;
        const char *msg = strstr(partial_commit->buffer, "\n\n");
  
@@@ -721,6 -720,7 +721,7 @@@
                            result_sha1);
        OUTPUT(o, 4, "Finalized notes merge commit: %s",
               sha1_to_hex(result_sha1));
+       free(path);
        return 0;
  }