t7201: drop pointless "exit 0" at end of subshell
authorEric Sunshine <sunshine@sunshineco.com>
Mon, 2 Jul 2018 00:23:50 +0000 (20:23 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 3 Jul 2018 19:38:05 +0000 (12:38 -0700)
This test employs a for-loop inside a subshell and correctly aborts the
loop and fails the test overall (via "exit 1") if any iteration of the
for-loop fails. Otherwise, it exits the subshell with an explicit but
entirely unnecessary "exit 0", presumably to indicate that all
iterations of the loop succeeded. The &&-chain is broken between the
for-loop and the "exit 0". Rather than fixing the &&-chain, just drop
the pointless "exit 0".

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t7201-co.sh
index ab9da61da391f1b6040076dda2454f602adef7d2..8d8a63a24be023b2a615bed1aa51c6812d8cbb83 100755 (executable)
@@ -673,7 +673,6 @@ test_expect_success 'custom merge driver with checkout -m' '
                do
                        grep $t arm || exit 1
                done
-               exit 0
        ) &&
 
        mv arm expect &&