imap-send: fix CRAM-MD5 response calculation
authorKazuki Yamaguchi <k@rhe.jp>
Fri, 8 Apr 2016 14:02:30 +0000 (23:02 +0900)
committerJunio C Hamano <gitster@pobox.com>
Wed, 13 Apr 2016 22:28:09 +0000 (15:28 -0700)
Remove extra + 1 from resp_len, the length of the byte sequence to be
Base64 encoded and passed to the server as the response. Or the response
incorrectly contains an extra \0.

Signed-off-by: Kazuki Yamaguchi <k@rhe.jp>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
imap-send.c
index 30979f0c63cc952aa32fa1927651bc563c85f868..407e46bc8c0e7c6748a5c0e92a47d86cacd55a13 100644 (file)
@@ -890,7 +890,7 @@ static char *cram(const char *challenge_64, const char *user, const char *pass)
 
        /* response: "<user> <digest in hex>" */
        response = xstrfmt("%s %s", user, hex);
-       resp_len = strlen(response) + 1;
+       resp_len = strlen(response);
 
        response_64 = xmallocz(ENCODED_SIZE(resp_len));
        encoded_len = EVP_EncodeBlock((unsigned char *)response_64,