t5520: ensure consistent test conditions
authorMehul Jain <mehul.jain2029@gmail.com>
Sat, 2 Apr 2016 17:58:27 +0000 (23:28 +0530)
committerJunio C Hamano <gitster@pobox.com>
Mon, 4 Apr 2016 18:07:33 +0000 (11:07 -0700)
Test title says that tests are done with rebase.autostash unset,
but does not take any action to make sure that it is indeed unset.
This may lead to test failure if future changes somehow pollutes
the configuration globally.

Ensure consistent test conditions by explicitly unsetting
rebase.autostash.

Signed-off-by: Mehul Jain <mehul.jain2029@gmail.com>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5520-pull.sh
index 5be39df50aa40545765e0808601dc83b050c4322..9ee22185f34ced22520de4a615237eeb931da7db 100755 (executable)
@@ -279,6 +279,7 @@ test_expect_success 'pull --rebase --autostash & rebase.autostash=false' '
 '
 
 test_expect_success 'pull --rebase: --autostash & rebase.autostash unset' '
+       test_unconfig rebase.autostash &&
        git reset --hard before-rebase &&
        echo dirty >new_file &&
        git add new_file &&
@@ -307,6 +308,7 @@ test_expect_success 'pull --rebase --no-autostash & rebase.autostash=false' '
 '
 
 test_expect_success 'pull --rebase --no-autostash & rebase.autostash unset' '
+       test_unconfig rebase.autostash &&
        git reset --hard before-rebase &&
        echo dirty >new_file &&
        git add new_file &&