Git.pm: add the "use warnings" pragma
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sun, 25 Feb 2018 19:46:27 +0000 (19:46 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 27 Feb 2018 22:52:46 +0000 (14:52 -0800)
Amend Git.pm to load the "warnings" pragma like the rest of the code
in perl/ in addition to the existing "strict" pragma. This is
considered the bare minimum best practice in Perl.

Ever since this code was introduced in b1edc53d06 ("Introduce
Git.pm (v4)", 2006-06-24) it's only been using "strict", not
"warnings".

This leaves contrib/buildsystems/Generators/{QMake,VCproj}.pm and
contrib/mw-to-git/Git/Mediawiki.pm without "use warnings". Amending
those would be a sensible follow-up change, but I don't have an easy
way to test those so I'm not changing them.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
perl/Git.pm
index 99e5d943af9e4046bb5fd0935e397e258ef532ca..7ec16e6dde3f1c6174dd38c0cc7d4358cd50df40 100644 (file)
@@ -9,6 +9,7 @@ package Git;
 
 use 5.008;
 use strict;
+use warnings;
 
 
 BEGIN {