Fix memory leak in helper method for disconnect

Since some cases may need to disconnect from the helper and reconnect,
wrap the function that just disconnects in a function that also frees
transport->data.

Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/transport-helper.c b/transport-helper.c
index f57e84c67641b5a03ba8d9ed5182507bb54dcd15..e24fcbb17d0bb6e28bd8c83ec55a5ce3e8bbc88e 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -67,6 +67,13 @@ static int disconnect_helper(struct transport *transport)
        return 0;
 }
 
        return 0;
 }
 

+static int release_helper(struct transport *transport)
+{
+       disconnect_helper(transport);
+       free(transport->data);
+       return 0;
+}
+

 static int fetch_with_fetch(struct transport *transport,
                            int nr_heads, const struct ref **to_fetch)
 {
 static int fetch_with_fetch(struct transport *transport,
                            int nr_heads, const struct ref **to_fetch)
 {


@@ -163,6 +170,6 @@ int transport_helper_init(struct transport *transport, const char *name)
        transport->data = data;
        transport->get_refs_list = get_refs_list;
        transport->fetch = fetch;
        transport->data = data;
        transport->get_refs_list = get_refs_list;
        transport->fetch = fetch;

-       transport->disconnect = disconnect_helper;
+       transport->disconnect = release_helper;

        return 0;
 }
        return 0;
 }