Fix memory leaks when disconnecting transport instances

Most transport implementations tend to allocate a data buffer
in the struct transport instance during transport_get() so we
need to free that data buffer when we disconnect it.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/transport.c b/transport.c
index a1d0a3c89915e028d3e2c6f7e03612762234b960..4f9cddc308de318b5ff36c82c7a7600ec8c6c64d 100644 (file)
--- a/transport.c
+++ b/transport.c
@@ -236,6 +236,7 @@ static int close_bundle(struct transport *transport)
        struct bundle_transport_data *data = transport->data;
        if (data->fd > 0)
                close(data->fd);
        struct bundle_transport_data *data = transport->data;
        if (data->fd > 0)
                close(data->fd);

+       free(data);

        return 0;
 }
 
        return 0;
 }
 


@@ -372,6 +373,12 @@ static int git_transport_push(struct transport *transport, int refspec_nr, const
        return !!err;
 }
 
        return !!err;
 }
 

+static int disconnect_git(struct transport *transport)
+{
+       free(transport->data);
+       return 0;
+}
+

 static int is_local(const char *url)
 {
        const char *colon = strchr(url, ':');
 static int is_local(const char *url)
 {
        const char *colon = strchr(url, ':');


@@ -419,6 +426,7 @@ struct transport *transport_get(struct remote *remote, const char *url)
                ret->get_refs_list = get_refs_via_connect;
                ret->fetch = fetch_refs_via_pack;
                ret->push = git_transport_push;
                ret->get_refs_list = get_refs_via_connect;
                ret->fetch = fetch_refs_via_pack;
                ret->push = git_transport_push;

+               ret->disconnect = disconnect_git;

 
                data->thin = 1;
                data->uploadpack = "git-upload-pack";
 
                data->thin = 1;
                data->uploadpack = "git-upload-pack";