gitk: Fix display of newly-created tags
authorDave Dulson <dave@dulson.com>
Sun, 3 Jan 2010 14:56:25 +0000 (14:56 +0000)
committerPaul Mackerras <paulus@samba.org>
Tue, 12 Jan 2010 11:04:46 +0000 (22:04 +1100)
If the user creates a tag with the "create tag" dialog in gitk and
then clicks on the newly-created tag, its contents don't get
displayed. The reason is that rereadrefs hasn't been called, meaning
the tag doesn't exist in $tagobjid. This causes the cat-file to fail.
Instead of using $tagobjid, pass the $tag directly, ensuring the tag
contents are populated correctly.

Signed-off-by: David Dulson <dave@dulson.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
gitk
diff --git a/gitk b/gitk
index 0b3e5bca736591f68a03e7260a329d575f08c8ef..de911b6e6d0fd8d7ff3217382d698d333b168da3 100755 (executable)
--- a/gitk
+++ b/gitk
@@ -10493,7 +10493,7 @@ proc showtag {tag isnew} {
     set linknum 0
     if {![info exists tagcontents($tag)]} {
        catch {
-           set tagcontents($tag) [exec git cat-file tag $tagobjid($tag)]
+           set tagcontents($tag) [exec git cat-file tag $tag]
        }
     }
     if {[info exists tagcontents($tag)]} {