gitweb.git
l10n: Update Swedish translation (2210t0f0u)Peter Krefting Tue, 21 Jan 2014 08:26:56 +0000 (09:26 +0100)

l10n: Update Swedish translation (2210t0f0u)

Signed-off-by: Peter Krefting <peter@softwolves.pp.se>

Merge branch 'fr-po' of git://github.com/jnavila/gitJiang Xin Sat, 18 Jan 2014 14:49:27 +0000 (22:49 +0800)

Merge branch 'fr-po' of git://github.com/jnavila/git

* 'fr-po' of git://github.com/jnavila/git:
[fr] update french translation 2210/2210

[fr] update french translation 2210/2210Jean-Noel Avila Sat, 18 Jan 2014 13:36:19 +0000 (14:36 +0100)

[fr] update french translation 2210/2210

Signed-off-by: Jean-Noel Avila <jn.avila@free.fr>

l10n: vi.po (2210t): Updated git-core translationTran Ngoc Quan Sat, 18 Jan 2014 02:07:40 +0000 (09:07 +0700)

l10n: vi.po (2210t): Updated git-core translation

* Updated new strings
* Fix typos and review
* Change meaning of stage

Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>

l10n: git.pot: v1.9 round 1 (27 new, 11 removed)Jiang Xin Fri, 17 Jan 2014 23:45:37 +0000 (07:45 +0800)

l10n: git.pot: v1.9 round 1 (27 new, 11 removed)

Generate po/git.pot from v1.9-rc0 for git v1.9 l10n round 1.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>

Git 1.9-rc0 v1.9-rc0Junio C Hamano Fri, 17 Jan 2014 20:30:14 +0000 (12:30 -0800)

Git 1.9-rc0

Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'maint'Junio C Hamano Fri, 17 Jan 2014 20:21:39 +0000 (12:21 -0800)

Merge branch 'maint'

* maint:
git-svn: workaround for a bug in svn serf backend

Merge branch 'fp/submodule-checkout-mode'Junio C Hamano Fri, 17 Jan 2014 20:21:20 +0000 (12:21 -0800)

Merge branch 'fp/submodule-checkout-mode'

"submodule.*.update=checkout", when propagated from .gitmodules to
.git/config, turned into a "submodule.*.update=none", which did not
make much sense.

* fp/submodule-checkout-mode:
git-submodule.sh: 'checkout' is a valid update mode

Merge branch 'nd/shallow-clone'Junio C Hamano Fri, 17 Jan 2014 20:21:14 +0000 (12:21 -0800)

Merge branch 'nd/shallow-clone'

Fetching from a shallow-cloned repository used to be forbidden,
primarily because the codepaths involved were not carefully vetted
and we did not bother supporting such usage. This attempts to allow
object transfer out of a shallow-cloned repository in a controlled
way (i.e. the receiver become a shallow repository with truncated
history).

* nd/shallow-clone: (31 commits)
t5537: fix incorrect expectation in test case 10
shallow: remove unused code
send-pack.c: mark a file-local function static
git-clone.txt: remove shallow clone limitations
prune: clean .git/shallow after pruning objects
clone: use git protocol for cloning shallow repo locally
send-pack: support pushing from a shallow clone via http
receive-pack: support pushing to a shallow clone via http
smart-http: support shallow fetch/clone
remote-curl: pass ref SHA-1 to fetch-pack as well
send-pack: support pushing to a shallow clone
receive-pack: allow pushes that update .git/shallow
connected.c: add new variant that runs with --shallow-file
add GIT_SHALLOW_FILE to propagate --shallow-file to subprocesses
receive/send-pack: support pushing from a shallow clone
receive-pack: reorder some code in unpack()
fetch: add --update-shallow to accept refs that update .git/shallow
upload-pack: make sure deepening preserves shallow roots
fetch: support fetching from a shallow repository
clone: support remote shallow repository
...

Merge branch 'jk/pull-rebase-using-fork-point'Junio C Hamano Fri, 17 Jan 2014 20:04:29 +0000 (12:04 -0800)

Merge branch 'jk/pull-rebase-using-fork-point'

Finishing touches so that an expected error message will not leak to
the UI.

* jk/pull-rebase-using-fork-point:
pull: suppress error when no remoteref is found

pull: suppress error when no remoteref is foundJohn Keeping Fri, 17 Jan 2014 20:00:20 +0000 (20:00 +0000)

pull: suppress error when no remoteref is found

Commit 48059e4 (pull: use merge-base --fork-point when appropriate,
2013-12-08) incorrectly assumes that get_remote_merge_branch will either
yield a non-empty string or return an error, but there are circumstances
where it will yield an empty string.

The previous code then invoked git-rev-list with no arguments, which
results in an error suppressed by redirecting stderr to /dev/null. Now
we invoke git-merge-base with an empty branch name, which also results
in an error. Suppress this in the same way.

Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git-svn: workaround for a bug in svn serf backendRoman Kagan Fri, 27 Dec 2013 08:05:15 +0000 (12:05 +0400)

git-svn: workaround for a bug in svn serf backend

Subversion serf backend in versions 1.8.5 and below has a bug(*) that the
function creating the descriptor of a file change -- add_file() --
doesn't make a copy of its third argument when storing it on the
returned descriptor. As a result, by the time this field is used (in
transactions of file copying or renaming) it may well be released, and
the memory reused.

One of its possible manifestations is the svn assertion triggering on an
invalid path, with a message

svn_fspath__skip_ancestor: Assertion
`svn_fspath__is_canonical(child_fspath)' failed.

This patch works around this bug, by storing the value to be passed as
the third argument to add_file() in a local variable with the same scope
as the file change descriptor, making sure their lifetime is the same.

* [ew: fixed in Subversion r1553376 as noted by Jonathan Nieder]

Cc: Benjamin Pabst <benjamin.pabst85@gmail.com>
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Roman Kagan <rkagan@mail.ru>

Sync with 1.8.5.3Junio C Hamano Mon, 13 Jan 2014 19:39:38 +0000 (11:39 -0800)

Sync with 1.8.5.3

* maint:
Git 1.8.5.3
pack-heuristics.txt: mark up the file header properly

Update draft release notes to 1.9Junio C Hamano Mon, 13 Jan 2014 19:39:09 +0000 (11:39 -0800)

Update draft release notes to 1.9

Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'jk/t5531-prepare-to-default-to-non-matching'Junio C Hamano Mon, 13 Jan 2014 19:35:10 +0000 (11:35 -0800)

Merge branch 'jk/t5531-prepare-to-default-to-non-matching'

* jk/t5531-prepare-to-default-to-non-matching:
t5531: further "matching" fixups

Merge branch 'sb/diff-orderfile-config'Junio C Hamano Mon, 13 Jan 2014 19:34:11 +0000 (11:34 -0800)

Merge branch 'sb/diff-orderfile-config'

Finishing touches to avoid casting unnecessary detail in stone.

* sb/diff-orderfile-config:
diff test: reading a directory as a file need not error out

Merge branch 'mh/shorten-unambigous-ref'Junio C Hamano Mon, 13 Jan 2014 19:34:08 +0000 (11:34 -0800)

Merge branch 'mh/shorten-unambigous-ref'

* mh/shorten-unambigous-ref:
shorten_unambiguous_ref(): tighten up pointer arithmetic
gen_scanf_fmt(): delete function and use snprintf() instead
shorten_unambiguous_ref(): introduce a new local variable

Merge branch 'mm/mv-file-to-no-such-dir-with-slash'Junio C Hamano Mon, 13 Jan 2014 19:33:51 +0000 (11:33 -0800)

Merge branch 'mm/mv-file-to-no-such-dir-with-slash'

Finishing touches to do the same on windows.

* mm/mv-file-to-no-such-dir-with-slash:
mv: let 'git mv file no-such-dir/' error out on Windows, too

Merge branch 'jl/submodule-mv-checkout-caveat'Junio C Hamano Mon, 13 Jan 2014 19:33:47 +0000 (11:33 -0800)

Merge branch 'jl/submodule-mv-checkout-caveat'

With a submodule that was initialized in an old fashioned way
without gitlinks, switching branches in the superproject between
the one with and without the submodule may leave the submodule
working tree with its embedded repository behind, as there may be
unexpendable state there. Document and warn users about this.

* jl/submodule-mv-checkout-caveat:
rm: better document side effects when removing a submodule
mv: better document side effects when moving a submodule

Merge branch 'jk/pull-rebase-using-fork-point'Junio C Hamano Mon, 13 Jan 2014 19:33:39 +0000 (11:33 -0800)

Merge branch 'jk/pull-rebase-using-fork-point'

Finishing touches.

* jk/pull-rebase-using-fork-point:
rebase: fix fork-point with zero arguments

Merge branch 'rr/completion-format-coverletter'Junio C Hamano Mon, 13 Jan 2014 19:33:38 +0000 (11:33 -0800)

Merge branch 'rr/completion-format-coverletter'

The bash/zsh completion code did not know about format.coverLetter
among many format.* configuration variables.

* rr/completion-format-coverletter:
completion: complete format.coverLetter

Merge branch 'ow/stash-with-ifs'Junio C Hamano Mon, 13 Jan 2014 19:33:36 +0000 (11:33 -0800)

Merge branch 'ow/stash-with-ifs'

The implementation of 'git stash $cmd "stash@{...}"' did not quote
the stash argument properly and left it split at IFS whitespace.

* ow/stash-with-ifs:
stash: handle specifying stashes with $IFS

Merge branch 'jn/pager-lv-default-env'Junio C Hamano Mon, 13 Jan 2014 19:33:34 +0000 (11:33 -0800)

Merge branch 'jn/pager-lv-default-env'

Just like we give a reasonable default for "less" via the LESS
environment variable, specify a reasonable default for "lv" via the
"LV" environment variable when spawning the pager.

* jn/pager-lv-default-env:
pager: set LV=-c alongside LESS=FRSX

Merge branch 'br/sha1-name-40-hex-no-disambiguation'Junio C Hamano Mon, 13 Jan 2014 19:33:29 +0000 (11:33 -0800)

Merge branch 'br/sha1-name-40-hex-no-disambiguation'

When parsing a 40-hex string into the object name, the string is
checked to see if it can be interpreted as a ref so that a warning
can be given for ambiguity. The code kicked in even when the
core.warnambiguousrefs is set to false to squelch this warning, in
which case the cycles spent to look at the ref namespace were an
expensive no-op, as the result was discarded without being used.

* br/sha1-name-40-hex-no-disambiguation:
sha1_name: don't resolve refs when core.warnambiguousrefs is false

Git 1.8.5.3 v1.8.5.3Junio C Hamano Mon, 13 Jan 2014 19:28:26 +0000 (11:28 -0800)

Git 1.8.5.3

Merge branch 'nd/daemon-informative-errors-typofix... Junio C Hamano Mon, 13 Jan 2014 19:23:07 +0000 (11:23 -0800)

Merge branch 'nd/daemon-informative-errors-typofix' into maint

The "--[no-]informative-errors" options to "git daemon" were parsed
a bit too loosely, allowing any other string after these option
names.

* nd/daemon-informative-errors-typofix:
daemon: be strict at parsing parameters --[no-]informative-errors

Merge branch 'km/gc-eperm' into maintJunio C Hamano Mon, 13 Jan 2014 19:23:04 +0000 (11:23 -0800)

Merge branch 'km/gc-eperm' into maint

A "gc" process running as a different user should be able to stop a
new "gc" process from starting.

* km/gc-eperm:
gc: notice gc processes run by other users

Merge branch 'jk/credential-plug-leak' into maintJunio C Hamano Mon, 13 Jan 2014 19:23:01 +0000 (11:23 -0800)

Merge branch 'jk/credential-plug-leak' into maint

An earlier "clean-up" introduced an unnecessary memory leak.

* jk/credential-plug-leak:
Revert "prompt: clean up strbuf usage"

Merge branch 'mm/mv-file-to-no-such-dir-with-slash... Junio C Hamano Mon, 13 Jan 2014 19:22:48 +0000 (11:22 -0800)

Merge branch 'mm/mv-file-to-no-such-dir-with-slash' into maint

"git mv A B/", when B does not exist as a directory, should error
out, but it didn't.

* mm/mv-file-to-no-such-dir-with-slash:
mv: let 'git mv file no-such-dir/' error out on Windows, too
mv: let 'git mv file no-such-dir/' error out

Merge branch 'jk/rev-parse-double-dashes' into maintJunio C Hamano Mon, 13 Jan 2014 19:22:38 +0000 (11:22 -0800)

Merge branch 'jk/rev-parse-double-dashes' into maint

"git rev-parse <revs> -- <paths>" did not implement the usual
disambiguation rules the commands in the "git log" family used in
the same way.

* jk/rev-parse-double-dashes:
rev-parse: be more careful with munging arguments
rev-parse: correctly diagnose revision errors before "--"

Merge branch 'jk/cat-file-regression-fix' into maintJunio C Hamano Mon, 13 Jan 2014 19:22:21 +0000 (11:22 -0800)

Merge branch 'jk/cat-file-regression-fix' into maint

"git cat-file --batch=", an admittedly useless command, did not
behave very well.

* jk/cat-file-regression-fix:
cat-file: handle --batch format with missing type/size
cat-file: pass expand_data to print_object_or_die

pack-heuristics.txt: mark up the file header properlyThomas Ackermann Sat, 11 Jan 2014 16:28:25 +0000 (17:28 +0100)

pack-heuristics.txt: mark up the file header properly

AsciiDoc wants these header-lines left-aligned.

Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t5531: further "matching" fixupsJeff King Wed, 8 Jan 2014 10:47:56 +0000 (05:47 -0500)

t5531: further "matching" fixups

Commit 43eb920 switched one of the sub-repository in this
test to matching to prepare for a world where the default
becomes "simple". However, the main repository needs a
similar change.

We did not notice any test failure when merged with b2ed944
(push: switch default from "matching" to "simple", 2013-01-04)
because t5531.6 is trying to provoke a failure of "git push"
due to a submodule check. When combined with b2ed944 the
push still fails, but for the wrong reason (because our
upstream setup does not exist, not because of the submodule).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff test: reading a directory as a file need not error outJonathan Nieder Fri, 10 Jan 2014 20:10:31 +0000 (12:10 -0800)

diff test: reading a directory as a file need not error out

There is no guarantee that strbuf_read_file must error out for
directories. On some operating systems (e.g., Debian GNU/kFreeBSD
wheezy), reading a directory gives its raw content:

$ head -c5 < / | cat -A
^AM-|^_^@^L$

As a result, 'git diff -O/' succeeds instead of erroring out on
these systems, causing t4056.5 "orderfile is a directory" to fail.

On some weird OS it might even make sense to pass a directory to the
-O option and this is not a common user mistake that needs catching.
Remove the test.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

mv: let 'git mv file no-such-dir/' error out on Windows... Johannes Sixt Wed, 8 Jan 2014 16:33:44 +0000 (17:33 +0100)

mv: let 'git mv file no-such-dir/' error out on Windows, too

The previous commit c57f628 (mv: let 'git mv file no-such-dir/' error out)
relies on that rename("file", "no-such-dir/") fails if the directory does not
exist (note the trailing slash). This does not work as expected on Windows:
This rename() call does not fail, but renames "file" to "no-such-dir" (not to
"no-such-dir/file"). Insert an explicit check for this case to force an error.

This changes the error message from

$ git mv file no-such-dir/
fatal: renaming 'file' failed: Not a directory

to

$ git mv file no-such-dir/
fatal: destination directory does not exist, source=file, destination=no-such-dir/

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Update draft release notes to 1.9Junio C Hamano Fri, 10 Jan 2014 19:25:01 +0000 (11:25 -0800)

Update draft release notes to 1.9

Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'ss/builtin-cleanup'Junio C Hamano Fri, 10 Jan 2014 18:33:47 +0000 (10:33 -0800)

Merge branch 'ss/builtin-cleanup'

"git help $cmd" unnecessarily enumerated potential command names
from the filesystem, even when $cmd is known to be a built-in.

Ideas for further optimization, primarily by killing the use of
is_in_cmdlist(), were suggested in the discussion, but they can
come as follow-ups on top of this series.

* ss/builtin-cleanup:
builtin/help.c: speed up is_git_command() by checking for builtin commands first
builtin/help.c: call load_command_list() only when it is needed
git.c: consistently use the term "builtin" instead of "internal command"

Merge branch 'vm/octopus-merge-bases-simplify'Junio C Hamano Fri, 10 Jan 2014 18:33:45 +0000 (10:33 -0800)

Merge branch 'vm/octopus-merge-bases-simplify'

* vm/octopus-merge-bases-simplify:
get_octopus_merge_bases(): cleanup redundant variable

Merge branch 'ta/format-user-manual-as-an-article'Junio C Hamano Fri, 10 Jan 2014 18:33:43 +0000 (10:33 -0800)

Merge branch 'ta/format-user-manual-as-an-article'

Update the way the user-manual is formatted via AsciiDoc to save
trees.

* ta/format-user-manual-as-an-article:
user-manual: improve html and pdf formatting

Merge branch 'rr/completion-branch-config'Junio C Hamano Fri, 10 Jan 2014 18:33:39 +0000 (10:33 -0800)

Merge branch 'rr/completion-branch-config'

Two-level configuration variable names in "branch.*" and "remote.*"
hierarchies whose variables are predominantly three-level where not
completed by hitting a <TAB> in bash and zsh completions.

* rr/completion-branch-config:
completion: fix remote.pushdefault
completion: fix branch.autosetup(merge|rebase)
completion: introduce __gitcomp_nl_append ()
zsh completion: find matching custom bash completion

Merge branch 'js/lift-parent-count-limit'Junio C Hamano Fri, 10 Jan 2014 18:33:36 +0000 (10:33 -0800)

Merge branch 'js/lift-parent-count-limit'

There is no reason to have a hardcoded upper limit of the number of
parents for an octopus merge, created via the graft mechanism.

* js/lift-parent-count-limit:
Remove the line length limit for graft files

Merge branch 'jk/test-framework-updates'Junio C Hamano Fri, 10 Jan 2014 18:33:34 +0000 (10:33 -0800)

Merge branch 'jk/test-framework-updates'

The basic test used to leave unnecessary trash directories in the
t/ directory.

* jk/test-framework-updates:
t0000: drop "known breakage" test
t0000: simplify HARNESS_ACTIVE hack
t0000: set TEST_OUTPUT_DIRECTORY for sub-tests

Merge branch 'bm/merge-base-octopus-dedup'Junio C Hamano Fri, 10 Jan 2014 18:33:32 +0000 (10:33 -0800)

Merge branch 'bm/merge-base-octopus-dedup'

"git merge-base --octopus" used to leave cleaning up suboptimal
result to the caller, but now it does the clean-up itself.

* bm/merge-base-octopus-dedup:
merge-base --octopus: reduce the result from get_octopus_merge_bases()
merge-base: separate "--independent" codepath into its own helper

Merge branch 'km/gc-eperm'Junio C Hamano Fri, 10 Jan 2014 18:33:30 +0000 (10:33 -0800)

Merge branch 'km/gc-eperm'

A "gc" process running as a different user should be able to stop a
new "gc" process from starting.

* km/gc-eperm:
gc: notice gc processes run by other users

Merge branch 'jk/http-auth-tests-robustify'Junio C Hamano Fri, 10 Jan 2014 18:33:18 +0000 (10:33 -0800)

Merge branch 'jk/http-auth-tests-robustify'

Using the same username and password during the tests would not
catch a potential breakage of sending one when we should be sending
the other.

* jk/http-auth-tests-robustify:
use distinct username/password for http auth tests

Merge branch 'jk/credential-plug-leak'Junio C Hamano Fri, 10 Jan 2014 18:33:16 +0000 (10:33 -0800)

Merge branch 'jk/credential-plug-leak'

An earlier "clean-up" introduced an unnecessary memory leak.

* jk/credential-plug-leak:
Revert "prompt: clean up strbuf usage"

Merge branch 'bs/mirbsd'Junio C Hamano Fri, 10 Jan 2014 18:33:14 +0000 (10:33 -0800)

Merge branch 'bs/mirbsd'

* bs/mirbsd:
Add MirBSD support to the build system.

Merge branch 'nd/commit-tree-constness'Junio C Hamano Fri, 10 Jan 2014 18:33:13 +0000 (10:33 -0800)

Merge branch 'nd/commit-tree-constness'

Code clean-up.

* nd/commit-tree-constness:
commit.c: make "tree" a const pointer in commit_tree*()

Merge branch 'jk/oi-delta-base'Junio C Hamano Fri, 10 Jan 2014 18:33:11 +0000 (10:33 -0800)

Merge branch 'jk/oi-delta-base'

Teach "cat-file --batch" to show delta-base object name for a
packed object that is represented as a delta.

* jk/oi-delta-base:
cat-file: provide %(deltabase) batch format
sha1_object_info_extended: provide delta base sha1s

Merge branch 'jk/sha1write-void'Junio C Hamano Fri, 10 Jan 2014 18:33:09 +0000 (10:33 -0800)

Merge branch 'jk/sha1write-void'

Code clean-up.

* jk/sha1write-void:
do not pretend sha1write returns errors

Merge branch 'nd/add-empty-fix'Junio C Hamano Fri, 10 Jan 2014 18:33:03 +0000 (10:33 -0800)

Merge branch 'nd/add-empty-fix'

"git add -A" (no other arguments) in a totally empty working tree
used to emit an error.

* nd/add-empty-fix:
add: don't complain when adding empty project root

Merge branch 'nd/daemon-informative-errors-typofix'Junio C Hamano Fri, 10 Jan 2014 18:32:59 +0000 (10:32 -0800)

Merge branch 'nd/daemon-informative-errors-typofix'

* nd/daemon-informative-errors-typofix:
daemon: be strict at parsing parameters --[no-]informative-errors

Merge branch 'tm/fetch-prune'Junio C Hamano Fri, 10 Jan 2014 18:32:50 +0000 (10:32 -0800)

Merge branch 'tm/fetch-prune'

Fetching 'frotz' branch with "git fetch", while having
'frotz/nitfol' remote-tracking branch from an earlier fetch, would
error out, primarily because the command has not been told to
remove anything on our side. In such a case, "git fetch --prune"
can be used to remove 'frotz/nitfol' to make room to fetch and
store 'frotz' remote-tracking branch.

* tm/fetch-prune:
fetch --prune: Run prune before fetching
fetch --prune: always print header url

Merge branch 'sb/diff-orderfile-config'Junio C Hamano Fri, 10 Jan 2014 18:32:42 +0000 (10:32 -0800)

Merge branch 'sb/diff-orderfile-config'

Allow "git diff -O<file>" to be configured with a new configuration
variable.

* sb/diff-orderfile-config:
diff: add diff.orderfile configuration variable
diff: let "git diff -O" read orderfile from any file and fail properly
t4056: add new tests for "git diff -O"

Merge branch 'bc/log-decoration'Junio C Hamano Fri, 10 Jan 2014 18:32:39 +0000 (10:32 -0800)

Merge branch 'bc/log-decoration'

"git log --decorate" did not handle a tag pointed by another tag
nicely.

* bc/log-decoration:
log: properly handle decorations with chained tags

Merge branch 'jh/rlimit-nofile-fallback'Junio C Hamano Fri, 10 Jan 2014 18:32:28 +0000 (10:32 -0800)

Merge branch 'jh/rlimit-nofile-fallback'

When we figure out how many file descriptors to allocate for
keeping packfiles open, a system with non-working getrlimit() could
cause us to die(), but because we make this call only to get a
rough estimate of how many is available and we do not even attempt
to use up all file descriptors available ourselves, it is nicer to
fall back to a reasonable low value rather than dying.

* jh/rlimit-nofile-fallback:
get_max_fd_limit(): fall back to OPEN_MAX upon getrlimit/sysconf failure

Merge branch 'rt/bfg-ad-in-filter-branch-doc'Junio C Hamano Fri, 10 Jan 2014 18:32:25 +0000 (10:32 -0800)

Merge branch 'rt/bfg-ad-in-filter-branch-doc'

* rt/bfg-ad-in-filter-branch-doc:
docs: add filter-branch notes on The BFG

Merge branch 'mh/path-max'Junio C Hamano Fri, 10 Jan 2014 18:32:21 +0000 (10:32 -0800)

Merge branch 'mh/path-max'

A few places where we relied on a fixed length buffer to hold
pathnames in these two programs have been converted to use strbuf.

* mh/path-max:
builtin/prune.c: use strbuf to avoid having to worry about PATH_MAX
prune-packed: use strbuf to avoid having to worry about PATH_MAX

Merge branch 'ap/path-max'Junio C Hamano Fri, 10 Jan 2014 18:32:18 +0000 (10:32 -0800)

Merge branch 'ap/path-max'

* ap/path-max:
Prevent buffer overflows when path is too long

Merge branch 'cc/replace-object-info'Junio C Hamano Fri, 10 Jan 2014 18:32:10 +0000 (10:32 -0800)

Merge branch 'cc/replace-object-info'

read_sha1_file() that is the workhorse to read the contents given
an object name honoured object replacements, but there is no
corresponding mechanism to sha1_object_info() that is used to
obtain the metainfo (e.g. type & size) about the object, leading
callers to weird inconsistencies.

* cc/replace-object-info:
replace info: rename 'full' to 'long' and clarify in-code symbols
Documentation/git-replace: describe --format option
builtin/replace: unset read_replace_refs
t6050: add tests for listing with --format
builtin/replace: teach listing using short, medium or full formats
sha1_file: perform object replacement in sha1_object_info_extended()
t6050: show that git cat-file --batch fails with replace objects
sha1_object_info_extended(): add an "unsigned flags" parameter
sha1_file.c: add lookup_replace_object_extended() to pass flags
replace_object: don't check read_replace_refs twice
rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECT

Merge branch 'nd/negative-pathspec'Junio C Hamano Fri, 10 Jan 2014 18:31:48 +0000 (10:31 -0800)

Merge branch 'nd/negative-pathspec'

Introduce "negative pathspec" magic, to allow "git log -- . ':!dir'" to
tell us "I am interested in everything but 'dir' directory".

* nd/negative-pathspec:
pathspec.c: support adding prefix magic to a pathspec with mnemonic magic
Support pathspec magic :(exclude) and its short form :!
glossary-content.txt: rephrase magic signature part

rebase: fix fork-point with zero argumentsJohn Keeping Thu, 9 Jan 2014 19:47:34 +0000 (19:47 +0000)

rebase: fix fork-point with zero arguments

When no arguments are specified, $switch_to is empty so we end up
passing the empty string to "git merge-base --fork-point", which causes
an error. git-rebase carries on at this point, but in fact we have
failed to apply the fork-point operation.

It turns out that the test in t3400 that was meant to test this didn't
actually need the fork-point behaviour, so enhance it to make sure that
the fork-point is applied correctly. The modified test fails without
the change to git-rebase.sh in this patch.

Reported-by: Andreas Krey <a.krey@gmx.de>
Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

shorten_unambiguous_ref(): tighten up pointer arithmeticMichael Haggerty Wed, 8 Jan 2014 14:43:40 +0000 (15:43 +0100)

shorten_unambiguous_ref(): tighten up pointer arithmetic

As long as we're being pathologically stingy with mallocs, we might as
well do the math right and save 6 (!) bytes.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

gen_scanf_fmt(): delete function and use snprintf(... Michael Haggerty Wed, 8 Jan 2014 14:43:39 +0000 (15:43 +0100)

gen_scanf_fmt(): delete function and use snprintf() instead

To replace "%.*s" with "%s", all we have to do is use snprintf()
to interpolate "%s" into the pattern.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

shorten_unambiguous_ref(): introduce a new local variableMichael Haggerty Wed, 8 Jan 2014 14:43:38 +0000 (15:43 +0100)

shorten_unambiguous_ref(): introduce a new local variable

When filling the scanf_fmts array, use a separate variable to keep
track of the offset to avoid clobbering total_len (which we will need
in the next commit).

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t5537: fix incorrect expectation in test case 10Nguyễn Thái Ngọc Duy Wed, 8 Jan 2014 12:13:19 +0000 (19:13 +0700)

t5537: fix incorrect expectation in test case 10

Commit 48d25ca adds a new commit "7" to the repo that the next test case
in commit 1609488 clones from. But the next test case does not expect
this commit. For these tests, it's the bottom that's important, not
the top. Fix the expected commit list.

While at it, fix the default http port number to 5537. Otherwise when
t5536 learns to test httpd, running test in parallel may fail.

References:

48d25ca fetch: add --update-shallow to accept... - 2013-12-05
1609488 smart-http: support shallow fetch/clone - 2013-12-05

Noticed-by: Jeff King <peff@peff.net>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

rm: better document side effects when removing a submoduleJens Lehmann Tue, 7 Jan 2014 21:32:37 +0000 (22:32 +0100)

rm: better document side effects when removing a submodule

The "Submodules" section of the "git rm" documentation mentions what will
happen when a submodule with a gitfile gets removed with newer git. But it
doesn't talk about what happens when the user changes between commits
before and after the removal, which does not remove the submodule from the
work tree like using the rm command did the first time.

Explain what happens and what the user has to do manually to fix that in
the new BUGS section. Also document this behavior in a new test.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

mv: better document side effects when moving a submoduleJens Lehmann Tue, 7 Jan 2014 21:31:32 +0000 (22:31 +0100)

mv: better document side effects when moving a submodule

The "Submodules" section of the "git mv" documentation mentions what will
happen when a submodule with a gitfile gets moved with newer git. But it
doesn't talk about what happens when the user changes between commits
before and after the move, which does not update the work tree like using
the mv command did the first time.

Explain what happens and what the user has to do manually to fix that in
the new BUGS section. Also document this behavior in a new test.

Reported-by: George Papanikolaou <g3orge.app@gmail.com>
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

stash: handle specifying stashes with $IFSØystein Walle Tue, 7 Jan 2014 08:22:15 +0000 (09:22 +0100)

stash: handle specifying stashes with $IFS

When trying to pop/apply a stash specified with an argument
containing IFS whitespace, git-stash will throw an error:

$ git stash pop 'stash@{two hours ago}'
Too many revisions specified: stash@{two hours ago}

This happens because word splitting is used to count non-option
arguments. Make use of rev-parse's --sq option to quote the arguments
for us to ensure a correct count. Add quotes where necessary.

Also add a test that verifies correct behaviour.

Helped-by: Thomas Rast <tr@thomasrast.ch>
Signed-off-by: Øystein Walle <oystwa@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

completion: complete format.coverLetterRamkumar Ramachandra Mon, 6 Jan 2014 17:18:51 +0000 (22:48 +0530)

completion: complete format.coverLetter

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

sha1_name: don't resolve refs when core.warnambiguousre... Brodie Rao Tue, 7 Jan 2014 03:32:01 +0000 (19:32 -0800)

sha1_name: don't resolve refs when core.warnambiguousrefs is false

When seeing a full 40-hex object name, get_sha1_basic()
unconditionally checks if the string can also be interpreted as a
refname, but the result will not be used unless warn_ambiguous_refs
is in effect.

Omitting this unnecessary ref resolution provides a substantial
performance improvement, especially when passing many hashes to a
command (like "git rev-list --stdin") and core.warnambiguousrefs is
set to false. The check incurs 6 stat()s for every hash supplied,
which can be costly over NFS.

Signed-off-by: Brodie Rao <brodie@sf.io>
Acked-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

pager: set LV=-c alongside LESS=FRSXJonathan Nieder Tue, 7 Jan 2014 02:14:05 +0000 (18:14 -0800)

pager: set LV=-c alongside LESS=FRSX

On systems with lv configured as the preferred pager (i.e.,
DEFAULT_PAGER=lv at build time, or PAGER=lv exported in the
environment) git commands that use color show control codes instead of
color in the pager:

$ git diff
^[[1mdiff --git a/.mailfilter b/.mailfilter^[[m
^[[1mindex aa4f0b2..17e113e 100644^[[m
^[[1m--- a/.mailfilter^[[m
^[[1m+++ b/.mailfilter^[[m
^[[36m@@ -1,11 +1,58 @@^[[m

"less" avoids this problem because git uses the LESS environment
variable to pass the -R option ('output ANSI color escapes in raw
form') by default. Use the LV environment variable to pass 'lv' the
-c option ('allow ANSI escape sequences for text decoration / color')
to fix it for lv, too.

Noticed when the default value for color.ui flipped to 'auto' in
v1.8.4-rc0~36^2~1 (2013-06-10).

Reported-by: Olaf Meeuwissen <olaf.meeuwissen@avasys.jp>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git-submodule.sh: 'checkout' is a valid update modeFrancesco Pretto Sun, 5 Jan 2014 02:50:48 +0000 (03:50 +0100)

git-submodule.sh: 'checkout' is a valid update mode

'checkout' is documented as one of the valid values for the
'submodule.<name>.update' variable, and in a repository with the
variable set to 'checkout', "git submodule update" command does
update using the 'checkout' mode.

However, it has been an accident that the implementation works this
way; any unknown value would trigger the same codepath and update
using the 'checkout' mode.

Explicitly list 'checkout' as one of the known update modes, and
error out when an unknown update mode is used.

Teach the codepath that initializes the configuration variable from
an in-tree .gitmodules that 'checkout' is one of the valid values.
The code since ac1fbbda (submodule: do not copy unknown update mode
from .gitmodules, 2013-12-02) used to treat the value 'checkout' as
unknown and mapped it to 'none', which made little sense. With this
change, 'checkout' specified in .gitmodules will stay to be 'checkout'.

Signed-off-by: Francesco Pretto <ceztko@gmail.com>
Signed-off-by: Signed-off-by: Junio C Hamano <gitster@pobox.com>

user-manual: improve html and pdf formattingThomas Ackermann Sat, 4 Jan 2014 09:07:51 +0000 (10:07 +0100)

user-manual: improve html and pdf formatting

Use asciidoc style 'article' instead of 'book' and change asciidoc
title level. This removes blank first page and superfluous "Part I"
page (there is no "Part II") in pdf output. Also pdf size is
decreased by this from 77 to 67 pages. In html output this removes
unnecessary sub-tocs and chapter numbering.

Signed-off-by: Thomas Ackermann <th.acker@arcor.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

builtin/help.c: speed up is_git_command() by checking... Sebastian Schuberth Thu, 2 Jan 2014 16:17:11 +0000 (17:17 +0100)

builtin/help.c: speed up is_git_command() by checking for builtin commands first

Since 2dce956 is_git_command() is a bit slow as it does file I/O in
the call to list_commands_in_dir(). Avoid the file I/O by adding an
early check for the builtin commands.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

builtin/help.c: call load_command_list() only when... Sebastian Schuberth Thu, 2 Jan 2014 16:16:30 +0000 (17:16 +0100)

builtin/help.c: call load_command_list() only when it is needed

This avoids list_commands_in_dir() being called when not needed which is
quite slow due to file I/O in order to list matching files in a directory.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git.c: consistently use the term "builtin" instead... Sebastian Schuberth Thu, 2 Jan 2014 16:15:44 +0000 (17:15 +0100)

git.c: consistently use the term "builtin" instead of "internal command"

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'maint'Junio C Hamano Mon, 6 Jan 2014 18:39:07 +0000 (10:39 -0800)

Merge branch 'maint'

* maint:
Documentation/gitmodules: Only 'update' and 'url' are required
l10n: de.po: fix translation of 'prefix'

completion: fix remote.pushdefaultRamkumar Ramachandra Sun, 5 Jan 2014 10:18:05 +0000 (15:48 +0530)

completion: fix remote.pushdefault

When attempting to complete

$ git config remote.push<TAB>

'pushdefault' doesn't come up. This is because "$cur" is matched with
"remote.*" and a list of remotes are completed. Add 'pushdefault' as a
candidate for completion too, using __gitcomp_nl_append ().

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

completion: fix branch.autosetup(merge|rebase)Ramkumar Ramachandra Sun, 5 Jan 2014 10:18:04 +0000 (15:48 +0530)

completion: fix branch.autosetup(merge|rebase)

When attempting to complete

$ git config branch.auto<TAB>

'autosetupmerge' and 'autosetuprebase' don't come up. This is because
"$cur" is matched with "branch.*" and a list of branches are
completed. Add 'autosetupmerge', 'autosetuprebase' as candidates for
completion too, using __gitcomp_nl_append ().

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

completion: introduce __gitcomp_nl_append ()Ramkumar Ramachandra Sun, 5 Jan 2014 10:18:03 +0000 (15:48 +0530)

completion: introduce __gitcomp_nl_append ()

There are situations where multiple classes of completions possible. For
example

branch.<TAB>

should try to complete

branch.master.
branch.autosetupmerge
branch.autosetuprebase

The first candidate has the suffix ".", and the second/ third candidates
have the suffix " ". To facilitate completions of this kind, create a
variation of __gitcomp_nl () that appends to the existing list of
completion candidates, COMPREPLY.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

zsh completion: find matching custom bash completionRamkumar Ramachandra Sun, 5 Jan 2014 10:18:02 +0000 (15:48 +0530)

zsh completion: find matching custom bash completion

If zsh completion is being read from a location that is different from
system-wide default, it is likely that the user is trying to use a
custom version, perhaps closer to the bleeding edge, installed in her
own directory. We will more likely to find the matching bash completion
script in the same directory than in those system default places.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'maint' of git://github.com/git-l10n/git... Junio C Hamano Mon, 6 Jan 2014 17:10:09 +0000 (09:10 -0800)

Merge branch 'maint' of git://github.com/git-l10n/git-po into maint

* 'maint' of git://github.com/git-l10n/git-po:
l10n: de.po: fix translation of 'prefix'

Documentation/gitmodules: Only 'update' and 'url' are... W. Trevor King Fri, 3 Jan 2014 18:31:22 +0000 (10:31 -0800)

Documentation/gitmodules: Only 'update' and 'url' are required

Descriptions for all the settings fell under the initial "Each
submodule section also contains the following required keys:". The
example shows sections with just 'path' and 'url' entries, which are
indeed required, but we should still make the required/optional
distinction explicit to clarify that the rest of them are optional.

Signed-off-by: W. Trevor King <wking@tremily.us>
Reviewed-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

shallow: remove unused codeRamsay Jones Mon, 6 Jan 2014 00:00:58 +0000 (00:00 +0000)

shallow: remove unused code

Commit 58babfff ("shallow.c: the 8 steps to select new commits for
.git/shallow", 05-12-2013) added a function to implement step 5 of
the quoted eight steps, namely 'remove_nonexistent_ours_in_pack()'.
This function implements an optional optimization step in the new
shallow commit selection algorithm. However, this function has no
callers. (The commented out call sites would need to change, in
order to provide information required by the function.)

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Acked-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

send-pack.c: mark a file-local function staticRamsay Jones Sun, 5 Jan 2014 23:55:01 +0000 (23:55 +0000)

send-pack.c: mark a file-local function static

Commit f2c681cf ("send-pack: support pushing from a shallow clone
via http", 05-12-2013) adds the 'advertise_shallow_grafts_buf'
function as an external symbol.

Noticed by sparse. ("'advertise_shallow_grafts_buf' was not declared.
Should it be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

get_octopus_merge_bases(): cleanup redundant variableVasily Makarov Fri, 3 Jan 2014 14:45:46 +0000 (18:45 +0400)

get_octopus_merge_bases(): cleanup redundant variable

pptr is needless. Some related code got cleaned as well.

Signed-off-by: Vasily Makarov <einmalfel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

fetch --prune: Run prune before fetchingTom Miller Fri, 3 Jan 2014 02:28:52 +0000 (20:28 -0600)

fetch --prune: Run prune before fetching

When we have a remote-tracking branch named "frotz/nitfol" from a
previous fetch, and the upstream now has a branch named "frotz",
fetch would fail to remove "frotz/nitfol" with a "git fetch --prune"
from the upstream. git would inform the user to use "git remote
prune" to fix the problem.

Change the way "fetch --prune" works by moving the pruning operation
before the fetching operation. This way, instead of warning the user
of a conflict, it autmatically fixes it.

Signed-off-by: Tom Miller <jackerran@gmail.com>
Tested-by: Thomas Rast <tr@thomasrast.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

fetch --prune: always print header urlTom Miller Fri, 3 Jan 2014 02:28:51 +0000 (20:28 -0600)

fetch --prune: always print header url

If "fetch --prune" is run with no new refs to fetch, but it has refs
to prune. Then, the header url is not printed as it would if there were
new refs to fetch.

Output before this patch:

$ git fetch --prune remote-with-no-new-refs
x [deleted] (none) -> origin/world

Output after this patch:

$ git fetch --prune remote-with-no-new-refs
From https://github.com/git/git
x [deleted] (none) -> origin/test

Signed-off-by: Tom Miller <jackerran@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

l10n: de.po: fix translation of 'prefix'Ralf Thielow Fri, 3 Jan 2014 17:05:43 +0000 (18:05 +0100)

l10n: de.po: fix translation of 'prefix'

The word 'prefix' is currently translated as 'Prefix'
which is not a German word. It should be translated as
'Präfix'.

Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>

gc: notice gc processes run by other usersKyle J. McKay Tue, 31 Dec 2013 12:07:39 +0000 (04:07 -0800)

gc: notice gc processes run by other users

Since 64a99eb4 git gc refuses to run without the --force option if
another gc process on the same repository is already running.

However, if the repository is shared and user A runs git gc on the
repository and while that gc is still running user B runs git gc on
the same repository the gc process run by user A will not be noticed
and the gc run by user B will go ahead and run.

The problem is that the kill(pid, 0) test fails with an EPERM error
since user B is not allowed to signal processes owned by user A
(unless user B is root).

Update the test to recognize an EPERM error as meaning the process
exists and another gc should not be run (unless --force is given).

Signed-off-by: Kyle J. McKay <mackyle@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t0000: drop "known breakage" testJeff King Sat, 28 Dec 2013 09:33:40 +0000 (04:33 -0500)

t0000: drop "known breakage" test

Having a simulated "known breakage" test means that the test
suite will always tell us there is a bug to be fixed, even
though it is only simulated.

The right way to test this is in a sub-test, that can also
check that we provide the correct exit status and output.
Fortunately, we already have such a test (added much later
by 5ebf89e).

We could arguably get rid of the simulated success test
immediately above, as well, as it is also redundant with the
tests added in 5ebf89e. However, it does not have the
annoying behavior of the "known breakage" test. It may also
be easier to debug if the test suite is truly broken, since
it is not a test-within-a-test, as the later tests are.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t0000: simplify HARNESS_ACTIVE hackJeff King Sat, 28 Dec 2013 09:31:49 +0000 (04:31 -0500)

t0000: simplify HARNESS_ACTIVE hack

Commit 517cd55 set HARNESS_ACTIVE unconditionally in
sub-tests, because that value affects the output of
"--verbose". t0000 needs stable output from its sub-tests,
and we may or may not be running under a TAP harness.

That commit made the decision to always set the variable,
since it has another useful side effect, which is
suppressing writes to t/test-results by the sub-tests (which
would just pollute the real results).

Since the last commit, though, the sub-tests have their own
test-results directories, so this is no longer an issue. We
can now update a few comments that are no longer accurate
nor necessary.

We can also revisit the choice of HARNESS_ACTIVE. Since we
must choose one value for stability, it's probably saner to
have it off. This means that future patches could test
things like the test-results writing, or the "--quiet"
option, which is currently ignored when run under a harness.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t0000: set TEST_OUTPUT_DIRECTORY for sub-testsJeff King Sat, 28 Dec 2013 09:29:15 +0000 (04:29 -0500)

t0000: set TEST_OUTPUT_DIRECTORY for sub-tests

Running t0000 produces more trash directories than expected and does
not clean up after itself:

$ ./t0000-basic.sh
[...]
$ ls -d trash\ directory.*
trash directory.failing-cleanup
trash directory.mixed-results1
trash directory.mixed-results2
trash directory.partial-pass
trash directory.test-verbose
trash directory.test-verbose-only-2

These scratch areas for sub-tests should be under the t0000 trash
directory, but because TEST_OUTPUT_DIRECTORY defaults to
TEST_DIRECTORY, which is exported to help sub-tests find
test-lib.sh, the sub-test trash directories are created under the
toplevel t/ directory instead. Because some of the sub-tests
simulate failures, their trash directories are kept around.

Fix it by explicitly setting TEST_OUTPUT_DIRECTORY appropriately for
sub-tests.

An alternative fix would be to pass the --root parameter that only
specifies where to put the trash directories, which would also work.
However, using TEST_OUTPUT_DIRECTORY is more futureproof in case
tests want to write more output in addition to the test-results/
(which are already suppressed in sub-tests using the HARNESS_ACTIVE
setting) and trash directories.

This fixes a regression introduced by 38b074d (t/test-lib.sh: fix
TRASH_DIRECTORY handling, 2013-04-14). Before that commit, the
TEST_OUTPUT_DIRECTORY setting was not respected consistently so most
tests did their work in a "trash" subdirectory of the current
directory instead of the output dir.

Signed-off-by: Jeff King <peff@peff.net>
Clarified-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

use distinct username/password for http auth testsJeff King Thu, 2 Jan 2014 07:38:35 +0000 (02:38 -0500)

use distinct username/password for http auth tests

The httpd server we set up to test git's http client code
knows about a single account, in which both the username and
password are "user@host" (the unusual use of the "@" here is
to verify that we handle the character correctly when URL
escaped).

This means that we may miss a certain class of errors in
which the username and password are mixed up internally by
git. We can make our tests more robust by having distinct
values for the username and password.

In addition to tweaking the server passwd file and the
client URL, we must teach the "askpass" harness to accept
multiple values. As a bonus, this makes the setup of some
tests more obvious; when we are expecting git to ask
only about the password, we can seed the username askpass
response with a bogus value.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Revert "prompt: clean up strbuf usage"Jeff King Thu, 2 Jan 2014 03:03:30 +0000 (22:03 -0500)

Revert "prompt: clean up strbuf usage"

This reverts commit 31b49d9b653803e7c7fd18b21c8bdd86e3421668.

That commit taught do_askpass to hand ownership of our
buffer back to the caller rather than simply return a
pointer into our internal strbuf. What it failed to notice,
though, was that our internal strbuf is static, because we
are trying to emulate the getpass() interface.

By handing off ownership, we created a memory leak that
cannot be solved. Sometimes git_prompt returns a static
buffer from getpass() (or our smarter git_terminal_prompt
wrapper), and sometimes it returns an allocated string from
do_askpass.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Add MirBSD support to the build system.Benny Siegert Tue, 31 Dec 2013 14:36:45 +0000 (14:36 +0000)

Add MirBSD support to the build system.

Add an entry into the table of supported OSes. Do not set _XOPEN_SOURCE
(contrary to OpenBSD) because that disables the u_short and u_long
typedefs, which are used unconditionally in various other header files.

Signed-off-by: Benny Siegert <bsiegert@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

replace info: rename 'full' to 'long' and clarify in... Christian Couder Sat, 28 Dec 2013 11:00:05 +0000 (12:00 +0100)

replace info: rename 'full' to 'long' and clarify in-code symbols

Enum names SHORT/MEDIUM/FULL were too broad to be descriptive. And
they clashed with built-in symbols on platforms like Windows.
Clarify by giving them REPLACE_FORMAT_ prefix.

Rename 'full' format in "git replace --format=<name>" to 'long', to
match others (i.e. 'short' and 'medium').

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'maint'Junio C Hamano Mon, 30 Dec 2013 20:27:01 +0000 (12:27 -0800)

Merge branch 'maint'

* maint:
for-each-ref: remove unused variable

for-each-ref: remove unused variableRamkumar Ramachandra Mon, 30 Dec 2013 16:28:55 +0000 (21:58 +0530)

for-each-ref: remove unused variable

No code ever used this symbol since the command was introduced at
9f613ddd (Add git-for-each-ref: helper for language bindings,
2006-09-15).

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>