Merge branch 'jk/dev-build-format-security'
authorJunio C Hamano <gitster@pobox.com>
Fri, 18 Jan 2019 21:49:55 +0000 (13:49 -0800)
committerJunio C Hamano <gitster@pobox.com>
Fri, 18 Jan 2019 21:49:55 +0000 (13:49 -0800)
Earlier we added "-Wformat-security" to developer builds, assuming
that "-Wall" (which includes "-Wformat" which in turn is required
to use "-Wformat-security") is always in effect. This is not true
when config.mak.autogen is in use, unfortunately. This has been
fixed by unconditionally adding "-Wall" to developer builds.

* jk/dev-build-format-security:
config.mak.dev: add -Wall, primarily for -Wformat, to help autoconf users

1  2 
config.mak.dev
diff --cc config.mak.dev
index bbeeff44fe1e9b4a864cd0dc082906041d65de51,74337f1f920a3ed03ae2bf88bd30133ec5c03139..7354fe15b3d93737b1c15c74943da2b7630108d6
@@@ -1,11 -1,7 +1,12 @@@
  ifeq ($(filter no-error,$(DEVOPTS)),)
  CFLAGS += -Werror
  endif
 +ifneq ($(filter pedantic,$(DEVOPTS)),)
 +CFLAGS += -pedantic
 +# don't warn for each N_ use
 +CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
 +endif
+ CFLAGS += -Wall
  CFLAGS += -Wdeclaration-after-statement
  CFLAGS += -Wformat-security
  CFLAGS += -Wno-format-zero-length